linux.git/drivers/net/wireless/ray_cs.c, branch master

wifi: move raycs, wl3501 and rndis_wlan to legacy directory

2023-03-13T13:42:14+00:00

To clean up drivers/net/wireless move the old drivers drivers left in the
directory to a new "legacy" directory. I did consider adding
CONFIG_WLAN_VENDOR_LEGACY like other vendors have but then dropped the idea as
these are really old drivers and hopefully we get to remove them soon.

There should be no changes in compilation or in Kconfig options, merely moving files.

Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230227121732.8967-3-kvalo@kernel.org

wifi: ray_cs: Drop useless status variable in parse_addr()

2022-06-08T08:08:34+00:00

The status variable assigned only once and used also only once.
Replace it's usage by actual value.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20220603164414.48436-2-andriy.shevchenko@linux.intel.com

wifi: ray_cs: Utilize strnlen() in parse_addr()

2022-06-08T08:08:34+00:00

Instead of doing simple operations and using an additional variable on stack,
utilize strnlen() and reuse len variable.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20220603164414.48436-1-andriy.shevchenko@linux.intel.com

ray_cs: Check ioremap return value

2022-02-01T12:24:35+00:00

As the possible failure of the ioremap(), the 'local->sram' and other
two could be NULL.
Therefore it should be better to check it in order to avoid the later
dev_dbg.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jiasheng Jiang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211230022926.1846757-1-jiasheng@iscas.ac.cn

proc: remove PDE_DATA() completely

2022-01-22T06:33:37+00:00

Remove PDE_DATA() completely and replace it with pde_data().

[akpm@linux-foundation.org: fix naming clash in drivers/nubus/proc.c]
[akpm@linux-foundation.org: now fix it properly]

Link: https://lkml.kernel.org/r/20211124081956.87711-2-songmuchun@bytedance.com
Signed-off-by: Muchun Song 
Acked-by: Christian Brauner 
Cc: Alexey Dobriyan 
Cc: Alexey Gladkov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ray_cs: use eth_hw_addr_set()

2021-10-20T09:39:46+00:00

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211018235021.1279697-14-kuba@kernel.org

ray_cs: Split memcpy() to avoid bounds check warning

2021-08-21T17:15:36+00:00

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memcpy(), memmove(), and memset(), avoid
intentionally writing across neighboring fields.

Split memcpy() for each address range to help memcpy() correctly reason
about the bounds checking. Avoids the future warning:

In function 'fortify_memcpy_chk',
    inlined from 'memcpy_toio' at ./include/asm-generic/io.h:1204:2,
    inlined from 'ray_build_header.constprop' at drivers/net/wireless/ray_cs.c:984:3:
./include/linux/fortify-string.h:285:4: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
  285 |    __write_overflow_field(p_size_field, size);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Cc: Kalle Valo 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210819202825.3545692-4-keescook@chromium.org

ray_cs: use %*ph to print small buffer

2021-08-21T17:14:20+00:00

Use %*ph format to print small buffer as hex string.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210712142943.23981-1-andriy.shevchenko@linux.intel.com

ray_cs: Use fallthrough pseudo-keyword

2020-11-07T11:30:09+00:00

In order to enable -Wimplicit-fallthrough for Clang[1], replace the
existing /* fall through */ comments with the new pseudo-keyword
macro fallthrough[2].

[1] https://git.kernel.org/linus/e2079e93f562c7f7a030eb7642017ee5eabaaa10
[2] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201008220422.GA6926@embeddedor

ray_cs: use true,false for bool variable

2020-05-06T08:33:23+00:00

Fix the following coccicheck warning:

drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
bool variable
drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
bool variable

Signed-off-by: Jason Yan 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200426103709.6730-1-yanaijie@huawei.com