<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/net/wireless/ralink, branch v6.5</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>wifi: rt2x00: fix the typo in comments</title>
<updated>2023-06-15T07:46:08+00:00</updated>
<author>
<name>Deming Wang</name>
<email>wangdeming@inspur.com</email>
</author>
<published>2023-06-12T11:46:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=52818fce28b216ef90edbb2b8e134534cf6364c6'/>
<id>52818fce28b216ef90edbb2b8e134534cf6364c6</id>
<content type='text'>
Fix typo in the description of 'non-succesfull'.

Signed-off-by: Deming Wang &lt;wangdeming@inspur.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20230612114612.1640-1-wangdeming@inspur.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix typo in the description of 'non-succesfull'.

Signed-off-by: Deming Wang &lt;wangdeming@inspur.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20230612114612.1640-1-wangdeming@inspur.com
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: Fix memory leak when handling surveys</title>
<updated>2023-04-03T13:44:27+00:00</updated>
<author>
<name>Armin Wolf</name>
<email>W_Armin@gmx.de</email>
</author>
<published>2023-03-30T21:56:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=cbef9a83c51dfcb07f77cfa6ac26f53a1ea86f49'/>
<id>cbef9a83c51dfcb07f77cfa6ac26f53a1ea86f49</id>
<content type='text'>
When removing a rt2x00 device, its associated channel surveys
are not freed, causing a memory leak observable with kmemleak:

unreferenced object 0xffff9620f0881a00 (size 512):
  comm "systemd-udevd", pid 2290, jiffies 4294906974 (age 33.768s)
  hex dump (first 32 bytes):
    70 44 12 00 00 00 00 00 92 8a 00 00 00 00 00 00  pD..............
    00 00 00 00 00 00 00 00 ab 87 01 00 00 00 00 00  ................
  backtrace:
    [&lt;ffffffffb0ed858b&gt;] __kmalloc+0x4b/0x130
    [&lt;ffffffffc1b0f29b&gt;] rt2800_probe_hw+0xc2b/0x1380 [rt2800lib]
    [&lt;ffffffffc1a9496e&gt;] rt2800usb_probe_hw+0xe/0x60 [rt2800usb]
    [&lt;ffffffffc1ae491a&gt;] rt2x00lib_probe_dev+0x21a/0x7d0 [rt2x00lib]
    [&lt;ffffffffc1b3b83e&gt;] rt2x00usb_probe+0x1be/0x980 [rt2x00usb]
    [&lt;ffffffffc05981e2&gt;] usb_probe_interface+0xe2/0x310 [usbcore]
    [&lt;ffffffffb13be2d5&gt;] really_probe+0x1a5/0x410
    [&lt;ffffffffb13be5c8&gt;] __driver_probe_device+0x78/0x180
    [&lt;ffffffffb13be6fe&gt;] driver_probe_device+0x1e/0x90
    [&lt;ffffffffb13be972&gt;] __driver_attach+0xd2/0x1c0
    [&lt;ffffffffb13bbc57&gt;] bus_for_each_dev+0x77/0xd0
    [&lt;ffffffffb13bd2a2&gt;] bus_add_driver+0x112/0x210
    [&lt;ffffffffb13bfc6c&gt;] driver_register+0x5c/0x120
    [&lt;ffffffffc0596ae8&gt;] usb_register_driver+0x88/0x150 [usbcore]
    [&lt;ffffffffb0c011c4&gt;] do_one_initcall+0x44/0x220
    [&lt;ffffffffb0d6134c&gt;] do_init_module+0x4c/0x220

Fix this by freeing the channel surveys on device removal.

Tested with a RT3070 based USB wireless adapter.

Fixes: 5447626910f5 ("rt2x00: save survey for every channel visited")
Signed-off-by: Armin Wolf &lt;W_Armin@gmx.de&gt;
Reviewed-by: Simon Horman &lt;simon.horman@corigine.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20230330215637.4332-1-W_Armin@gmx.de
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When removing a rt2x00 device, its associated channel surveys
are not freed, causing a memory leak observable with kmemleak:

unreferenced object 0xffff9620f0881a00 (size 512):
  comm "systemd-udevd", pid 2290, jiffies 4294906974 (age 33.768s)
  hex dump (first 32 bytes):
    70 44 12 00 00 00 00 00 92 8a 00 00 00 00 00 00  pD..............
    00 00 00 00 00 00 00 00 ab 87 01 00 00 00 00 00  ................
  backtrace:
    [&lt;ffffffffb0ed858b&gt;] __kmalloc+0x4b/0x130
    [&lt;ffffffffc1b0f29b&gt;] rt2800_probe_hw+0xc2b/0x1380 [rt2800lib]
    [&lt;ffffffffc1a9496e&gt;] rt2800usb_probe_hw+0xe/0x60 [rt2800usb]
    [&lt;ffffffffc1ae491a&gt;] rt2x00lib_probe_dev+0x21a/0x7d0 [rt2x00lib]
    [&lt;ffffffffc1b3b83e&gt;] rt2x00usb_probe+0x1be/0x980 [rt2x00usb]
    [&lt;ffffffffc05981e2&gt;] usb_probe_interface+0xe2/0x310 [usbcore]
    [&lt;ffffffffb13be2d5&gt;] really_probe+0x1a5/0x410
    [&lt;ffffffffb13be5c8&gt;] __driver_probe_device+0x78/0x180
    [&lt;ffffffffb13be6fe&gt;] driver_probe_device+0x1e/0x90
    [&lt;ffffffffb13be972&gt;] __driver_attach+0xd2/0x1c0
    [&lt;ffffffffb13bbc57&gt;] bus_for_each_dev+0x77/0xd0
    [&lt;ffffffffb13bd2a2&gt;] bus_add_driver+0x112/0x210
    [&lt;ffffffffb13bfc6c&gt;] driver_register+0x5c/0x120
    [&lt;ffffffffc0596ae8&gt;] usb_register_driver+0x88/0x150 [usbcore]
    [&lt;ffffffffb0c011c4&gt;] do_one_initcall+0x44/0x220
    [&lt;ffffffffb0d6134c&gt;] do_init_module+0x4c/0x220

Fix this by freeing the channel surveys on device removal.

Tested with a RT3070 based USB wireless adapter.

Fixes: 5447626910f5 ("rt2x00: save survey for every channel visited")
Signed-off-by: Armin Wolf &lt;W_Armin@gmx.de&gt;
Reviewed-by: Simon Horman &lt;simon.horman@corigine.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20230330215637.4332-1-W_Armin@gmx.de
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: Remove useless else if</title>
<updated>2023-01-16T16:23:49+00:00</updated>
<author>
<name>Jiapeng Chong</name>
<email>jiapeng.chong@linux.alibaba.com</email>
</author>
<published>2023-01-06T02:27:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=ebe8dee7aea6be7a775de718ee8fa93f77e3e4af'/>
<id>ebe8dee7aea6be7a775de718ee8fa93f77e3e4af</id>
<content type='text'>
The assignment of the else and else if branches is the same, so the else
if here is redundant, so we remove it.

./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING:
possible condition with no effect (if == else).

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631
Reported-by: Abaci Robot &lt;abaci@linux.alibaba.com&gt;
Signed-off-by: Jiapeng Chong &lt;jiapeng.chong@linux.alibaba.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20230106022731.111243-1-jiapeng.chong@linux.alibaba.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The assignment of the else and else if branches is the same, so the else
if here is redundant, so we remove it.

./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING:
possible condition with no effect (if == else).

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631
Reported-by: Abaci Robot &lt;abaci@linux.alibaba.com&gt;
Signed-off-by: Jiapeng Chong &lt;jiapeng.chong@linux.alibaba.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20230106022731.111243-1-jiapeng.chong@linux.alibaba.com
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net</title>
<updated>2022-11-11T01:43:53+00:00</updated>
<author>
<name>Jakub Kicinski</name>
<email>kuba@kernel.org</email>
</author>
<published>2022-11-11T01:43:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=966a9b49033b472dcfb453abdc34bca7df17adce'/>
<id>966a9b49033b472dcfb453abdc34bca7df17adce</id>
<content type='text'>
drivers/net/can/pch_can.c
  ae64438be192 ("can: dev: fix skb drop check")
  1dd1b521be85 ("can: remove obsolete PCH CAN driver")
https://lore.kernel.org/all/20221110102509.1f7d63cc@canb.auug.org.au/

Signed-off-by: Jakub Kicinski &lt;kuba@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
drivers/net/can/pch_can.c
  ae64438be192 ("can: dev: fix skb drop check")
  1dd1b521be85 ("can: remove obsolete PCH CAN driver")
https://lore.kernel.org/all/20221110102509.1f7d63cc@canb.auug.org.au/

Signed-off-by: Jakub Kicinski &lt;kuba@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: use explicitly signed or unsigned types</title>
<updated>2022-10-21T06:59:39+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2022-10-19T15:55:41+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=66063033f77e10b985258126a97573f84bb8d3b4'/>
<id>66063033f77e10b985258126a97573f84bb8d3b4</id>
<content type='text'>
On some platforms, `char` is unsigned, but this driver, for the most
part, assumed it was signed. In other places, it uses `char` to mean an
unsigned number, but only in cases when the values are small. And in
still other places, `char` is used as a boolean. Put an end to this
confusion by declaring explicit types, depending on the context.

Cc: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Cc: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Cc: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Cc: Helmut Schaa &lt;helmut.schaa@googlemail.com&gt;
Cc: Kalle Valo &lt;kvalo@kernel.org&gt;
Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20221019155541.3410813-1-Jason@zx2c4.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On some platforms, `char` is unsigned, but this driver, for the most
part, assumed it was signed. In other places, it uses `char` to mean an
unsigned number, but only in cases when the values are small. And in
still other places, `char` is used as a boolean. Put an end to this
confusion by declaring explicit types, depending on the context.

Cc: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Cc: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Cc: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Cc: Helmut Schaa &lt;helmut.schaa@googlemail.com&gt;
Cc: Kalle Valo &lt;kvalo@kernel.org&gt;
Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/20221019155541.3410813-1-Jason@zx2c4.com
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: mac80211: add wake_tx_queue callback to drivers</title>
<updated>2022-10-10T09:00:03+00:00</updated>
<author>
<name>Alexander Wetzel</name>
<email>alexander@wetzel-home.de</email>
</author>
<published>2022-10-09T16:30:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=a790cc3a4fad75048295571a350b95b87e022a5a'/>
<id>a790cc3a4fad75048295571a350b95b87e022a5a</id>
<content type='text'>
mac80211 is fully switching over to the internal TX queue (iTXQ)
implementation. Update all drivers not yet providing the now mandatory
wake_tx_queue() callback.

As an side effect the netdev interfaces of all updated drivers will
switch to the noqueue qdisc.

Signed-off-by: Alexander Wetzel &lt;alexander@wetzel-home.de&gt;
[add staging drivers]
Signed-off-by: Johannes Berg &lt;johannes.berg@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
mac80211 is fully switching over to the internal TX queue (iTXQ)
implementation. Update all drivers not yet providing the now mandatory
wake_tx_queue() callback.

As an side effect the netdev interfaces of all updated drivers will
switch to the noqueue qdisc.

Signed-off-by: Alexander Wetzel &lt;alexander@wetzel-home.de&gt;
[add staging drivers]
Signed-off-by: Johannes Berg &lt;johannes.berg@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: correctly set BBP register 86 for MT7620</title>
<updated>2022-09-24T12:30:58+00:00</updated>
<author>
<name>Daniel Golle</name>
<email>daniel@makrotopia.org</email>
</author>
<published>2022-09-17T20:30:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=c9aada64fe6493461127f1522d7e2f01792d2424'/>
<id>c9aada64fe6493461127f1522d7e2f01792d2424</id>
<content type='text'>
Instead of 0 set the correct value for BBP register 86 for MT7620.

Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/257267247ee4fa7ebc6a5d0c4948b3f8119c0d77.1663445157.git.daniel@makrotopia.org
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of 0 set the correct value for BBP register 86 for MT7620.

Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/257267247ee4fa7ebc6a5d0c4948b3f8119c0d77.1663445157.git.daniel@makrotopia.org
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: set SoC wmac clock register</title>
<updated>2022-09-24T12:30:57+00:00</updated>
<author>
<name>Daniel Golle</name>
<email>daniel@makrotopia.org</email>
</author>
<published>2022-09-17T20:29:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=cbde6ed406a51092d9e8a2df058f5f8490f27443'/>
<id>cbde6ed406a51092d9e8a2df058f5f8490f27443</id>
<content type='text'>
Instead of using the default value 33 (pci), set US_CYC_CNT init based
on Programming guide:
If available, set chipset bus clock with fallback to cpu clock/3.

Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/3e275d259f476f597dab91a9c395015ef3fe3284.1663445157.git.daniel@makrotopia.org
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of using the default value 33 (pci), set US_CYC_CNT init based
on Programming guide:
If available, set chipset bus clock with fallback to cpu clock/3.

Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/3e275d259f476f597dab91a9c395015ef3fe3284.1663445157.git.daniel@makrotopia.org
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: set VGC gain for both chains of MT7620</title>
<updated>2022-09-24T12:30:57+00:00</updated>
<author>
<name>Daniel Golle</name>
<email>daniel@makrotopia.org</email>
</author>
<published>2022-09-17T20:29:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=0e09768c085709e10ece3b68f6ac921d3f6a9caa'/>
<id>0e09768c085709e10ece3b68f6ac921d3f6a9caa</id>
<content type='text'>
Set bbp66 for all chains of the MT7620.

Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/29e161397e5c9d9399da0fe87d44458aa2b90a78.1663445157.git.daniel@makrotopia.org
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Set bbp66 for all chains of the MT7620.

Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/29e161397e5c9d9399da0fe87d44458aa2b90a78.1663445157.git.daniel@makrotopia.org
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: rt2x00: set correct TX_SW_CFG1 MAC register for MT7620</title>
<updated>2022-09-24T12:30:57+00:00</updated>
<author>
<name>Daniel Golle</name>
<email>daniel@makrotopia.org</email>
</author>
<published>2022-09-17T20:29:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=eeb50acf15762b61921f9df18663f839f387c054'/>
<id>eeb50acf15762b61921f9df18663f839f387c054</id>
<content type='text'>
Set correct TX_SW_CFG1 MAC register as it is done also in v3 of the
vendor driver[1].

[1]: https://gitlab.com/dm38/padavan-ng/-/blob/master/trunk/proprietary/rt_wifi/rtpci/3.0.X.X/mt76x2/chips/rt6352.c#L531
Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/4be38975ce600a34249e12d09a3cb758c6e71071.1663445157.git.daniel@makrotopia.org
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Set correct TX_SW_CFG1 MAC register as it is done also in v3 of the
vendor driver[1].

[1]: https://gitlab.com/dm38/padavan-ng/-/blob/master/trunk/proprietary/rt_wifi/rtpci/3.0.X.X/mt76x2/chips/rt6352.c#L531
Reported-by: Serge Vasilugin &lt;vasilugin@yandex.ru&gt;
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
Acked-by: Stanislaw Gruszka &lt;stf_xl@wp.pl&gt;
Signed-off-by: Kalle Valo &lt;kvalo@kernel.org&gt;
Link: https://lore.kernel.org/r/4be38975ce600a34249e12d09a3cb758c6e71071.1663445157.git.daniel@makrotopia.org
</pre>
</div>
</content>
</entry>
</feed>
