linux.git/drivers/net/wireless/intersil, branch v6.7

wifi: hostap: remove unused ioctl function

2023-10-14T06:41:22+00:00

The ioctl handler has no actual callers in the kernel and is useless.
All the functionality should be reachable through the regualar interfaces.

Acked-by: Kalle Valo 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231011140225.253106-9-arnd@kernel.org

wifi: p54: Annotate struct p54_cal_database with __counted_by

2023-10-12T12:12:11+00:00

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

Add __counted_by for struct p54_cal_database.

Cc: Christian Lamparter 
Cc: Kalle Valo 
Cc: "Gustavo A. R. Silva" 
Cc: linux-wireless@vger.kernel.org
Cc: linux-hardening@vger.kernel.org
Suggested-by: Jason Andryuk 
Signed-off-by: Kees Cook 
Reviewed-by: Jason Andryuk 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231009161028.it.544-kees@kernel.org

wifi: hostap: Add __counted_by for struct prism2_download_data and use struct_size()

2023-10-11T09:20:12+00:00

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

While there, use struct_size() helper, instead of the open-coded
version, to calculate the size for the allocation of the whole
flexible structure, including of course, the flexible-array member.

This code was found with the help of Coccinelle, and audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Kees Cook 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/ZSRXXvWMMkm7qqRW@work

Fix nomenclature for USB and PCI wireless devices

2023-08-25T09:56:49+00:00

A mouse that uses a USB connection is called a "USB mouse" device (or
"USB mouse" for short), not a "mouse USB" device.  By analogy, a WiFi
adapter that connects to the host computer via USB is a "USB wireless"
device, not a "wireless USB" device.  (The latter term more properly
refers to a defunct Wireless USB specification, which described a
technology for sending USB protocol messages over an ultra wideband
radio link.)

Similarly for a WiFi adapter card that plugs into a PCIe slot: It is a
"PCIe wireless" device, not a "wireless PCIe" device.

Rephrase the text in the kernel source where the word ordering is
wrong.

Signed-off-by: Alan Stern 
Reviewed-by: Greg Kroah-Hartman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/57da7c80-0e48-41b5-8427-884a02648f55@rowland.harvard.edu

wifi: drivers: Explicitly include correct DT includes

2023-08-01T14:48:38+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230724211914.805876-1-robh@kernel.org

wifi: p54: Add missing MODULE_FIRMWARE macro

2023-06-21T09:53:30+00:00

Add the missing MODULE_FIRMWARE macro for "3826.eeprom".

Signed-off-by: Juerg Haefliger 
Acked-by: Christian Lamparter 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230616121917.1034761-1-juerg.haefliger@canonical.com

wifi: hostap: fix stringop-truncations GCC warning

2023-06-16T09:24:16+00:00

With GCC 13.1 and W=1 hostap has a warning:

drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3633:17: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]

fortify-string.h recommends not to use strncpy() so use strscpy() which fixes
the warning. Also now it's guarenteed that the string is NUL-terminated.

Compile tested only.

Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230613140918.389690-4-kvalo@kernel.org

wifi: orinoco: Fix an error handling path in orinoco_cs_probe()

2023-05-25T16:15:40+00:00

Should orinoco_cs_config() fail, some resources need to be released as
already done in the remove function.

While at it, remove a useless and erroneous comment. The probe is
orinoco_cs_probe(), not orinoco_cs_attach().

Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/e24735ce4d82901d5f7ea08419eea53bfdde3d65.1684568286.git.christophe.jaillet@wanadoo.fr

wifi: orinoco: Fix an error handling path in spectrum_cs_probe()

2023-05-25T16:15:09+00:00

Should spectrum_cs_config() fail, some resources need to be released as
already done in the remove function.

While at it, remove a useless and erroneous comment. The probe is
spectrum_cs_probe(), not spectrum_cs_attach().

Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Christophe JAILLET 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/c0bc0c21c58ca477fc5521607615bafbf2aef8eb.1684567733.git.christophe.jaillet@wanadoo.fr

wifi: add HAS_IOPORT dependencies

2023-05-25T16:08:30+00:00

In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. We thus need to add HAS_IOPORT as dependency for
those drivers using them.

Co-developed-by: Arnd Bergmann 
Signed-off-by: Arnd Bergmann 
Acked-by: Kalle Valo 
Signed-off-by: Niklas Schnelle 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230522105049.1467313-44-schnelle@linux.ibm.com