linux.git/drivers/net/wireless/intel, branch v5.5-rc5

Merge tag 'wireless-drivers-2019-12-17' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers

2019-12-17T22:27:35+00:00

Kalle Valo says:

====================
wireless-drivers fixes for v5.5

First set of fixes for v5.5. Fixing security issues, some regressions
and few major bugs.

mwifiex

* security fix for handling country Information Elements (CVE-2019-14895)

* security fix for handling TDLS Information Elements

ath9k

* fix endian issue with ath9k_pci_owl_loader

mt76

* fix default mac address handling

iwlwifi

* fix merge damage which lead to firmware crashing during boot on some devices

* fix device initialisation regression on some devices
====================

Signed-off-by: David S. Miller

iwlwifi: pcie: move power gating workaround earlier in the flow

2019-12-10T08:39:39+00:00

We need to reset the NIC after setting the bits to enable power
gating and that cannot be done too late in the flow otherwise it
cleans other registers and things that were already configured,
causing initialization to fail.

In order to fix this, move the function to the common code in trans.c
so it can be called directly from there at an earlier point, just
after the reset we already do during initialization.

Fixes: 9a47cb988338 ("iwlwifi: pcie: add workaround for power gating in integrated 22000")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=205719
Cc: stable@ver.kernel.org # 5.4+
Reported-by: Anders Kaseorg 
Signed-off-by: Luca Coelho 
Signed-off-by: Kalle Valo

Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"

2019-12-10T08:32:36+00:00

This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.

Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
attempted to fix the same bug (dead assignments to the local variable
cfg), but they did so in incompatible ways. When they were both merged,
independently of each other, the combination actually caused the bug to
reappear, leading to a firmware crash on boot for some cards.

https://bugzilla.kernel.org/show_bug.cgi?id=205719

Signed-off-by: Anders Kaseorg 
Acked-by: Luca Coelho 
Signed-off-by: Kalle Valo

net: wireless: intel: iwlwifi: fix GRO_NORMAL packet stalling

2019-11-27T19:22:51+00:00

Commit 6570bc79c0df ("net: core: use listified Rx for GRO_NORMAL in
napi_gro_receive()") has applied batched GRO_NORMAL packets processing
to all napi_gro_receive() users, including mac80211-based drivers.

However, this change has led to a regression in iwlwifi driver [1][2] as
it is required for NAPI users to call napi_complete_done() or
napi_complete() and the end of every polling iteration, whilst iwlwifi
doesn't use NAPI scheduling at all and just calls napi_gro_flush().
In that particular case, packets which have not been already flushed
from napi->rx_list stall in it until at least next Rx cycle.

Fix this by adding a manual flushing of the list to iwlwifi driver right
before napi_gro_flush() call to mimic napi_complete() logics.

I prefer to open-code gro_normal_list() rather than exporting it for 2
reasons:
* to prevent from using it and napi_gro_flush() in any new drivers,
  as it is the *really* bad way to use NAPI that should be avoided;
* to keep gro_normal_list() static and don't lose any CC optimizations.

I also don't add the "Fixes:" tag as the mentioned commit was only a
trigger that only exposed an improper usage of NAPI in this particular
driver.

[1] https://lore.kernel.org/netdev/PSXP216MB04388962C411CD0B17A86F47804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM
[2] https://bugzilla.kernel.org/show_bug.cgi?id=205647

Signed-off-by: Alexander Lobakin 
Acked-by: Luca Coelho 
Reported-by: Nicholas Johnson 
Tested-by: Nicholas Johnson 
Reviewed-by: Edward Cree 
Signed-off-by: David S. Miller

iwlwifi: bump FW API to 52 for 22000 series

2019-11-20T10:28:56+00:00

Start supporting API version 52 for 22000 series.

Signed-off-by: Luca Coelho

iwlwifi: check kasprintf() return value

2019-11-20T10:28:56+00:00

kasprintf() can fail, we should check the return value.

Fixes: 5ed540aecc2a ("iwlwifi: use mac80211 throughput trigger")
Fixes: 8ca151b568b6 ("iwlwifi: add the MVM driver")
Signed-off-by: Johannes Berg 
Signed-off-by: Luca Coelho

iwlwifi: mvm: remove outdated comment referring to wake lock

2019-11-20T10:28:56+00:00

There's no multicast wake lock in the driver, remove the comment
that refers to it.

Signed-off-by: Johannes Berg 
Signed-off-by: Luca Coelho

iwlwifi: pcie: trace IOVA for iwlwifi_dev_tx_tb

2019-11-20T10:28:55+00:00

We trace the whole TFD with all TBs when in iwlwifi_dev_tx,
but sometimes we add TBs to it later and then we don't have
any of this data. Trace the I/O virtual address (IOVA) (it
can be the physical address, or as returned by the IOMMU)
here to aid debugging the DMA flows.

Signed-off-by: Johannes Berg 
Signed-off-by: Luca Coelho

iwlwifi: dvm: excessive if in rs_bt_update_lq()

2019-11-20T10:28:55+00:00

There is no need to check 'priv->bt_ant_couple_ok' twice in
rs_bt_update_lq(). The second check is always true. Thus, the
expression can be simplified.

Signed-off-by: Denis Efremov 
Signed-off-by: Luca Coelho

iwlwifi: mvm: Report tx/rx antennas

2019-11-20T10:28:55+00:00

This makes it easier for user-space to know how many antennas the
radio has.  Seems to work with the AX200 radio, at least.

Signed-off-by: Ben Greear 
Signed-off-by: Luca Coelho