linux.git/drivers/net/wireless/broadcom, branch v5.16-rc4

brcmfmac: prepare for const netdev->dev_addr

2021-10-20T09:39:44+00:00

netdev->dev_addr will become const soon. Make sure local
variables maintain that qualifier.

Signed-off-by: Jakub Kicinski 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211018235021.1279697-8-kuba@kernel.org

wireless: use eth_hw_addr_set()

2021-10-20T09:39:42+00:00

Convert all WiFi drivers from memcpy(... ETH_ADDR)
to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - memcpy(dev->dev_addr, np, ETH_ALEN)
  + eth_hw_addr_set(dev, np)

Signed-off-by: Jakub Kicinski 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211018235021.1279697-2-kuba@kernel.org

b43: fix a lower bounds test

2021-10-11T06:09:30+00:00

The problem is that "channel" is an unsigned int, when it's less 5 the
value of "channel - 5" is not a negative number as one would expect but
is very high positive value instead.

This means that "start" becomes a very high positive value.  The result
of that is that we never enter the "for (i = start; i <= end; i++) {"
loop.  Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.

Fixes: ef1a628d83fc ("b43: Implement dynamic PHY API")
Signed-off-by: Dan Carpenter 
Acked-by: Michael Büsch 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211006073621.GE8404@kili

b43legacy: fix a lower bounds test

2021-10-11T06:09:29+00:00

The problem is that "channel" is an unsigned int, when it's less 5 the
value of "channel - 5" is not a negative number as one would expect but
is very high positive value instead.

This means that "start" becomes a very high positive value.  The result
of that is that we never enter the "for (i = start; i <= end; i++) {"
loop.  Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Signed-off-by: Dan Carpenter 
Acked-by: Michael Büsch 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211006073542.GD8404@kili

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2021-10-07T22:24:06+00:00

No conflicts.

Signed-off-by: Jakub Kicinski

brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet

2021-10-05T05:31:41+00:00

The Cyberbook T116 tablet contains quite generic names in the sys_vendor
and product_name DMI strings, without this patch brcmfmac will try to load:
"brcmfmac43455-sdio.Default string-Default string.txt" as nvram file which
is way too generic.

The nvram file shipped on the factory Android image contains the exact
same settings as those used on the AcePC T8 mini PC, so point the new
DMI nvram filename quirk to the acepc-t8 nvram file.

Signed-off-by: Hans de Goede 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210928160633.96928-1-hdegoede@redhat.com

Revert "brcmfmac: use ISO3166 country code and 0 rev as fallback"

2021-09-28T07:08:14+00:00

This reverts commit b0b524f079a23e440dd22b04e369368dde847533.

Commit b0b524f079a2 ("brcmfmac: use ISO3166 country code and 0 rev
as fallback") changes country setup to directly use ISO3166 country
codes if no more specific code is configured. This was done under
the assumption that brcmfmac firmwares can handle such simple
direct mapping from country codes to firmware ccode values.

Unfortunately this is not true for all chipset/firmware combinations.
E.g. BCM4359/9 devices stop working as access point with this change,
so revert the offending commit to avoid the regression.

Signed-off-by: Soeren Moch 
Cc: stable@vger.kernel.org  # 5.14.x
Acked-by: Shawn Guo 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210926201905.211605-1-smoch@web.de

brcmfmac: Replace zero-length array with flexible array member

2021-09-24T11:20:44+00:00

There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use "flexible array members"[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].

Also, make use of the struct_size() helper in devm_kzalloc().

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#zero-length-and-one-element-arrays

Signed-off-by: Len Baker 
Reviewed-by: Gustavo A. R. Silva 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210904092217.2848-1-len.baker@gmx.com

brcmfmac: fix incorrect error prints

2021-09-21T05:56:58+00:00

An unsupported AKM would end up printing "invalid cipher group". Instead
print "invalid akm suite" with the offending AKM.

Signed-off-by: James Prestwood 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210901190641.255624-1-prestwoj@gmail.com

brcmfmac: pcie: fix oops on failure to resume and reprobe

2021-08-29T11:45:29+00:00

When resuming from suspend, brcmf_pcie_pm_leave_D3 will first attempt a
hot resume and then fall back to removing the PCI device and then
reprobing. If this probe fails, the kernel will oops, because brcmf_err,
which is called to report the failure will dereference the stale bus
pointer. Open code and use the default bus-less brcmf_err to avoid this.

Fixes: 8602e62441ab ("brcmfmac: pass bus to the __brcmf_err() in pcie.c")
Signed-off-by: Ahmad Fatoum 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210817063521.22450-1-a.fatoum@pengutronix.de