linux.git/drivers/net/wireless/ath, branch v2.6.35

ath9k: fix dma direction for map/unmap in ath_rx_tasklet

2010-07-26T18:41:04+00:00

For edma, we should use DMA_BIDIRECTIONAL, or else use
DMA_FROM_DEVICE.

This is found to address "BUG at arch/x86/mm/physaddr.c:5"
as described here:

http://lkml.org/lkml/2010/7/14/21

Signed-off-by: Ming Lei 
Signed-off-by: John W. Linville

ath9k_htc: fix memory leak in ath9k_hif_usb_alloc_urbs

2010-07-07T19:39:07+00:00

Failure cases within ath9k_hif_usb_alloc_urbs are failed
to release allocated memory.

Signed-off-by: Rajkumar Manoharan 
Signed-off-by: John W. Linville

ath9k: Fix bug in starting ani

2010-06-23T19:28:42+00:00

There are few places where ANI is started without checking
if it is right to start. This might lead to a case where ani
timer would be left undeleted and cause improper memory acccess
during module unload. This bug is clearly exposed with
paprd support where the driver detects tx hang and does a
chip reset. During this reset ani is (re)started without checking
if it needs to be started. This would leave a timer scheduled
even after all the resources are freed and cause a panic.

This patch introduces a bit in sc_flags to indicate if ani
needs to be started in sw_scan_start() and ath_reset().
This would fix the following panic. This issue is easily seen
with ar9003 + paprd.

 BUG: unable to handle kernel paging request at 0000000000003f38
[] ? __queue_work+0x41/0x50
[] run_timer_softirq+0x17a/0x370
[] ? tick_dev_program_event+0x48/0x110
[] __do_softirq+0xb9/0x1f0
[] ? handle_IRQ_event+0x50/0x160
[] call_softirq+0x1c/0x30
[] do_softirq+0x65/0xa0
[] irq_exit+0x85/0x90
[] do_IRQ+0x75/0xf0
[] ret_from_intr+0x0/0x11

[] ? acpi_idle_enter_simple+0xe4/0x119
[] ? acpi_idle_enter_simple+0xdd/0x119
[] cpuidle_idle_call+0xa7/0x140
[] cpu_idle+0xb3/0x110
[] start_secondary+0x1ee/0x1f5

Signed-off-by: Vasanthakumar Thiagarajan 
Signed-off-by: John W. Linville

ath5k: initialize ah->ah_current_channel

2010-06-18T18:59:10+00:00

ath5k assumes ah_current_channel is always a valid pointer in
several places, but a newly created interface may not have a
channel.  To avoid null pointer dereferences, set it up to point
to the first available channel until later reconfigured.

This fixes the following oops:
$ rmmod ath5k
$ insmod ath5k
$ iw phy0 set distance 11000

BUG: unable to handle kernel NULL pointer dereference at 00000006
IP: [] ath5k_hw_set_coverage_class+0x74/0x1b0 [ath5k]
*pde = 00000000
Oops: 0000 [#1]
last sysfs file: /sys/devices/pci0000:00/0000:00:0e.0/ieee80211/phy0/index
Modules linked in: usbhid option usb_storage usbserial usblp evdev lm90
scx200_acb i2c_algo_bit i2c_dev i2c_core via_rhine ohci_hcd ne2k_pci
8390 leds_alix2 xt_IMQ imq nf_nat_tftp nf_conntrack_tftp nf_nat_irc nf_cc

Pid: 1597, comm: iw Not tainted (2.6.32.14 #8)
EIP: 0060:[] EFLAGS: 00010296 CPU: 0
EIP is at ath5k_hw_set_coverage_class+0x74/0x1b0 [ath5k]
EAX: 000000c2 EBX: 00000000 ECX: ffffffff EDX: c12d2080
ESI: 00000019 EDI: cf8c0000 EBP: d0a30edc ESP: cfa09bf4
  DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
Process iw (pid: 1597, ti=cfa09000 task=cf88a000 task.ti=cfa09000)
Stack:
  d0a34f35 d0a353f8 d0a30edc 000000fe cf8c0000 00000000 1900063d cfa8c9e0
<0> cfa8c9e8 cfa8c0c0 cfa8c000 d0a27f0c 199d84b4 cfa8c200 00000010 d09bfdc7
<0> 00000000 00000000 ffffffff d08e0d28 cf9263c0 00000001 cfa09cc4 00000000
Call Trace:
  [] ? ath5k_hw_attach+0xc8c/0x3c10 [ath5k]
  [] ? __ieee80211_request_smps+0x1347/0x1580 [mac80211]
  [] ? nl80211_send_scan_start+0x7b8/0x4520 [cfg80211]
  [] ? nla_parse+0x59/0xc0
  [] ? genl_rcv_msg+0x169/0x1a0
  [] ? genl_rcv_msg+0x0/0x1a0
  [] ? netlink_rcv_skb+0x38/0x90
  [] ? genl_rcv+0x19/0x30
  [] ? netlink_unicast+0x1b3/0x220
  [] ? netlink_sendmsg+0x26e/0x290
  [] ? sock_sendmsg+0xbe/0xf0
  [] ? autoremove_wake_function+0x0/0x50
  [] ? __alloc_pages_nodemask+0x106/0x530
  [] ? do_lookup+0x53/0x1b0
  [] ? __link_path_walk+0x9b9/0x9e0
  [] ? verify_iovec+0x50/0x90
  [] ? sys_sendmsg+0x1e1/0x270
  [] ? find_get_page+0x10/0x50
  [] ? filemap_fault+0x5f/0x370
  [] ? __do_fault+0x319/0x370
  [] ? sys_socketcall+0x244/0x290
  [] ? do_page_fault+0x1ec/0x270
  [] ? do_page_fault+0x0/0x270
  [] ? syscall_call+0x7/0xb
Code: 00 b8 fe 00 00 00 b9 f8 53 a3 d0 89 5c 24 14 89 7c 24 10 89 44 24
0c 89 6c 24 08 89 4c 24 04 c7 04 24 35 4f a3 d0 e8 7c 30 60 f0 <0f> b7
43 06 ba 06 00 00 00 a8 10 75 0e 83 e0 20 83 f8 01 19 d2
EIP: [] ath5k_hw_set_coverage_class+0x74/0x1b0 [ath5k] SS:ESP
0068:cfa09bf4
CR2: 0000000000000006
---[ end trace 54f73d6b10ceb87b ]---

Cc: stable@kernel.org
Reported-by: Steve Brown 
Signed-off-by: Bob Copeland 
Signed-off-by: John W. Linville

ath5k: fix NULL pointer in antenna configuration

2010-06-07T18:43:57+00:00

If the channel is not set yet and we configure the antennas just store the
setting. It will be activated during the next reset, when the channel is set.

Signed-off-by: Bruno Randolf 
Signed-off-by: John W. Linville

ath5k: retain promiscuous setting

2010-06-04T19:50:52+00:00

Commit 56d1de0a21db28e41741cfa0a66e18bc8d920554, "ath5k: clean up
filter flags setting" introduced a regression in monitor mode such
that the promisc filter flag would get lost.

Although we set the promisc flag when it changed, we did not
preserve it across subsequent calls to configure_filter.  This patch
restores the original functionality.

Cc: stable@kernel.org
Bisected-by: weedy2887@gmail.com
Tested-by: weedy2887@gmail.com
Tested-by: Rick Farina 
Signed-off-by: Bob Copeland 
Signed-off-by: John W. Linville

ath5k: depend on CONFIG_PM_SLEEP for suspend/resume functions

2010-06-04T19:50:52+00:00

When building a kernel with CONFIG_PM=y but neither suspend nor
hibernate support, the compiler complains about the static functions
ath5k_pci_suspend() and ath5k_pci_resume() not being used:

drivers/net/wireless/ath/ath5k/base.c:713:12: warning: ‘ath5k_pci_suspend’ defined but not used
drivers/net/wireless/ath/ath5k/base.c:722:12: warning: ‘ath5k_pci_resume’ defined but not used

Depending on CONFIG_PM_SLEEP rather than CONFIG_PM fixes the issue.

Signed-off-by: Tobias Doerffel 
Signed-off-by: John W. Linville

ath5k: wake queues on reset

2010-06-01T18:33:00+00:00

We can wake all queues after a chip reset since everything should be set up and
we are ready to transmit. If we don't do that we might end up starting up with
stopped queues, not beeing able to transmit. (This started to happen after
"ath5k: clean up queue manipulation" but since periodic calibration also
stopped and started the queues this effect was hidden most of the time).

This way we can also get rid of the superfluous ath5k_reset_wake() function.

Signed-off-by: Bruno Randolf 
Acked-by: Nick Kossifidis 
Signed-off-by: John W. Linville

ath9k: Fix bug in the way "bf_tx_aborted" of struct ath_buf is used

2010-05-28T17:40:22+00:00

This bug was introduced by the following commit

	Author: Vasanthakumar Thiagarajan 
	Date:   Thu Apr 15 17:38:46 2010 -0400

	ath9k: Remove ATH9K_TX_SW_ABORTED and introduce a bool for this purpose

Wrong buffer is checked for bf_tx_aborted field in ath_tx_num_badfrms(),
this may result in a rate scaling with wrong feedback (number
of unacked frames in this case). It is the last one in the chain
of buffers for an aggregate frame that should be checked.

Also it misses the initialization of this field in the buffer,
this may lead to a situation where we stop the sw retransmission
of failed subframes associated to this buffer.

Signed-off-by: Vasanthakumar Thiagarajan 
Signed-off-by: John W. Linville

ath9k: Fix ath_print in xmit for hardware reset.

2010-05-28T17:38:49+00:00

ath_print in xmit.c should say "Reseting hardware"
instead of Resetting HAL!(since HAL is being fazed out).
dmesg shows:
[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
[ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!

Signed-off-by: Justin P. Mattock 
Signed-off-by: John W. Linville