linux.git/drivers/net/wan/lapbether.c, branch v5.17 Linux kernel source tree net: use dev_addr_set() 2021-10-09T10:55:01+00:00 Jakub Kicinski kuba@kernel.org 2021-10-08T17:53:39+00:00 ea52a0b58e41c3b2b9e97ff13fe0da9c9e430ea8 Use dev_addr_set() instead of writing directly to netdev->dev_addr in various misc and old drivers. Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
Use dev_addr_set() instead of writing directly to netdev->dev_addr
in various misc and old drivers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: fix the code style issue about line length 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:55+00:00 63a2bb15fe594f328ee1535f3f13e10f863c4c8e According to the chackpatch.pl, line length of 123 exceeds 100 columns, so fix it. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
According to the chackpatch.pl,
line length of 123 exceeds 100 columns, so fix it.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: fix the alignment issue 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:54+00:00 c564c049a34f94b1a4dbe02332b529a6bcb25496 Alignment should match open parenthesis. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Alignment should match open parenthesis.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev" 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:53+00:00 d49859601d72baef143703c6944a4e41921f7e6e According to the chackpatch.pl, comparison to NULL could be written "lapbeth_get_x25_dev". Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
According to the chackpatch.pl, comparison to NULL could
be written "lapbeth_get_x25_dev".

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: fix the comments style issue 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:52+00:00 4f9893c762f8a22df77ed2e4c149ad943c1eaf08 Networking block comments don't use an empty /* line, use /* Comment... Block comments use * on subsequent lines. Block comments use a trailing */ on a separate line. This patch fixes the comments style issues. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Networking block comments don't use an empty /* line,
use /* Comment...

Block comments use * on subsequent lines.
Block comments use a trailing */ on a separate line.

This patch fixes the comments style issues.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: remove unnecessary out of memory message 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:51+00:00 d5e686e8b66d513833e350ab776a8052b0f2ba9e This patch removes unnecessary out of memory message, to fix the following checkpatch.pl warning: "WARNING: Possible unnecessary 'out of memory' message" Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
This patch removes unnecessary out of memory message,
to fix the following checkpatch.pl warning:
"WARNING: Possible unnecessary 'out of memory' message"

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: remove trailing whitespaces 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:50+00:00 2e350780ae4f2be8a2525929b6c69c2dd9591a20 This patch removes trailing whitespaces. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
This patch removes trailing whitespaces.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: move out assignment in if condition 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:49+00:00 a61bebc774cbc6595ca32a8ef69e6fe3289ebb33 Should not use assignment in if condition. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Should not use assignment in if condition.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: add blank line after declarations 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:48+00:00 5bc5f5f27b89fd029515a305caaaf40b77c63c76 This patch fixes the checkpatch error about missing a blank line after declarations. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
This patch fixes the checkpatch error about missing a blank line
after declarations.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: lapbether: remove redundant blank line 2021-06-09T21:02:58+00:00 Peng Li lipeng321@huawei.com 2021-06-09T09:39:47+00:00 eff57ab52cc4bcdca095a5a129bc0912a402af11 This patch the redundant blank line. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
This patch the redundant blank line.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>