linux.git/drivers/net/vmxnet3, branch v4.5

vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-07T20:15:24+00:00

vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other operations,
uses pskb_may_pull to linearize the header portion of an skb.  That operation
eventually uses local_bh_disable/enable to ensure that it doesn't race with the
drivers bottom half handler.  Unfortunately, vmxnet3 preforms this
parse_and_copy operation with a spinlock held and interrupts disabled.  This
causes us to run afoul of the WARN_ON_ONCE(irqs_disabled()) warning in
local_bh_enable, resulting in this:

WARNING: at kernel/softirq.c:159 local_bh_enable+0x59/0x90() (Not tainted)
Hardware name: VMware Virtual Platform
Modules linked in: ipv6 ppdev parport_pc parport microcode e1000 vmware_balloon
vmxnet3 i2c_piix4 sg ext4 jbd2 mbcache sd_mod crc_t10dif sr_mod cdrom mptspi
mptscsih mptbase scsi_transport_spi pata_acpi ata_generic ata_piix vmwgfx ttm
drm_kms_helper drm i2c_core dm_mirror dm_region_hash dm_log dm_mod [last
unloaded: mperf]
Pid: 6229, comm: sshd Not tainted 2.6.32-616.el6.i686 #1
Call Trace:
 [] ? warn_slowpath_common+0x89/0xe0
 [] ? local_bh_enable+0x59/0x90
 [] ? warn_slowpath_null+0x1b/0x20
 [] ? local_bh_enable+0x59/0x90
 [] ? skb_copy_bits+0x126/0x210
 [] ? ext4_ext_find_extent+0x24e/0x2d0 [ext4]
 [] ? __pskb_pull_tail+0x6e/0x2b0
 [] ? vmxnet3_xmit_frame+0xba4/0xef0 [vmxnet3]
 [] ? selinux_ip_postroute+0x56/0x320
 [] ? cfq_add_rq_rb+0x98/0x110
 [] ? packet_rcv+0x48/0x350
 [] ? dev_queue_xmit_nit+0xc9/0x140
...

Fix it by splitting vmxnet3_parse_and_copy_hdr into two functions:

vmxnet3_parse_hdr, which sets up the internal/on stack ctx datastructure, and
pulls the skb (both of which can be done without holding the spinlock with irqs
disabled

and

vmxnet3_copy_header, which just copies the skb to the tx ring under the lock
safely.

tested and shown to correct the described problem.  Applies cleanly to the head
of the net tree

Signed-off-by: Neil Horman 
CC: Shrikrishna Khare 
CC: "VMware, Inc." 
CC: "David S. Miller" 
Acked-by: Shrikrishna Khare 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Update Rx ring 2 max size

2016-02-22T03:04:15+00:00

Device emulation supports max size of 4096.

Signed-off-by: Shrikrishna Khare 
Signed-off-by: Bhavesh Davda 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Fix regression caused by 5738a09

2016-01-06T21:20:13+00:00

Reported-by: Bingkuo Liu 
Signed-off-by: Shrikrishna Khare 
Signed-off-by: David S. Miller

vmxnet3: fix checks for dma mapping errors

2015-12-01T20:19:16+00:00

vmxnet3_drv does not check dma_addr with dma_mapping_error()
after mapping dma memory. The patch adds the checks and
tries to handle failures.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Shrikrishna Khare 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Fix use of mfTableLen for big endian architectures

2015-11-16T20:06:47+00:00

Signed-off-by: Shrikrishna Khare 
Reported-by: Masao Uebayashi 
Signed-off-by: Bhavesh Davda 
Signed-off-by: David S. Miller

drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-16T07:24:10+00:00

Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().

v2: removed unused variable
v3: removed another unused variable

Signed-off-by: Ivan Vecera 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Extend register dump support

2015-09-23T22:06:27+00:00

Signed-off-by: Shrikrishna Khare 
Signed-off-by: Bhavesh Davda 
Acked-by: Srividya Murali 
Signed-off-by: David S. Miller

vmxnet3: prevent receive getting out of sequence on napi poll

2015-07-09T06:36:11+00:00

vmxnet3's current napi path is built to count every rx descriptor we recieve,
and use that as a count of the napi budget.  That means its possible to return
from a napi poll halfway through recieving a fragmented packet accross multiple
dma descriptors.  If that happens, the next napi poll will start with the
descriptor ring in an improper state (e.g. the first descriptor we look at may
have the end-of-packet bit set), which will cause a BUG halt in the driver.

Fix the issue by only counting whole received packets in the napi poll and
returning that value, rather than the descriptor count.

Tested by the reporter and myself, successfully

Signed-off-by: Neil Horman 
CC: Shreyas Bhatewara 
CC: "David S. Miller" 
Acked-by: Andy Gospodarek 
Signed-off-by: David S. Miller

vmxnet3: Bump up driver version number

2015-06-29T16:27:45+00:00

Bump up the driver version number to reflect the changes done to
work with vmxnet3 adapter version 2

Signed-off-by: Shreyas N Bhatewara 
Signed-off-by: David S. Miller

vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)

2015-06-23T13:26:01+00:00

Make the driver understand adapter version 2.

Cc: Rachel Lunnon 
Signed-off-by: Guolin Yang 
Signed-off-by: Shreyas N Bhatewara 
Signed-off-by: David S. Miller