linux.git/drivers/net/virtio_net.c, branch v3.19

Revert "drivers/net: Disable UFO through virtio"

2015-02-04T07:06:43+00:00

This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4.

Now that GSO functionality can correctly track if the fragment
id has been selected and select a fragment id if necessary,
we can re-enable UFO on tap/macvap and virtio devices.

Signed-off-by: Vladislav Yasevich 
Signed-off-by: David S. Miller

virtio_net: Fix napi poll list corruption

2014-12-22T21:10:12+00:00

The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less
interrupt masking in NAPI) breaks virtio_net in an insidious way.

It is now required that if the entire budget is consumed when poll
returns, the napi poll_list must remain empty.  However, like some
other drivers virtio_net tries to do a last-ditch check and if
there is more work it will call napi_schedule and then immediately
process some of this new work.  Should the entire budget be consumed
while processing such new work then we will violate the new caller
contract.

This patch fixes this by not touching any work when we reschedule
in virtio_net.

The worst part of this bug is that the list corruption causes other
napi users to be moved off-list.  In my case I was chasing a stall
in IPsec (IPsec uses netif_rx) and I only belatedly realised that it
was virtio_net which caused the stall even though the virtio_net
poll was still functioning perfectly after IPsec stalled.

Signed-off-by: Herbert Xu 
Acked-by: Jason Wang 
Signed-off-by: David S. Miller

virtio: drop VIRTIO_F_VERSION_1 from drivers

2014-12-09T10:06:32+00:00

Core activates this bit automatically now,
drop it from drivers that set it explicitly.

Signed-off-by: Michael S. Tsirkin

virtio_net: enable v1.0 support

2014-12-09T10:05:28+00:00

Now that we have completed 1.0 support, enable it in our driver.

Signed-off-by: Michael S. Tsirkin

virtio_net: disable mac write for virtio 1.0

2014-12-09T10:05:28+00:00

The spec states that mac in config space is only driver-writable in the
legacy case.  Fence writing it in virtnet_set_mac_address() in the
virtio 1.0 case.

Suggested-by: Cornelia Huck 
Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck

virtio_net: bigger header when VERSION_1 is set

2014-12-09T10:05:28+00:00

With VERSION_1 virtio_net uses same header size
whether mergeable buffers are enabled or not.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Reviewed-by: Jason Wang

virtio_net: stricter short buffer length checks

2014-12-09T10:05:28+00:00

Our buffer length check is not strict enough for mergeable
buffers: buffer can still be shorter that header + address
by 2 bytes.

Fix that up.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Reviewed-by: Jason Wang

virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr

2014-12-09T10:05:28+00:00

virtio 1.0 doesn't use virtio_net_hdr anymore, and in fact, it's not
really useful since virtio_net_hdr_mrg_rxbuf includes that as the first
field anyway.

Let's drop it, precalculate header len and store within vi instead.

This way we can also remove struct skb_vnet_hdr.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Reviewed-by: Jason Wang

virtio_net: pass vi around

2014-12-09T10:05:27+00:00

Too many places poke at [rs]q->vq->vdev->priv just to get
the vi structure.  Let's just pass the pointer around: seems
cleaner, and might even be faster.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck

virtio_net: v1.0 endianness

2014-12-09T10:05:26+00:00

Based on patches by Rusty Russell, Cornelia Huck.
Note: more code changes are needed for 1.0 support
(due to different header size).
So we don't advertize support for 1.0 yet.

Signed-off-by: Rusty Russell 
Signed-off-by: Cornelia Huck 
Signed-off-by: Michael S. Tsirkin