linux.git/drivers/net/usb, branch v3.13-rc2

r8152: fix incorrect type in assignment

2013-11-20T20:09:42+00:00

The data from the hardware should be little endian. Correct the
declaration.

Signed-off-by: Hayes Wang 
Signed-off-by: David S. Miller

r8152: support stopping/waking tx queue

2013-11-20T20:09:42+00:00

The maximum packet number which a tx aggregation buffer could contain
is the tx_qlen.

	tx_qlen = buffer size / (packet size + descriptor size).

If the tx buffer is empty and the queued packets are more than the
maximum value which is defined above, stop the tx queue. Wake the
tx queue if tx queue is stopped and the queued packets are less than
tx_qlen.

Signed-off-by: Hayes Wang 
Signed-off-by: David S. Miller

r8152: modify the tx flow

2013-11-20T20:09:41+00:00

Remove the code for sending the packet in the rtl8152_start_xmit().
Let rtl8152_start_xmit() to queue the packet only, and schedule a
tasklet to send the queued packets. This simplify the code and make
sure all the packet would be sent by the original order.

Signed-off-by: Hayes Wang 
Signed-off-by: David S. Miller

r8152: fix tx/rx memory overflow

2013-11-20T20:09:41+00:00

The tx/rx would access the memory which is out of the desired range.
Modify the method of checking the end of the memory to avoid it.

For r8152_tx_agg_fill(), the variable remain may become negative.
However, the declaration is unsigned, so the while loop wouldn't
break when reaching the end of the desied memory. Although to change
the declaration from unsigned to signed is enough to fix it, I also
modify the checking method for safe. Replace

		remain = rx_buf_sz - sizeof(*tx_desc) -
			 (u32)((void *)tx_data - agg->head);

with

		remain = rx_buf_sz - (int)(tx_agg_align(tx_data) - agg->head);

to make sure the variable remain is always positive. Then, the
overflow wouldn't happen.

For rx_bottom(), the rx_desc should not be used to calculate the
packet length before making sure the rx_desc is in the desired range.
Change the checking to two parts. First, check the descriptor is in
the memory. The other, using the descriptor to find out the packet
length and check if the packet is in the memory.

Signed-off-by: Hayes Wang 
Signed-off-by: David S. Miller

net: cdc_ncm: cleanup a type issue in cdc_ncm_setup()

2013-11-14T08:10:30+00:00

This is harmless but cdc_ncm_setup() returns negative error codes
truncated to u8 values.  There is only one caller and treats all
non-zero returns as errors but doesn't store the the return code.  So
the code works correctly but it's messy and upsets the static checkers.

Signed-off-by: Dan Carpenter 
Signed-off-by: David S. Miller

usbnet: fix status interrupt urb handling

2013-11-14T07:32:37+00:00

Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
"sierra_net: keep status interrupt URB active", sierra_net triggers
status interrupt polling before the net_device is opened (in order to
properly receive the sync message response).

To be able to receive further interrupts, the interrupt urb needs to be
re-submitted, so this patch removes the bogus check for netif_running().

Signed-off-by: Felix Fietkau 
Tested-by: Dan Williams 
Signed-off-by: David S. Miller

net: cdc_ncm: remove non-standard NCM device IDs

2013-11-05T20:21:26+00:00

Remove device IDs of NCM-like (but not NCM-conformant) devices, that are
handled by the huawwei_cdc_ncm driver now.

Signed-off-by: Enrico Mioso 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-11-05T20:21:25+00:00

This driver supports devices using the NCM protocol as an encapsulation layer
for other protocols, like the E3131 Huawei 3G modem. This drivers approach was
heavily inspired by the qmi_wwan/cdc_mbim approach & code model.

Signed-off-by: Enrico Mioso 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: Export cdc_ncm_{tx, rx}_fixup functions for re-use

2013-11-05T20:21:25+00:00

Some drivers implementing NCM-like protocols, may re-use those functions, as is
the case in the huawei_cdc_ncm driver.
Export them via EXPORT_SYMBOL_GPL, in accordance with how other functions have
been exported.

Signed-off-by: Enrico Mioso 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_mbim: fixup error return value

2013-11-04T20:40:16+00:00

Reported-by: Oliver Neukum 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller