linux.git/drivers/net/typhoon.c, branch v2.6.24

typhoon: trivial endianness annotations

2007-12-23T03:53:06+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

typhoon: memory corruptor on big-endian if TSO is enabled

2007-12-23T03:53:06+00:00

txlo_dma_addr should be host-endian; we pass it to typhoon_tso_fill(),
which does arithmetics on it, converts to l-e and passes it to card.
Unfortunately, we forgot le32_to_cpu() when initializing it from
face->txLoAddr, which sits in shared memory and is little-endian.

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

typhoon: missed rx overruns on big-endian

2007-12-23T03:53:05+00:00

rxBuffCleared is little-endian; we miss le32_to_cpu() in checks for
rx ring overruns.

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

typhoon: set_settings broken on big-endian

2007-12-23T03:53:05+00:00

One cpu_to_le16() too many when passing argument for TYPHOON_CMD_XCVR_SELECT;
we end up passing host-endian while the hardware expects little-endian.  The
other place doing that (typhoon_start_runtime()) does the right thing, so the
card will recover at the next ifconfig up/tx timeout/resume, which limits the
amount of mess, but still, WTF?

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

typhoon: missing le32_to_cpu() in get_drvinfo

2007-12-23T03:53:05+00:00

in typhoon_get_drvinfo() .parm2 is little-endian; not critical
since we just get the firmware id flipped in get_drvinfo output
on big-endian boxen, but...

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

typhoon: endianness bug in tx/rx byte counters

2007-12-23T03:53:05+00:00

txBytes and rxBytesGood are both 64bit; using le32_to_cpu() won't work
on big-endian for obvious reasons.

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

Eliminate pointless casts from void* in a few driver irq handlers.

2007-10-23T23:53:16+00:00

Signed-off-by: Jeff Garzik

typhoon: trivial endianness annotations

2007-10-10T23:52:00+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

2007-10-10T23:51:42+00:00

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls

2007-10-10T23:51:17+00:00

For the operations
	get-tx-csum
	get-sg
	get-tso
	get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.

This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.

The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.

[ Resolved conflicts with set/get value ethtool patch... -DaveM ]

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller