linux.git/drivers/net/sky2.c, branch v2.6.37

vlan: Don't check for vlan group before vlan_tx_tag_present.

2010-10-21T08:26:52+00:00

Many (but not all) drivers check to see whether there is a vlan
group configured before using a tag stored in the skb.  There's
not much point in this check since it just throws away data that
should only be present in the expected circumstances.  However,
it will soon be legal and expected to get a vlan tag when no
vlan group is configured, so remove this check from all drivers
to avoid dropping the tags.

Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller

sky2: enable GRO by default

2010-09-16T05:28:09+00:00

The driver has supported GRO for a while, but it was not enabled
by default.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: Code style fixes

2010-07-31T06:59:04+00:00

Fix selected style problems reported by checkpatch.

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

ethtool: Change ethtool_op_set_flags to validate flags

2010-06-30T21:09:35+00:00

ethtool_op_set_flags() does not check for unsupported flags, and has
no way of doing so.  This means it is not suitable for use as a
default implementation of ethtool_ops::set_flags.

Add a 'supported' parameter specifying the flags that the driver and
hardware support, validate the requested flags against this, and
change all current callers to pass this parameter.

Change some other trivial implementations of ethtool_ops::set_flags to
call ethtool_op_set_flags().

Signed-off-by: Ben Hutchings 
Reviewed-by: Stanislaw Gruszka 
Acked-by: Jeff Garzik 
Signed-off-by: David S. Miller

sky2: enable rx/tx in sky2_phy_reinit()

2010-06-23T21:37:04+00:00

sky2_phy_reinit is called by the ethtool helpers sky2_set_settings,
sky2_nway_reset and sky2_set_pauseparam when netif_running.

However, at the end of sky2_phy_init GM_GP_CTRL has GM_GPCR_RX_ENA and
GM_GPCR_TX_ENA cleared. So, doing these commands causes the device to
stop working:

$ ethtool -r eth0
$ ethtool -A eth0 autoneg off

Fix this issue by enabling Rx/Tx after running sky2_phy_init in
sky2_phy_reinit.

Signed-off-by: Brandon Philips 
Tested-by: Brandon Philips 
Cc: stable@kernel.org
Tested-by: Mike McCormack 
Signed-off-by: David S. Miller

sky2: version 1.28

2010-05-14T10:06:22+00:00

Version 1.28

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: Avoid allocating memory in sky2_resume

2010-05-14T10:06:22+00:00

Allocating memory can fail, and since we have the memory we need
in sky2_resume when sky2_suspend is called, just stop the hardware
without freeing the memory it's using.

This avoids the possibility of failing because we can't allocate
memory in sky2_resume(), and allows sharing code with sky2_restart().

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: Refactor down/up code out of sky2_restart()

2010-05-14T10:06:21+00:00

Code to bring down all sky2 interfaces and bring it up
again can be reused in sky2_suspend and sky2_resume.

Factor the code to bring the interfaces down into
sky2_all_down and the up code into sky2_all_up.

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: Shut off interrupts before NAPI

2010-05-14T10:06:21+00:00

Interrupts should be masked, then synchronized, and
finally NAPI should be disabled.

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: Avoid race in sky2_change_mtu

2010-05-14T10:06:20+00:00

netif_stop_queue does not ensure all in-progress transmits are complete,
 so use netif_tx_disable() instead.

Secondly, make sure NAPI polls are disabled before stopping the tx queue,
 otherwise sky2_status_intr might trigger a TX queue wakeup between when
 we stop the queue and NAPI is disabled.

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller