linux.git/drivers/net/sky2.c, branch v2.6.31

sky2: Avoid transmits during sky2_down()

2009-08-04T02:02:36+00:00

This patch supersedes my previous patch "sky2: Avoid transmitting
during sky2_restart".

I have reworked the patch to avoid crashes during both sky2_restart()
and sky2_set_ringparam().

Without this patch, the sky2 driver can be crashed by doing:

# pktgen eth1 &    (transmit many packets on eth1)
# ethtool -G eth1 tx 510

I am aware you object to storing extra state, but I can't see a way
around this. Without remembering that we're restarting,
netif_wake_queue() is called in the ISR from sky2_tx_complete(), and
netif_tx_lock() is used in sky2_tx_done().  If anybody can see a way
around this, please let me know.

Signed-off-by: Mike McCormack 
Signed-off-by: David S. Miller

sky2: Avoid races in sky2_down

2009-07-22T03:57:56+00:00

Reset rx chain before trying to drain it.
Shut interrupts off last, incase there's something to report.

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: revert shutdown changes

2009-07-17T01:05:37+00:00

The commit changes to shutdown path broke startup on some systems.

revert commit c0bad0f2e4366d5bbfe0c4a7a80bca8f4b05272b

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: Fix checksum endianness

2009-06-26T16:28:42+00:00

sky2 driver on PowerPC targets floods kernel log with following errors:

  eth1: hw csum failure.
  Call Trace:
  [ef84b8a0] [c00075e4] show_stack+0x50/0x160 (unreliable)
  [ef84b8d0] [c02fa178] netdev_rx_csum_fault+0x3c/0x5c
  [ef84b8f0] [c02f6920] __skb_checksum_complete_head+0x7c/0x84
  [ef84b900] [c02f693c] __skb_checksum_complete+0x14/0x24
  [ef84b910] [c0337e08] tcp_v4_rcv+0x4c8/0x6f8
  [ef84b940] [c031a9c8] ip_local_deliver+0x98/0x210
  [ef84b960] [c031a788] ip_rcv+0x38c/0x534
  [ef84b990] [c0300338] netif_receive_skb+0x260/0x36c
  [ef84b9c0] [c025de00] sky2_poll+0x5dc/0xcf8
  [ef84ba20] [c02fb7fc] net_rx_action+0xc0/0x144

The NIC is Yukon-2 EC chip revision 1.

Converting checksum field from le16 to CPU byte order fixes the issue.

Signed-off-by: Anton Vorontsov 
Signed-off-by: David S. Miller

sky2: version 1.23

2009-06-18T01:49:48+00:00

Version bump.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: add GRO support

2009-06-18T01:49:47+00:00

Add support for generic receive offload.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: skb recycling

2009-06-18T01:46:54+00:00

This patch implements skb recycling. It reclaims transmitted skb's
for use in the receive ring.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: reduce default transmit ring

2009-06-18T01:46:53+00:00

Reduce the size of the driver transmit ring to reduce latency
and allow qdisc to do better rate control.  Also make it
obvious what the minimum transmit ring allowed is and why.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: receive counter update

2009-06-18T01:46:52+00:00

Since it is likely that there are multiple packets received per
interrupt, only update the receive counters once after all
packets are processed.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

sky2: fix shutdown synchronization

2009-06-18T01:46:51+00:00

The logic in sky2_down was incorrect. Receiver could report status
after rx_stop was called.

The steps need to be:
   * stop new frames from being transmitted
   * shut off transmit/receive logic
   * synchronize with NAPI to process status info about transmitter
     and receiver

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller