linux.git/drivers/net/pppoe.c, branch v2.6.32

PPPoE: Fix flush/close races.

2009-10-26T23:23:20+00:00

Be more careful about the state of pointers during tear-down.
The "pppoe_dev" field can only be looked at safely while holding socket locks.
This subsequently allows for the flush_lock to be killed.

We depend on the PPPOX_CONNECTED state to tell us that that those fields are
valid, so whoever clears that state (pppox_unbind_sock()) is responsible for
the dev_put() call.

We also have to ensure that we delete_item() on all sockets before they are
cleaned up.

The need for these changes has been exposed by scenarios wherein namespace
bindings of ethernet devices change while there are ongoing PPPoE sessions,
which resulted in oopses due to unusual socket connection termination paths,
exposing these issues.

Signed-off-by: Michal Ostrowski 
Reviewed-by: Cyril Gorcunov 
Reported-by: Denys Fedoryschenko 
Tested-by: Denys Fedoryschenko

net,pppoe: fixup module init/exit subsequent calls

2009-08-12T23:39:16+00:00

pernet data should allocated first and freed last
on module init/exit routines otherwise it's possible
to have unserialized calls to packet handling routines.

Signed-off-by: Cyrill Gorcunov 
Signed-off-by: David S. Miller

pppoe: fix /proc/net/pppoe

2009-07-30T21:19:19+00:00

If a socket is hashed in last slot of pppoe hash table (PPPOE_HASH_SIZE-1)
we report it many times (up to filling seq buffer)
(Only the last socket of last slot)

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: convert usage of packet_type to read_mostly

2009-03-10T12:22:43+00:00

Protocols that use packet_type can be __read_mostly section for better
locality. Elminate any unnecessary initializations of NULL.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

drivers/net/ppp*.c: fix sparse warnings: fix signedness

2009-02-18T01:21:12+00:00

Fix this sparse warnings:
  drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness)
  drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness)
  drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness)

Signed-off-by: Hannes Eder 
Acked-by: Cyrill Gorcunov 
Signed-off-by: David S. Miller

ppp: section fixes re netns

2009-02-10T02:05:16+00:00

PPP is modular code so no initdata on netns hooks.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

net: replace uses of __constant_{endian}

2009-02-01T08:45:17+00:00

Base versions handle constant folding now.

Signed-off-by: Harvey Harrison 
Signed-off-by: David S. Miller

net: pppoe - stop using proc internals

2009-01-27T05:11:02+00:00

Alexey Dobriyan pointed that using PDE_NET outside the
proc code is plain bogus (thanks Alexey!). Fix it.

Signed-off-by: Cyrill Gorcunov 
Signed-off-by: David S. Miller

net: pppoe - get rid of DECLARE_MAC_BUF

2009-01-22T21:52:26+00:00

While was playing with PPP namespaces I occasionally brought
back DECLARE_MAC_BUF which is not needed (we have %pM here).
Fix it.

Signed-off-by: Cyrill Gorcunov 
Signed-off-by: David S. Miller

net: pppoe,pppol2tp - register channels with explicit net

2009-01-21T23:55:40+00:00

In PPPo[E|L2TP] we could explicitly point which net namespace
we're going to use for channels - make it so.

Signed-off-by: Cyrill Gorcunov 
Signed-off-by: James Chapman 
Signed-off-by: David S. Miller