linux.git/drivers/net/phy, branch v4.3-rc4

net: update docbook comment for __mdiobus_register()

2015-09-26T04:37:19+00:00

Update the docbook comment for __mdiobus_register() to include the new
module owner argument.  This resolves a warning found by the 0-day
builder.

Signed-off-by: Russell King 
Signed-off-by: David S. Miller

phy: marvell: add link partner advertised modes

2015-09-25T19:23:47+00:00

Read the standard link partner advertisment registers and store it in
phydev->lp_advertising, so ethtool can report this information to
userspace via ethtool.  Zero it as per genphy if autonegotiation is
disabled.  Tested with a Marvell 88E1512 PHY.

Signed-off-by: Russell King 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

phy: add phy_device_remove()

2015-09-25T06:04:53+00:00

Add a phy_device_remove() function to complement phy_device_register(),
which undoes the effects of phy_device_register() by removing the phy
device from visibility, but not freeing it.

This allows these details to be moved out of the mdio bus code into
the phy code where this action belongs.

Signed-off-by: Russell King 
Signed-off-by: David S. Miller

phy: fixed-phy: properly validate phy in fixed_phy_update_state()

2015-09-25T06:04:53+00:00

Validate that the phy_device passed into fixed_phy_update_state() is a
fixed-phy device before walking the list of phys for a fixed phy at the
same address.

Signed-off-by: Russell King 
Signed-off-by: David S. Miller

phy: add proper phy struct device refcounting

2015-09-25T06:04:52+00:00

Take a refcount on the phy struct device when the phy device is attached
to a network device, and drop it after it's detached.  This ensures that
a refcount is held on the phy device while the device is being used by
a network device, thereby preventing the phy_device from being
unexpectedly kfree()'d by phy_device_release().

Signed-off-by: Russell King 
Signed-off-by: David S. Miller

phy: fix mdiobus module safety

2015-09-25T06:04:52+00:00

Re-implement the mdiobus module refcounting to ensure that we actually
ensure that the mdiobus module code does not go away while we might call
into it.

The old scheme using bus->dev.driver was buggy, because bus->dev is a
class device which never has a struct device_driver associated with it,
and hence the associated code trying to obtain a refcount did nothing
useful.

Instead, take the approach that other subsystems do: pass the module
when calling mdiobus_register(), and record that in the mii_bus struct.
When we need to increment the module use count in the phy code, use
this stored pointer.  When the phy is deteched, drop the module
refcount, remembering that the phy device might go away at that point.

This doesn't stop the mii_bus going away while there are in-use phys -
it merely stops the underlying code vanishing.

Signed-off-by: Russell King 
Signed-off-by: David S. Miller

phy: fix of_mdio_find_bus() device refcount leak

2015-09-25T06:04:52+00:00

of_mdio_find_bus() leaks a struct device refcount, caused by using
class_find_device() and not realising that the device reference has
its refcount incremented:

 * Note, you will need to drop the reference with put_device() after use.
...
        while ((dev = class_dev_iter_next(&iter))) {
                if (match(dev, data)) {
                        get_device(dev);
                        break;
                }

Update the comment, and arrange for the phy code to drop this refcount
when disposing of a reference to it.

Signed-off-by: Russell King 
Signed-off-by: David S. Miller

net: phy: mdio-gpio: Fix module autoload for OF platform driver

2015-09-21T23:11:20+00:00

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt 
Signed-off-by: David S. Miller

net: phy: mdio-bcm-unimac: Fix module autoload for OF platform driver

2015-09-21T23:11:20+00:00

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

Revert "net/phy: Add Vitesse 8641 phy ID"

2015-09-21T05:29:34+00:00

This reverts commit 1298267b548a78840bd4b3e030993ff8747ca5e6.

That commit claim that the Vitesse VSC8641 is compatible with Vitesse
82xx. But this is not true. It seems that all the registers used
in Vitesse phy driver are not compatible between 8641 and 82xx.
It does cause malfunction of the Ethernet on p1010rdb-pa board.
So we definitely need a rework in order to support the 8641 phy
in this driver.

Signed-off-by: Kevin Hao 
Signed-off-by: David S. Miller