linux.git/drivers/net/phy, branch v4.3-rc2

add microchip LAN88xx phy driver

2015-09-10T00:19:14+00:00

Add Microchip LAN88XX phy driver for phylib.

Signed-off-by: Woojung Huh 
Signed-off-by: David S. Miller

fixed_phy: pass 'irq' to fixed_phy_add()

2015-09-07T06:49:33+00:00

I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
be  called with PHY_POLL  for 'irq'... :-)

Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")
Signed-off-by: Sergei Shtylyov 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

phylib: fix device deletion order in mdiobus_unregister()

2015-09-01T22:02:36+00:00

commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
the bus' parent.") uncovered a problem in mdiobus_unregister() which
leads to this warning when I reboot an APM Mustang (arm64) platform:

  WARNING: CPU: 7 PID: 4239 at fs/sysfs/group.c:224 sysfs_remove_group+0xa0/0xa4()
  sysfs group fffffe0000e07a10 not found for kobject 'xgene-mii-eth0:03'
  ...
  CPU: 7 PID: 4239 Comm: reboot Tainted: G            E   4.2.0-0.18.el7.test15.aarch64 #1
  Hardware name: AppliedMicro Mustang/Mustang, BIOS 1.1.0 Aug 26 2015
  Call Trace:
  [] dump_backtrace+0x0/0x170
  [] show_stack+0x20/0x2c
  [] dump_stack+0x78/0x9c
  [] warn_slowpath_common+0xa0/0xd8
  [] warn_slowpath_fmt+0x74/0x88
  [] sysfs_remove_group+0x9c/0xa4
  [] dpm_sysfs_remove+0x5c/0x70
  [] device_del+0x44/0x208
  [] device_unregister+0x2c/0x7c
  [] mdiobus_unregister+0x48/0x94
  [] xgene_enet_mdio_remove+0x28/0x44
  [] xgene_enet_remove+0xd0/0xd8
  [] xgene_enet_shutdown+0x2c/0x3c
  [] platform_drv_shutdown+0x24/0x40
  [] device_shutdown+0xf0/0x1b4
  [] kernel_restart_prepare+0x40/0x4c
  [] kernel_restart+0x1c/0x80
  [] SyS_reboot+0x17c/0x250

The problem is that mdiobus_unregister() deletes the bus device before
unregistering the phy devices on the bus. This wasn't a problem before
because the phys were not children of the bus:

  /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0:03
  /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0

But now that they are:

  /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0/xgene-mii-eth0:03

when mdiobus_unregister deletes the bus device, the phy subdirs are
removed from sysfs also. So when the phys are unregistered afterward,
we get the warning. This patch changes the order so that phys are
unregistered before the bus device is deleted.

Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.")
Signed-off-by: Mark Salter 
Reviewed-by: Florian Fainelli 
Tested-by: Mark Langsdorf 
Signed-off-by: David S. Miller

net: phy: fixed_phy: Set phy capabilities even when link down.

2015-08-31T21:48:03+00:00

What features a phy supports is masked in genphy_config_init() by
looking at the PHYs BMSR register.

If the link is down, fixed_phy_update_regs() will only set the auto-
negotiation capable bit in BMSR. Thus genphy_config_init() comes to
the conclusion the PHY can only perform 10/Half, and masks out the
higher speed features. If however the link it up, BMSR is set to
indicate the speed the PHY is capable of auto-negotiating, and
genphy_config_init() does not mask out the high speed features.

To fix this, when the link is down, have fixed_phy_update_regs() leave
the link status, auto-negotiation complete, and link partner
capabilities unset, but set all the local capabilities depending on
the fixed phy speed.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

phy: fixed_phy: Add gpio to determine link up/down.

2015-08-31T21:48:02+00:00

An SFP module may have a link up/down status pin which can be
connection to a GPIO line of the host. Add support for reading such an
GPIO in the fixed_phy driver.

Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

phy: fixed_phy: Set supported speed in phydev

2015-08-31T21:48:02+00:00

Set the supported field of the phydev to indicate the speed features
of the phy. If the phy is never attached to a netdev, but used in an
adjust_link() function, the speed will be incorrectly evaluated to
10/half rather than the correct speed/duplex.

Signed-off-by: Andrew Lunn 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: Allow PHY devices to identify themselves as Ethernet switches, etc.

2015-08-31T21:48:01+00:00

Some Ethernet MAC drivers using the PHY library require the hardcoding
of link parameters when interfaced to a switch device, SFP module,
switch to switch port, etc. This has typically lead to various ad-hoc
implementations looking like this:

- using a "fixed PHY" emulated device, which will provide link
  indication towards the Ethernet MAC driver and hardware

- pretend there is no PHY and hardcode link parameters, ala mv643x_eth

Based on that, it is desireable to have the PHY drivers advertise the
correct link parameters, just like regular Ethernet PHYs towards their
CPU Ethernet MAC drivers, however, Ethernet MAC drivers should be able
to tell whether this link should be monitored or not. In the context
of an Ethernet switch, SFP module, switch to switch link, we do not
need to monitor this link since it should be always up.

Signed-off-by: Florian Fainelli 
Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

phylib: simplify NULL checks

2015-08-28T21:15:25+00:00

Fix scripts/checkpatch.pl's messages like:

CHECK: Comparison to NULL could be written "!phydrv->read_mmd_indirect"

BTW, it doesn't detect the reversed comparisons (which I've fixed as well).

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

phylib: simplify bogus phy_device_create() result

2015-08-28T21:15:24+00:00

Get rid of the bogus string of type casts where ERR_PTR() is enough.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-08-28T04:45:31+00:00