linux.git/drivers/net/phy/phy_device.c, branch v3.14-rc2

phy: cleanup 10g code

2014-01-20T03:55:50+00:00

Code should avoid needless exports, don't export something unless it used.
Make local functions static and remove unused stubs.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

phylib: Support attaching to generic 10g driver

2014-01-13T22:29:49+00:00

phy_attach_direct() may now attach to a generic 10G driver. It can
also be used exactly as phy_connect_direct(), which will be useful
when using of_mdio, as phy_connect (and therefore of_phy_connect)
start the PHY state machine, which is currently irrelevant for 10G
PHYs.

Signed-off-by: Andy Fleming 
Signed-off-by: Shaohui Xie 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

phylib: Add generic 10G driver

2014-01-13T22:29:49+00:00

Very incomplete, but will allow for binding an ethernet controller
to it.

Signed-off-by: Andy Fleming 
Signed-off-by: Shaohui Xie 
Signed-off-by: David S. Miller

phylib: turn genphy_driver to an array

2014-01-13T22:29:49+00:00

Then other generic phy driver such as generic 10g phy driver can join it.

Signed-off-by: Shaohui Xie 
Signed-off-by: David S. Miller

phylib: make phy_scan_fixups() static

2014-01-05T00:27:58+00:00

phy_scan_fixups()  isn't and shouldn't be called by the drivers directly, so
unexport it. And since Florian Fainelli's recent patches, the function is only
called locally, so we can make it static as well.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

phylib: remove unused adjust_state() callback

2014-01-05T00:27:58+00:00

Remove adjust_state() callback from 'struct phy_device' since it seems to have
never been really used from the inception: phy_start_machine() has been always
called with 2nd argument equal to NULL.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

phy: kill excess empty lines

2014-01-05T00:27:58+00:00

Remove excess empty lines such as those between a function call and its result
check and just duplicate ones between functions.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

phy: kill excess code

2014-01-05T00:27:58+00:00

Remove some excess code:

- convert assignments to initializers;

- kill useless assignments before *return*.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

phy: kill useless local variables

2014-01-05T00:27:58+00:00

A number of functions (especially in phy.c) has local variables that were hardly
needed in the first place -- remove them.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

phy: coding style fixes

2014-01-05T00:27:57+00:00

The recent patch from Florian Fainelli fixed all 'checkpatch.pl' errors but left
the numerous warnings:

- including  instead of ;

- including  instead of ;

- *extern* declaration in .c file;

- block comments using empty /* line;

- block comments not starting with * on the middle lines;

- block comments not having trailing */ on a separate line;

- EXPORT_SYMBOL() not immediately following its function;

- unnecessary {} for signle statement block;

- spaces before tabs.

While fixing these, also fix the following style issues (some of which were
found running 'checkpatch.pl --strict'):

- alignment not matching open paren;

- missing {} on one of the *if* arms where another has them;

- use of sizeof(struct structure) instead of sizeof(*variable);

- multiple assignments on one line;

- empty line before };

- file names in the heading comments;

- missing spaces around operators;

- no {} around multi-line *if* operator's arm;

- unneeded () around subexpressions;

- incomplete kernel-doc comment style;

- comment line exceeding 80 characters;

- missing empty line after declarations.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller