linux.git/drivers/net/phy/phy-c45.c, branch v6.7

net: phy: c45: detect the BASE-T1 speed from the ability register

2023-07-20T10:24:06+00:00

Read the ability to do 100BASE-T1 and 1000BASE-T1 from the extended
BASE-T1 ability register of the PHY.

Signed-off-by: Stefan Eichenberger 
Reviewed-by: Andrew Lunn 
Signed-off-by: Paolo Abeni

net: phy: c45: add a separate function to read BASE-T1 abilities

2023-07-20T10:24:06+00:00

Add a separate function to read the BASE-T1 abilities. Some PHYs do not
indicate the availability of the extended BASE-T1 ability register, so
this function must be called separately.

Signed-off-by: Stefan Eichenberger 
Reviewed-by: Andrew Lunn 
Signed-off-by: Paolo Abeni

net: phy: c45: add support for 1000BASE-T1 forced setup

2023-07-20T10:24:06+00:00

Add support to force 1000BASE-T1 by setting the correct control bit in
the MDIO_MMD_PMA_PMD_BT1_CTRL register.

Signed-off-by: Stefan Eichenberger 
Reviewed-by: Andrew Lunn 
Signed-off-by: Paolo Abeni

net: phy-c45: Fix genphy_c45_ethtool_set_eee description

2023-06-21T03:35:26+00:00

The text has been cut/paste from genphy_c45_ethtool_get_eee but not
changed to reflect it performs set.

Additionally, extend the comment. This function implements the logic
that eee_enabled has global control over EEE. When eee_enabled is
false, no link modes will be advertised, and as a result, the MAC
should not transmit LPI.

Signed-off-by: Andrew Lunn 
Link: https://lore.kernel.org/r/20230619220332.4038924-1-andrew@lunn.ch
Signed-off-by: Jakub Kicinski

net: phy: c45: fix network interface initialization failures on xtensa, arm:cubieboard

2023-02-27T19:41:49+00:00

Without proper initialization, "changed" returned random numbers and caused
interface initialization failures.

Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Reported-by: Guenter Roeck 
Tested-by: Guenter Roeck 
Signed-off-by: Oleksij Rempel 
Reviewed-by: Simon Horman 
Link: https://lore.kernel.org/r/20230225071644.2754893-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski

net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes

2023-02-23T12:43:23+00:00

Currently, it is possible to let some PHYs to advertise not supported
EEE link modes. So, validate them before overwriting existing
configuration.

Signed-off-by: Oleksij Rempel 
Reviewed-by: Russell King (Oracle) 
Signed-off-by: Paolo Abeni

net: phy: do not force EEE support

2023-02-23T12:43:23+00:00

With following patches:
commit 9b01c885be36 ("net: phy: c22: migrate to genphy_c45_write_eee_adv()")
commit 5827b168125d ("net: phy: c45: migrate to genphy_c45_write_eee_adv()")

we set the advertisement to potentially supported values. This behavior
may introduce new regressions on systems where EEE was disabled by
default (BIOS or boot loader configuration or by other ways.)

At same time, with this patches, we would overwrite EEE advertisement
configuration made over ethtool.

To avoid this issues, we need to cache initial and ethtool advertisement
configuration and store it for later use.

Fixes: 9b01c885be36 ("net: phy: c22: migrate to genphy_c45_write_eee_adv()")
Fixes: 5827b168125d ("net: phy: c45: migrate to genphy_c45_write_eee_adv()")
Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: Oleksij Rempel 
Reviewed-by: Russell King (Oracle) 
Signed-off-by: Paolo Abeni

net: phy: c45: add genphy_c45_an_config_eee_aneg() function

2023-02-23T12:43:23+00:00

Add new genphy_c45_an_config_eee_aneg() function and replace some of
genphy_c45_write_eee_adv() calls. This will be needed by the next patch.

Signed-off-by: Oleksij Rempel 
Reviewed-by: Russell King (Oracle) 
Signed-off-by: Paolo Abeni

net: phy: c45: use "supported_eee" instead of supported for access validation

2023-02-23T12:43:23+00:00

Make sure we use proper variable to validate access to potentially not
supported registers. Otherwise we will get false read/write errors.

Reported-by: kernel test robot 
Link: https://lore.kernel.org/oe-lkp/202302211644.c12d19de-yujie.liu@intel.com
Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: Oleksij Rempel 
Reviewed-by: Russell King (Oracle) 
Signed-off-by: Paolo Abeni

net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error

2023-02-16T05:24:37+00:00

Fix warning:
drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'

Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/202302150232.q6idsV8s-lkp@intel.com/
Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: Oleksij Rempel 
Reviewed-by: Andrew Lunn 
Link: https://lore.kernel.org/r/20230215050453.2251360-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski