<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/net/pcnet32.c, branch v2.6.25</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>pcnet32: Use print_mac</title>
<updated>2008-02-11T15:28:31+00:00</updated>
<author>
<name>Don Fry</name>
<email>pcnet32@verizon.net</email>
</author>
<published>2008-02-08T15:29:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=b3028cdc1859adf371f9457862e466f0e67f0b10'/>
<id>b3028cdc1859adf371f9457862e466f0e67f0b10</id>
<content type='text'>
Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pcnet32: use NET_IP_ALIGN instead of 2</title>
<updated>2008-02-11T15:28:30+00:00</updated>
<author>
<name>Don Fry</name>
<email>pcnet32@verizon.net</email>
</author>
<published>2008-02-08T15:32:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=232c56408861e666d2546960d1180eb2c65260bd'/>
<id>232c56408861e666d2546960d1180eb2c65260bd</id>
<content type='text'>
Change hard coded 2 to NET_IP_ALIGN.  Added new #define with comments.
Tested amd_64

Signed-off-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change hard coded 2 to NET_IP_ALIGN.  Added new #define with comments.
Tested amd_64

Signed-off-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>netdev: use ARRAY_SIZE() instead of sizeof(array) / ETH_GSTRING_LEN</title>
<updated>2008-01-28T23:03:36+00:00</updated>
<author>
<name>Alejandro Martinez Ruiz</name>
<email>alex@flawedcode.org</email>
</author>
<published>2007-10-18T08:00:15+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=4c3616cdda0632a3d0e39069765f9ea0e6bd093e'/>
<id>4c3616cdda0632a3d0e39069765f9ea0e6bd093e</id>
<content type='text'>
Using ARRAY_SIZE() on arrays of the form array[][K] makes it unnecessary
to know the value of K when checking its size.

Signed-off-by: Alejandro Martinez Ruiz &lt;alex@flawedcode.org&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using ARRAY_SIZE() on arrays of the form array[][K] makes it unnecessary
to know the value of K when checking its size.

Signed-off-by: Alejandro Martinez Ruiz &lt;alex@flawedcode.org&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[NET]: Fix drivers to handle napi_disable() disabling interrupts.</title>
<updated>2008-01-09T07:30:12+00:00</updated>
<author>
<name>David S. Miller</name>
<email>davem@davemloft.net</email>
</author>
<published>2008-01-08T04:53:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=d1d08d1265810ef1f165864850416dcbc9725ee7'/>
<id>d1d08d1265810ef1f165864850416dcbc9725ee7</id>
<content type='text'>
When we add the generic napi_disable_pending() breakout
logic to net_rx_action() it means that napi_disable()
can cause NAPI poll interrupt events to be disabled.

And this is exactly what we want.  If a napi_disable()
is pending, and we are looping in the -&gt;poll(), we want
-&gt;poll() event interrupts to stay disabled and we want
to complete the NAPI poll ASAP.

When -&gt;poll() break out during device down was being handled on a
per-driver basis, often these drivers would turn interrupts back on
when '!netif_running()' was detected.

And this would just cause a reschedule of the NAPI -&gt;poll() in the
interrupt handler before the napi_disable() could get in there and
grab the NAPI_STATE_SCHED bit.

The vast majority of drivers don't care if napi_disable() might have
the side effect of disabling NAPI -&gt;poll() event interrupts.  In all
such cases, when a napi_disable() is performed, the driver just
disabled interrupts or is about to.

However there were three exceptions to this in PCNET32, R8169, and
SKY2.  To fix those cases, at the subsequent napi_enable() points, I
added code to ensure that the -&gt;poll() interrupt events are enabled in
the hardware.

Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
Acked-by:  Don Fry &lt;pcnet32@verizon.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When we add the generic napi_disable_pending() breakout
logic to net_rx_action() it means that napi_disable()
can cause NAPI poll interrupt events to be disabled.

And this is exactly what we want.  If a napi_disable()
is pending, and we are looping in the -&gt;poll(), we want
-&gt;poll() event interrupts to stay disabled and we want
to complete the NAPI poll ASAP.

When -&gt;poll() break out during device down was being handled on a
per-driver basis, often these drivers would turn interrupts back on
when '!netif_running()' was detected.

And this would just cause a reschedule of the NAPI -&gt;poll() in the
interrupt handler before the napi_disable() could get in there and
grab the NAPI_STATE_SCHED bit.

The vast majority of drivers don't care if napi_disable() might have
the side effect of disabling NAPI -&gt;poll() event interrupts.  In all
such cases, when a napi_disable() is performed, the driver just
disabled interrupts or is about to.

However there were three exceptions to this in PCNET32, R8169, and
SKY2.  To fix those cases, at the subsequent napi_enable() points, I
added code to ensure that the -&gt;poll() interrupt events are enabled in
the hardware.

Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
Acked-by:  Don Fry &lt;pcnet32@verizon.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pcnet32: remove private net_device_stats structure</title>
<updated>2007-10-18T00:23:30+00:00</updated>
<author>
<name>Don Fry</name>
<email>pcnet32@verizon.net</email>
</author>
<published>2007-10-18T00:06:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=4f1e5ba0977570b7a198bb3ac110ccc5f532821b'/>
<id>4f1e5ba0977570b7a198bb3ac110ccc5f532821b</id>
<content type='text'>
Remove the statistics from the private structure.
Use the net_device_stats in netn_device structure.

Following Jeff Garzik's massive cleanup Sep 01.
pcnet32 was not "low-hanging fruit".

Tested x86_64.

Signed-off-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove the statistics from the private structure.
Use the net_device_stats in netn_device structure.

Following Jeff Garzik's massive cleanup Sep 01.
pcnet32 was not "low-hanging fruit".

Tested x86_64.

Signed-off-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pcnet32: remove compile warnings in non-napi mode</title>
<updated>2007-10-18T00:17:34+00:00</updated>
<author>
<name>Don Fry</name>
<email>pcnet32@verizon.net</email>
</author>
<published>2007-10-17T23:10:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=6ad6c75626cf8b69cd28ae0a81227503a7c3966e'/>
<id>6ad6c75626cf8b69cd28ae0a81227503a7c3966e</id>
<content type='text'>
Remove compile warning when in non-napi mode.

Signed-off-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove compile warning when in non-napi mode.

Signed-off-by:  Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pcnet32: fix non-napi packet reception</title>
<updated>2007-10-18T00:17:34+00:00</updated>
<author>
<name>Don Fry</name>
<email>pcnet32@verizon.net</email>
</author>
<published>2007-10-17T22:59:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=feff348fc0fe06870a8ec05e78af8ed5cc4c2bdf'/>
<id>feff348fc0fe06870a8ec05e78af8ed5cc4c2bdf</id>
<content type='text'>
Recent changes to the driver for the new napi API broke the reception
of packets when in non-napi mode.  The initialization of napi.weight
was removed for the non-napi case leaving the value zero.

Tested NAPI and non-NAPI on x86_64.

Signed-off-by: Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Recent changes to the driver for the new napi API broke the reception
of packets when in non-napi mode.  The initialization of napi.weight
was removed for the non-napi case leaving the value zero.

Tested NAPI and non-NAPI on x86_64.

Signed-off-by: Don Fry &lt;pcnet32@verizon.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pcnet32: endianness</title>
<updated>2007-10-10T23:52:01+00:00</updated>
<author>
<name>Al Viro</name>
<email>viro@zeniv.linux.org.uk</email>
</author>
<published>2007-08-23T04:45:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=3e33545ba6f8ca04b28a015e095662a35a4e2670'/>
<id>3e33545ba6f8ca04b28a015e095662a35a4e2670</id>
<content type='text'>
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[netdrvr] Stop using legacy hooks -&gt;self_test_count, -&gt;get_stats_count</title>
<updated>2007-10-10T23:51:45+00:00</updated>
<author>
<name>Jeff Garzik</name>
<email>jeff@garzik.org</email>
</author>
<published>2007-10-04T01:07:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=b9f2c0440d806e01968c3ed4def930a43be248ad'/>
<id>b9f2c0440d806e01968c3ed4def930a43be248ad</id>
<content type='text'>
These have been superceded by the new -&gt;get_sset_count() hook.

Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These have been superceded by the new -&gt;get_sset_count() hook.

Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls</title>
<updated>2007-10-10T23:51:17+00:00</updated>
<author>
<name>Jeff Garzik</name>
<email>jeff@garzik.org</email>
</author>
<published>2007-09-15T21:41:06+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e'/>
<id>88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e</id>
<content type='text'>
For the operations
	get-tx-csum
	get-sg
	get-tso
	get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.

This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.

The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.

[ Resolved conflicts with set/get value ethtool patch... -DaveM ]

Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For the operations
	get-tx-csum
	get-sg
	get-tso
	get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.

This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.

The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.

[ Resolved conflicts with set/get value ethtool patch... -DaveM ]

Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
</feed>
