linux.git/drivers/net/pasemi_mac.c, branch v2.6.24

pasemi_mac: Fix reuse of free'd skb

2007-12-04T19:53:49+00:00

Turns out we're freeing the skb when we detect CRC error, but we're
not clearing out info->skb. We could either clear it and have the stack
reallocate it, or just leave it and the rx ring refill code will reuse
the one that was allocated.

Reusing a freed skb obviously caused some nasty crashes of various kind,
as reported by Brent Baude and David Woodhouse.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

Don't claim to do IPv6 checksum offload

2007-12-04T19:53:07+00:00

Signed-off-by: David Woodhouse 
Signed-off-by: Jeff Garzik

pasemi_mac: Fix CRC checks

2007-11-10T09:25:14+00:00

Make sure we don't feed packets with bad CRC up the network stack,
and discount the packet length as reported from the MAC for the CRC
field.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: Don't set replace-source-address descriptor bits

2007-11-10T09:25:14+00:00

Don't use the "replace source address with local MAC address" bits, since
it causes problems on some variations of the hardware due to an erratum.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: fix typo

2007-10-24T00:18:13+00:00

Add missing &:

drivers/net/pasemi_mac.c: In function 'pasemi_mac_clean_rx':
drivers/net/pasemi_mac.c:553: warning: passing argument 1 of 'prefetch'
makes pointer from integer without a cast

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: enable iommu support

2007-10-10T23:54:30+00:00

pasemi_mac: enable iommu support

Enable IOMMU support for pasemi_mac, but avoid using it on non-partitioned
systems for performance reasons.

The user can override this by selecting the PPC_PASEMI_IOMMU_DMA_FORCE
configuration option.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: use buffer index pointer in clean_rx()

2007-10-10T23:54:27+00:00

pasemi_mac: use buffer index pointer in clean_rx()

Use the new features in B0 for buffer ring index on the receive side. This
means we no longer have to search in the ring for where the buffer
came from.

Also cleanup the RX cleaning side a little, while I was at it.

Note: Pre-B0 hardware is no longer supported, and needs a pile of other
workarounds that are not being submitted for mainline inclusion. So the
fact that this breaks old hardware is not a problem at this time.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: clear out old errors on interface open

2007-10-10T23:54:27+00:00

pasemi_mac: clear out old errors on interface open

Clear out any pending errors when an interface is brought up. Since the bits
are sticky, they might be from interface shutdown time after firmware has
used it, etc.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: update todo list

2007-10-10T23:54:26+00:00

pasemi_mac: update todo list

Remove some stale todo items that have been taken care of. Add a couple
of upcoming ones.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik

pasemi_mac: further performance tweaks

2007-10-10T23:54:25+00:00

pasemi_mac: further performance tweaks

Misc driver tweaks for pasemi_mac:
	* Increase ring size (really needed mostly on 10G)
	* Take out an unneeded barrier
	* Move around a few prefetches and reorder a few calls
	* Don't try to clean on full tx buffer, just let things
	  take their course and stop the queue directly
	* Avoid filling on the same line as the interface is
	  working on to reduce cache line bouncing
	* Avoid unneeded clearing of software state (and make the
	  interface shutdown code handle it)
	* Fix up some of the tx ring wrap logic.

Signed-off-by: Olof Johansson 
Signed-off-by: Jeff Garzik