linux.git/drivers/net/mdio, branch v5.17

net: mdio: mscc-miim: fix duplicate debugfs entry

2022-03-15T05:04:15+00:00

This driver can have up to two regmaps. If the second one is registered
its debugfs entry will have the same name as the first one and the
following error will be printed:

[    3.833521] debugfs: Directory 'e200413c.mdio' with parent 'regmap' already present!

Give the second regmap a name to avoid this.

Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Michael Walle 
Reviewed-by: Andrew Lunn 
Link: https://lore.kernel.org/r/20220312224140.4173930-1-michael@walle.cc
Signed-off-by: Jakub Kicinski

net: mdio-ipq4019: add delay after clock enable

2022-02-21T13:04:53+00:00

Experimentation shows that PHY detect might fail when the code attempts
MDIO bus read immediately after clock enable. Add delay to stabilize the
clock before bus access.

PHY detect failure started to show after commit 7590fc6f80ac ("net:
mdio: Demote probed message to debug print") that removed coincidental
delay between clock enable and bus access.

10ms is meant to match the time it take to send the probed message over
UART at 115200 bps. This might be a far overshoot.

Fixes: 23a890d493e3 ("net: mdio: Add the reset function for IPQ MDIO driver")
Signed-off-by: Baruch Siach 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: mdio: aspeed: Add missing MODULE_DEVICE_TABLE

2022-02-09T12:15:21+00:00

Fix loading of the driver when built as a module.

Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Signed-off-by: Joel Stanley 
Reviewed-by: Andrew Lunn 
Acked-by: Andrew Jeffery 
Signed-off-by: David S. Miller

net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

2021-12-02T02:46:54+00:00

There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!

Add the depend of REGMAP_MMIO to fix it.

Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Tianchen Ding 
Reviewed-by: Andrew Lunn 
Link: https://lore.kernel.org/r/20211130110209.804536-1-dtcccc@linux.alibaba.com
Signed-off-by: Jakub Kicinski

net: mdio: mscc-miim: Set back the optional resource.

2021-11-30T12:22:04+00:00

In the blamed commit, the second memory resource was not considered
anymore as optional. On some platforms like sparx5 the second resource
is optional. So add it back as optional and restore the comment that
says so.

Fixes: a27a762828375a ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Horatiu Vultur 
Signed-off-by: David S. Miller

net: dsa: ocelot: felix: utilize shared mscc-miim driver for indirect MDIO access

2021-11-29T13:02:00+00:00

Switch to a shared MDIO access implementation by way of the mdio-mscc-miim
driver.

Signed-off-by: Colin Foster 
Tested-by: Vladimir Oltean 
Signed-off-by: David S. Miller

net: mdio: mscc-miim: convert to a regmap implementation

2021-11-29T13:02:00+00:00

Utilize regmap instead of __iomem to perform indirect mdio access. This
will allow for custom regmaps to be used by way of the mscc_miim_setup
function.

Signed-off-by: Colin Foster 
Tested-by: Vladimir Oltean 
Signed-off-by: David S. Miller

net: mdio: ipq8064: replace ioremap() with devm_ioremap()

2021-11-29T12:02:49+00:00

Use devm_ioremap() instead of ioremap() to avoid iounmap() missing.

Signed-off-by: Yang Yingliang 
Signed-off-by: David S. Miller

mdio: aspeed: Fix "Link is Down" issue

2021-11-25T15:44:42+00:00

The issue happened randomly in runtime.  The message "Link is Down" is
popped but soon it recovered to "Link is Up".

The "Link is Down" results from the incorrect read data for reading the
PHY register via MDIO bus.  The correct sequence for reading the data
shall be:
1. fire the command
2. wait for command done (this step was missing)
3. wait for data idle
4. read data from data register

Cc: stable@vger.kernel.org
Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Reviewed-by: Joel Stanley 
Signed-off-by: Dylan Hung 
Reviewed-by: Andrew Lunn 
Reviewed-by: Russell King (Oracle) 
Link: https://lore.kernel.org/r/20211125024432.15809-1-dylan_hung@aspeedtech.com
Signed-off-by: Jakub Kicinski

net: mdio-ipq4019: Fix the error for an optional regs resource

2021-09-29T00:28:54+00:00

The second resource is optional which is only provided on the chipset
IPQ5018. But the blamed commit ignores that and if the resource is
not there it just fails.

the resource is used like this,
	if (priv->eth_ldo_rdy) {
		val = readl(priv->eth_ldo_rdy);
		val |= BIT(0);
		writel(val, priv->eth_ldo_rdy);
		fsleep(IPQ_PHY_SET_DELAY_US);
	}

This patch reverts that to still allow the second resource to be optional
because other SoC have the some MDIO controller and doesn't need to
second resource.

Fixes: fa14d03e014a ("net: mdio-ipq4019: Make use of devm_platform_ioremap_resource()")
Signed-off-by: Cai Huoqing 
Reviewed-by: Andrew Lunn 
Link: https://lore.kernel.org/r/20210928134849.2092-1-caihuoqing@baidu.com
Signed-off-by: Jakub Kicinski