linux.git/drivers/net/macvlan.c, branch v4.16-rc2

macvlan: Fix one possible double free

2018-01-02T18:30:14+00:00

Because the macvlan_uninit would free the macvlan port, so there is one
double free case in macvlan_common_newlink. When the macvlan port is just
created, then register_netdevice or netdev_upper_dev_link failed and they
would invoke macvlan_uninit. Then it would reach the macvlan_port_destroy
which triggers the double free.

Signed-off-by: Gao Feng 
Signed-off-by: David S. Miller

macvlan/macvtap: Add support for L2 forwarding offloads with macvtap

2017-10-19T11:43:59+00:00

This patch reverts earlier commit b13ba1b83f52 ("macvlan: forbid L2
fowarding offload for macvtap"). The reason for reverting this is because
the original patch no longer fixes what it previously did as the
underlying structure has changed for macvtap. Specifically macvtap
originally pulled packets directly off of the lowerdev. However in commit
6acf54f1cf0a ("macvtap: Add support of packet capture on macvtap device.")
that code was changed and instead macvtap would listen directly on the
macvtap device itself instead of the lower device. As such, the L2
forwarding offload should now be able to provide a performance advantage of
skipping the checks on the lower dev while not introducing any sort of
regression.

Signed-off-by: Alexander Duyck 
Signed-off-by: David S. Miller

macvlan: Only update pkt_type if destination MAC address matches

2017-10-15T01:46:36+00:00

This patch updates the pkt_type to PACKET_HOST only if the destination MAC
address matches on the on the source based macvlan. It didn't make sense to
be updating broadcast, multicast, and non-local destined frames with
PACKET_HOST.

Signed-off-by: Alexander Duyck 
Signed-off-by: David S. Miller

macvlan: Only deliver one copy of the frame to the macvlan interface

2017-10-15T01:46:36+00:00

This patch intoduces a slight adjustment for macvlan to address the fact
that in source mode I was seeing two copies of any packet addressed to the
macvlan interface being delivered where there should have been only one.

The issue appears to be that one copy was delivered based on the source MAC
address and then the second copy was being delivered based on the
destination MAC address. To fix it I am just treating a unicast address
match as though it is not a match since source based macvlan isn't supposed
to be matching based on the destination MAC anyway.

Fixes: 79cf79abce71 ("macvlan: add source mode")
Signed-off-by: Alexander Duyck 
Signed-off-by: David S. Miller

net: Add extack to upper device linking

2017-10-05T04:39:33+00:00

Add extack arg to netdev_upper_dev_link and netdev_master_upper_dev_link

Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

macvlan: code refine to check data before using

2017-09-20T20:46:45+00:00

This patch checks data first at one place, return if it's null.

Signed-off-by: Zhang Shengju 
Signed-off-by: David S. Miller

macvlan: add offload features for encapsulation

2017-08-18T23:06:54+00:00

Currently macvlan devices do not set their hw_enc_features making
encapsulated Tx packets resort to SW fallbacks. Add encapsulation GSO
offloads to ->features as is done for the other GSOs and set
->hw_enc_features.

Signed-off-by: Dimitris Michailidis 
Signed-off-by: David S. Miller

macvlan/macvtap: Remove NETIF_F_UFO advertisement.

2017-07-17T16:52:57+00:00

It is going away.

Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-06-30T16:43:08+00:00

A set of overlapping changes in macvlan and the rocker
driver, nothing serious.

Signed-off-by: David S. Miller

net: add netlink_ext_ack argument to rtnl_link_ops.validate

2017-06-27T03:13:22+00:00

Add support for extended error reporting.

Signed-off-by: Matthias Schiffer 
Acked-by: David Ahern 
Signed-off-by: David S. Miller