linux.git/drivers/net/macb.c, branch v2.6.39

macb: don't use platform_set_drvdata() on a net_device

2011-02-28T20:22:20+00:00

Commit 71d6429 (Driver core: convert platform_{get,set}_drvdata to
static inline functions) now triggers a warning in the macb network
driver:

  CC      drivers/net/macb.o
drivers/net/macb.c: In function ‘macb_mii_init’:
drivers/net/macb.c:263: warning: passing argument 1 of ‘platform_set_drvdata’ from incompatible pointer type
include/linux/platform_device.h:138: note: expected ‘struct platform_device *’ but argument is of type ‘struct net_device *’

Use dev_set_drvdata() on the device embedded in the net_device instead.

Cc: Nicolas Ferre 
Signed-off-by: Jamie Iles 
Signed-off-by: David S. Miller

macb: Don't re-enable interrupts while in polling mode

2010-10-25T19:14:11+00:00

On a busy network, the macb driver could get stuck in the interrupt
handler, quickly triggering the watchdog, due to a confluence of
factors:

 1. macb_poll re-enables interrupts unconditionally, even when it will
    be called again because it exhausted its rx budget

 2. macb_interrupt only disables interrupts after scheduling
    macb_poll, but scheduling fails when macb_poll is already scheduled
    because it didn't call napi_complete

 3. macb_interrupt loops until the interrupt status register is clear,
    which will never happen in this case if the driver doesn't disable
    the RX interrupt

Since macb_interrupt runs in interrupt context, this effectively locks
up the machine, triggering the hardware watchdog.

This issue was readily reproducible on a flooded network with a
modified 2.6.27.48 kernel. The same problem appears to still be in the
2.6.36-rc8 driver code, so I am submitting this patch against that
version. I have not tested this version of the patch except to make
sure the kernel compiles.

Signed-off-by: Joshua Hoke 
Signed-off-by: David S. Miller

drivers/net: avoid some skb->ip_summed initializations

2010-09-03T02:06:22+00:00

fresh skbs have ip_summed set to CHECKSUM_NONE (0)

We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.

Introduce skb_checksum_none_assert() helper so that we keep this
assertion documented in driver sources.

Change most occurrences of :

skb->ip_summed = CHECKSUM_NONE;

by :

skb_checksum_none_assert(skb);

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: preserve ifreq parameter when calling generic phy_mii_ioctl().

2010-07-19T02:15:25+00:00

The phy_mii_ioctl() function unnecessarily throws away the original ifreq.
We need access to the ifreq in order to support PHYs that can perform
hardware time stamping.

Two maverick drivers filter the ioctl commands passed to phy_mii_ioctl().
This is unnecessary since phylib will check the command in any case.

Signed-off-by: Richard Cochran 
Signed-off-by: David S. Miller

net: trans_start cleanups

2010-05-10T12:01:31+00:00

Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.

Exceptions are NETIF_F_LLTX drivers

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

macb: allow reception of large (>1518 bytes) frames

2010-04-08T04:53:41+00:00

Enable BIG bit in the network configuration register, so the MAC
doesn't reject big frames (E.G. when vlans are used).

Signed-off-by: Peter Korsgaard 
Signed-off-by: David S. Miller

net: convert multicast list to list_head

2010-04-03T21:22:15+00:00

Converts the list and the core manipulating with it to be the same as uc_list.

+uses two functions for adding/removing mc address (normal and "global"
 variant) instead of a function parameter.
+removes dev_mcast.c completely.
+exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
 manipulation with lists on a sandbox (used in bonding and 80211 drivers)

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: convert multiple drivers to use netdev_for_each_mc_addr, part5 V2

2010-02-26T10:07:30+00:00

removed some needless checks and also corrected bug in lp486e (dmi was passed
instead of dmi->dmi_addr)

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

macb: straighten out macb_mii_probe function

2010-02-12T19:38:58+00:00

Use "phy_find_first" instead of manual lookup. Also use "phy_connect_direct"
instead of "phy_connect" since we already have phy_device pointer here.

Signed-off-by: Jiri Pirko 
Acked-by: Haavard Skinnemoen 
Signed-off-by: David S. Miller

net: use netdev_mc_count and netdev_mc_empty when appropriate

2010-02-12T19:38:58+00:00

This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
anything). Used spatch and did small tweaks and conding style changes when
it was suitable.

Jirka

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller