<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/net/lib8390.c, branch master</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>8390: Move the 8390 related drivers</title>
<updated>2011-08-11T02:54:25+00:00</updated>
<author>
<name>Jeff Kirsher</name>
<email>jeffrey.t.kirsher@intel.com</email>
</author>
<published>2011-04-02T13:20:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=644570b830266ff33ff5f3542b9c838f93a55ea6'/>
<id>644570b830266ff33ff5f3542b9c838f93a55ea6</id>
<content type='text'>
Moves the drivers for the National Semi-conductor 8390 chipset into
drivers/net/ethernet/8390/ and the necessary Kconfig and Makefile
changes.

CC: Donald Becker &lt;becker@scyld.com&gt;
CC: Paul Gortmaker &lt;paul.gortmaker@windriver.com&gt;
CC: Alain Malek &lt;alain.malek@cryogen.com&gt;
CC: Peter De Schrijver &lt;p2@mind.be&gt;
CC: "David Huggins-Daines" &lt;dhd@debian.org&gt;
CC: Wim Dumon &lt;wimpie@kotnet.org&gt;
CC: Yoshinori Sato &lt;ysato@users.sourceforge.jp&gt;
CC: David Hinds &lt;dahinds@users.sourceforge.net&gt;
CC: Russell King &lt;linux@arm.linux.org.uk&gt;
Signed-off-by: Jeff Kirsher &lt;jeffrey.t.kirsher@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Moves the drivers for the National Semi-conductor 8390 chipset into
drivers/net/ethernet/8390/ and the necessary Kconfig and Makefile
changes.

CC: Donald Becker &lt;becker@scyld.com&gt;
CC: Paul Gortmaker &lt;paul.gortmaker@windriver.com&gt;
CC: Alain Malek &lt;alain.malek@cryogen.com&gt;
CC: Peter De Schrijver &lt;p2@mind.be&gt;
CC: "David Huggins-Daines" &lt;dhd@debian.org&gt;
CC: Wim Dumon &lt;wimpie@kotnet.org&gt;
CC: Yoshinori Sato &lt;ysato@users.sourceforge.jp&gt;
CC: David Hinds &lt;dahinds@users.sourceforge.net&gt;
CC: Russell King &lt;linux@arm.linux.org.uk&gt;
Signed-off-by: Jeff Kirsher &lt;jeffrey.t.kirsher@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib8390: Remove unnecessary extern</title>
<updated>2011-06-25T00:31:37+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2011-06-22T20:38:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=3c01164e80a11fe2743cc36a0f2915673f1cac74'/>
<id>3c01164e80a11fe2743cc36a0f2915673f1cac74</id>
<content type='text'>
Already declared in 8390.h

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Already declared in 8390.h

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib8390: Convert include &lt;asm to include &lt;linux</title>
<updated>2011-06-25T00:31:36+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2011-06-22T20:38:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=5aedcf50e547e37b89d105efc4a2f0f1b0217af4'/>
<id>5aedcf50e547e37b89d105efc4a2f0f1b0217af4</id>
<content type='text'>
Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib8390: Normalize source code spacing</title>
<updated>2011-06-25T00:31:36+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2011-06-22T20:38:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=be763c940fc3ccdaeda238e3ef5840961b649740'/>
<id>be763c940fc3ccdaeda238e3ef5840961b649740</id>
<content type='text'>
Make more conformant to normal kernel style.

Long line lengths &gt; 80 columns ignored.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make more conformant to normal kernel style.

Long line lengths &gt; 80 columns ignored.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib8390: Indent braces appropriately</title>
<updated>2011-06-25T00:31:36+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2011-06-22T20:38:56+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=7340c4db810f3b129fc4dd648991ed5ca5346592'/>
<id>7340c4db810f3b129fc4dd648991ed5ca5346592</id>
<content type='text'>
Move the braces around to conform to kernel standard style.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move the braces around to conform to kernel standard style.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib8390: Use pr_&lt;level&gt; and netdev_&lt;level&gt;</title>
<updated>2011-06-25T00:31:36+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2011-06-22T20:38:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=840f63933983a1d873c5b2f85d2e169bb94e3c19'/>
<id>840f63933983a1d873c5b2f85d2e169bb94e3c19</id>
<content type='text'>
Use the current logging styles.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use the current logging styles.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: Geert Uytterhoeven &lt;geert@linux-m68k.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib8390: enable transmit and receive time stamping.</title>
<updated>2011-06-20T20:56:53+00:00</updated>
<author>
<name>Richard Cochran</name>
<email>richardcochran@gmail.com</email>
</author>
<published>2011-06-19T21:51:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=d76b7e2faaabae4805ae7ebf31ad64a33268f44f'/>
<id>d76b7e2faaabae4805ae7ebf31ad64a33268f44f</id>
<content type='text'>
This patch enables software (and phy device) time stamping. This file is
included by drivers/net/ax88796.c, which is based on phylib. So, this
patch makes hardware time stamping in the PHY possible.

Compile tested only.

Signed-off-by: Richard Cochran &lt;richard.cochran@omicron.at&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch enables software (and phy device) time stamping. This file is
included by drivers/net/ax88796.c, which is based on phylib. So, this
patch makes hardware time stamping in the PHY possible.

Compile tested only.

Signed-off-by: Richard Cochran &lt;richard.cochran@omicron.at&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix common misspellings</title>
<updated>2011-03-31T14:26:23+00:00</updated>
<author>
<name>Lucas De Marchi</name>
<email>lucas.demarchi@profusion.mobi</email>
</author>
<published>2011-03-31T01:57:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=25985edcedea6396277003854657b5f3cb31a628'/>
<id>25985edcedea6396277003854657b5f3cb31a628</id>
<content type='text'>
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi &lt;lucas.demarchi@profusion.mobi&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi &lt;lucas.demarchi@profusion.mobi&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>drivers/net: Remove unnecessary casts of netdev_priv</title>
<updated>2010-11-17T18:37:52+00:00</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2010-11-15T11:12:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=ece49153b601d95bcebd45a6394e370972f0b0a0'/>
<id>ece49153b601d95bcebd45a6394e370972f0b0a0</id>
<content type='text'>
Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>8390: Don't oops on starting dev queue</title>
<updated>2010-10-28T17:27:01+00:00</updated>
<author>
<name>Pavel Emelyanov</name>
<email>xemul@parallels.com</email>
</author>
<published>2010-10-27T23:01:02+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=b7126d8c70a1d4656f1c351de8528df22dfd2d46'/>
<id>b7126d8c70a1d4656f1c351de8528df22dfd2d46</id>
<content type='text'>
The __NS8390_init tries to start the device queue before the
device is registered. This results in an oops (snipped):

[    2.865493] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
[    2.866106] IP: [&lt;ffffffffa000602a&gt;] netif_start_queue+0xb/0x12 [8390]
[    2.881267] Call Trace:
[    2.881437]  [&lt;ffffffffa000624d&gt;] __NS8390_init+0x102/0x15a [8390]
[    2.881999]  [&lt;ffffffffa00062ae&gt;] NS8390_init+0x9/0xb [8390]
[    2.882237]  [&lt;ffffffffa000d820&gt;] ne2k_pci_init_one+0x297/0x354 [ne2k_pci]
[    2.882955]  [&lt;ffffffff811c7a0e&gt;] local_pci_probe+0x12/0x16
[    2.883308]  [&lt;ffffffff811c85ad&gt;] pci_device_probe+0xc3/0xef
[    2.884049]  [&lt;ffffffff8129218d&gt;] driver_probe_device+0xbe/0x14b
[    2.884937]  [&lt;ffffffff81292260&gt;] __driver_attach+0x46/0x62
[    2.885170]  [&lt;ffffffff81291788&gt;] bus_for_each_dev+0x49/0x78
[    2.885781]  [&lt;ffffffff81291fbb&gt;] driver_attach+0x1c/0x1e
[    2.886089]  [&lt;ffffffff812912ab&gt;] bus_add_driver+0xba/0x227
[    2.886330]  [&lt;ffffffff8129259a&gt;] driver_register+0x9e/0x115
[    2.886933]  [&lt;ffffffff811c8815&gt;] __pci_register_driver+0x50/0xac
[    2.887785]  [&lt;ffffffffa001102c&gt;] ne2k_pci_init+0x2c/0x2e [ne2k_pci]
[    2.888093]  [&lt;ffffffff81000212&gt;] do_one_initcall+0x7c/0x130
[    2.888693]  [&lt;ffffffff8106d74f&gt;] sys_init_module+0x99/0x1da
[    2.888946]  [&lt;ffffffff81002a2b&gt;] system_call_fastpath+0x16/0x1b

This happens because the netif_start_queue sets respective bit on the dev-&gt;_tx
array which is not yet allocated.

As far as I understand the code removing the netif_start_queue from __NS8390_init
is OK, since queue will be started later on device open. Plz, correct me if I'm wrong.

Found in the Dave's current tree, so he's in Cc.

Signed-off-by: Pavel Emelyanov &lt;xemul@openvz.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The __NS8390_init tries to start the device queue before the
device is registered. This results in an oops (snipped):

[    2.865493] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
[    2.866106] IP: [&lt;ffffffffa000602a&gt;] netif_start_queue+0xb/0x12 [8390]
[    2.881267] Call Trace:
[    2.881437]  [&lt;ffffffffa000624d&gt;] __NS8390_init+0x102/0x15a [8390]
[    2.881999]  [&lt;ffffffffa00062ae&gt;] NS8390_init+0x9/0xb [8390]
[    2.882237]  [&lt;ffffffffa000d820&gt;] ne2k_pci_init_one+0x297/0x354 [ne2k_pci]
[    2.882955]  [&lt;ffffffff811c7a0e&gt;] local_pci_probe+0x12/0x16
[    2.883308]  [&lt;ffffffff811c85ad&gt;] pci_device_probe+0xc3/0xef
[    2.884049]  [&lt;ffffffff8129218d&gt;] driver_probe_device+0xbe/0x14b
[    2.884937]  [&lt;ffffffff81292260&gt;] __driver_attach+0x46/0x62
[    2.885170]  [&lt;ffffffff81291788&gt;] bus_for_each_dev+0x49/0x78
[    2.885781]  [&lt;ffffffff81291fbb&gt;] driver_attach+0x1c/0x1e
[    2.886089]  [&lt;ffffffff812912ab&gt;] bus_add_driver+0xba/0x227
[    2.886330]  [&lt;ffffffff8129259a&gt;] driver_register+0x9e/0x115
[    2.886933]  [&lt;ffffffff811c8815&gt;] __pci_register_driver+0x50/0xac
[    2.887785]  [&lt;ffffffffa001102c&gt;] ne2k_pci_init+0x2c/0x2e [ne2k_pci]
[    2.888093]  [&lt;ffffffff81000212&gt;] do_one_initcall+0x7c/0x130
[    2.888693]  [&lt;ffffffff8106d74f&gt;] sys_init_module+0x99/0x1da
[    2.888946]  [&lt;ffffffff81002a2b&gt;] system_call_fastpath+0x16/0x1b

This happens because the netif_start_queue sets respective bit on the dev-&gt;_tx
array which is not yet allocated.

As far as I understand the code removing the netif_start_queue from __NS8390_init
is OK, since queue will be started later on device open. Plz, correct me if I'm wrong.

Found in the Dave's current tree, so he's in Cc.

Signed-off-by: Pavel Emelyanov &lt;xemul@openvz.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
</feed>
