linux.git/drivers/net/ixp2000, branch v2.6.31 Linux kernel source tree drivers/net: fixed drivers that support netpoll use ndo_start_xmit() 2009-08-24T02:51:03+00:00 Dongdong Deng dongdong.deng@windriver.com 2009-08-24T02:49:07+00:00 4871953c0ef2cafeb37bbe186d9d13dcb24fc2c5 The NETPOLL API requires that interrupts remain disabled in netpoll_send_skb(). The use of "A functions set" in the NETPOLL API callbacks causes the interrupts to get enabled and can lead to kernel instability. The solution is to use "B functions set" to prevent the irqs from getting enabled while in netpoll_send_skb(). A functions set: local_irq_disable()/local_irq_enable() spin_lock_irq()/spin_unlock_irq() spin_trylock_irq()/spin_unlock_irq() B functions set: local_irq_save()/local_irq_restore() spin_lock_irqsave()/spin_unlock_irqrestore() spin_trylock_irqsave()/spin_unlock_irqrestore() Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com> Acked-by: Matt Mackall <mpm@selenic.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The NETPOLL API requires that interrupts remain disabled in
netpoll_send_skb(). The use of "A functions set" in the NETPOLL API
callbacks causes the interrupts to get enabled and can lead to kernel
instability.

The solution is to use "B functions set" to prevent the irqs from
getting enabled while in netpoll_send_skb().

A functions set:
local_irq_disable()/local_irq_enable()
spin_lock_irq()/spin_unlock_irq()
spin_trylock_irq()/spin_unlock_irq()

B functions set:
local_irq_save()/local_irq_restore()
spin_lock_irqsave()/spin_unlock_irqrestore()
spin_trylock_irqsave()/spin_unlock_irqrestore()

Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ixp2000/ixpdev: convert to net_device_ops 2009-04-16T09:20:13+00:00 Alexander Beregalov a.beregalov@gmail.com 2009-04-15T12:52:44+00:00 e7090e347ad8bce0de35f9fe2b95e22e4ae8fbab Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Remove redundant NAPI functions 2009-01-21T22:33:50+00:00 Ben Hutchings bhutchings@solarflare.com 2009-01-20T00:43:59+00:00 288379f050284087578b77e04f040b57db3db3f8 Following the removal of the unused struct net_device * parameter from the NAPI functions named *netif_rx_* in commit 908a7a1, they are exactly equivalent to the corresponding *napi_* functions and are therefore redundant. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Following the removal of the unused struct net_device * parameter from
the NAPI functions named *netif_rx_* in commit 908a7a1, they are
exactly equivalent to the corresponding *napi_* functions and are
therefore redundant.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Remove unused netdev arg from some NAPI interfaces. 2008-12-23T04:43:12+00:00 Neil Horman nhorman@tuxdriver.com 2008-12-23T04:43:12+00:00 908a7a16b852ffd618a9127be8d62432182d81b4 When the napi api was changed to separate its 1:1 binding to the net_device struct, the netif_rx_[prep|schedule|complete] api failed to remove the now vestigual net_device structure parameter. This patch cleans up that api by properly removing it.. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
When the napi api was changed to separate its 1:1 binding to the net_device
struct, the netif_rx_[prep|schedule|complete] api failed to remove the now
vestigual net_device structure parameter.  This patch cleans up that api by
properly removing it..

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net: Kill now superfluous ->last_rx stores. 2008-11-04T05:11:17+00:00 David S. Miller davem@davemloft.net 2008-11-04T05:11:17+00:00 babcda74e9d96bb58fd9c6c5112dbdbff169e695 The generic packet receive code takes care of setting netdev->last_rx when necessary, for the sake of the bonding ARP monitor. Drivers need not do it any more. Some cases had to be skipped over because the drivers were making use of the ->last_rx value themselves. Signed-off-by: David S. Miller <davem@davemloft.net> 
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.

Drivers need not do it any more.

Some cases had to be skipped over because the drivers
were making use of the ->last_rx value themselves.

Signed-off-by: David S. Miller <davem@davemloft.net>
[ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach 2008-08-07T08:55:48+00:00 Russell King rmk@dyn-67.arm.linux.org.uk 2008-08-05T15:14:15+00:00 a09e64fbc0094e3073dbb09c3b4bfe4ab669244b This just leaves include/asm-arm/plat-* to deal with. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> 
This just leaves include/asm-arm/plat-* to deal with.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
[ARM] Remove asm/hardware.h, use asm/arch/hardware.h instead 2008-08-07T08:40:08+00:00 Russell King rmk@dyn-67.arm.linux.org.uk 2008-08-04T09:41:28+00:00 be509729356b7433f73df2b9a966674a437fbbc1 Remove includes of asm/hardware.h in addition to asm/arch/hardware.h. Then, since asm/hardware.h only exists to include asm/arch/hardware.h, update everything to directly include asm/arch/hardware.h and remove asm/hardware.h. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> 
Remove includes of asm/hardware.h in addition to asm/arch/hardware.h.
Then, since asm/hardware.h only exists to include asm/arch/hardware.h,
update everything to directly include asm/arch/hardware.h and remove
asm/hardware.h.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
[ARM] Eliminate useless includes of asm/mach-types.h 2008-08-07T08:40:04+00:00 Russell King rmk@dyn-67.arm.linux.org.uk 2008-08-03T14:06:16+00:00 0f8469a54f7bd65f2c740a5480c56260dc8a7ae0 There are 43 includes of asm/mach-types.h by files that don't reference anything from that file. Remove these unnecessary includes. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> 
There are 43 includes of asm/mach-types.h by files that don't
reference anything from that file.  Remove these unnecessary
includes.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
ixp2000: use netdev_alloc_skb 2008-05-22T18:12:39+00:00 Stephen Hemminger shemminger@vyatta.com 2008-04-16T23:37:37+00:00 d27e7c3f6c82297611d1e1ee9476a2f31b3e89df Use netdev_alloc_skb. This sets skb->dev and allows arch specific allocation. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com> 
Use netdev_alloc_skb. This sets skb->dev and allows arch specific
allocation.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
[NET]: Do not check netif_running() and carrier state in ->poll() 2008-01-09T07:30:09+00:00 David S. Miller davem@davemloft.net 2008-01-08T04:48:21+00:00 4ec2411980d0fd2995e8dea8a06fe57aa47523cb Drivers do this to try to break out of the ->poll()'ing loop when the device is being brought administratively down. Now that we have a napi_disable() "pending" state we are going to solve that problem generically. Signed-off-by: David S. Miller <davem@davemloft.net> 
Drivers do this to try to break out of the ->poll()'ing loop
when the device is being brought administratively down.

Now that we have a napi_disable() "pending" state we are going
to solve that problem generically.

Signed-off-by: David S. Miller <davem@davemloft.net>