linux.git/drivers/net/ipg.c, branch v2.6.24

ipg: fix Tx completion irq request

2008-01-17T22:35:09+00:00

The current logic will only request an ack for the first pending
packet. No irq is triggered as soon as the CPU submits a few
packets a bit quickly.  Let's request an irq for every packet
instead.

Signed-off-by: Francois Romieu

ipg: fix queue stop condition in the xmit handler

2008-01-17T22:35:09+00:00

Signed-off-by: Francois Romieu

ipg: plug Tx completion leak

2008-01-17T22:35:09+00:00

The Tx skb release could not free more than one skb per call.
Add it to the fact that the xmit handler does not check for
a queue full condition and you have a recipe to leak quickly.

Let's release every pending Tx descriptor which has been given
back to the host CPU by the network controller. The xmit handler
suggests that it is done through the IPG_TFC_TFDDONE bit.

Remove the former "curr" computing: it does not produce anything
usable in its current form.

Signed-off-by: Francois Romieu

ipg: balance locking in irq handler

2008-01-17T22:35:09+00:00

Spotted-by: 
Signed-off-by: Francois Romieu

drivers/net/ipg.c: cleanups

2007-10-25T07:31:13+00:00

This patch contains the following cleanups:
- make ipg_nic_get_stats() static
- move DefaultPhyParam[] from ipg.h to ipg.c and make it static

Signed-off-by: Adrian Bunk 
Signed-off-by: Jeff Garzik

ipg: endianness fixes

2007-10-14T19:41:52+00:00

if your mask is host-endian, you should apply it after le64_to_cpu();
if it's little-endian - before.  Doing both (for the same mask and
little-endian value) is broken.

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

ipg.c doesn't compile with with CONFIG_HIGHMEM64G

2007-10-10T23:54:28+00:00

I've tried to compile 2.6.23-rc8-mm2, but it fails on ipg.c with the
error : ERROR: "__udivdi3" [drivers/net/ipg.ko] undefined!

I've instigated a bit, and I've found this code in ipg.c :

static void ipg_nic_txfree(struct net_device *dev)
{
       struct ipg_nic_private *sp = netdev_priv(dev);
       void __iomem *ioaddr = sp->ioaddr;
       const unsigned int curr = ipg_r32(TFD_LIST_PTR_0) -
               (sp->txd_map / sizeof(struct ipg_tx)) - 1;
       unsigned int released, pending;

sp->txd_map is an u64
because :
	dma_addr_t txd_map;

And in asm-i386/types.h, I see :
#ifdef CONFIG_HIGHMEM64G
typedef u64 dma_addr_t;
#else
typedef u32 dma_addr_t;
#endif
I my config, I use CONFIG_HIGHMEM64G

sizeof(struct ipg_tx) is an u32
So the div failed on i386 because of u64 / u32.

[akpm@linux-foundation.org: cleanups]
Cc: Sorbica Shieh 
Cc: Jesse Huang 
Cc: Jeff Garzik 
Cc: "David S. Miller" 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

[IPG]: add IP1000A driver to kernel tree

2007-10-10T23:51:33+00:00

Signed-off-by: Jesse Huang 
Signed-off-by: Stefan Lippers-Hollmann 
Signed-off-by: Francois Romieu 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller