linux.git/drivers/net/hyperv, branch v6.8-rc2

hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-24T01:19:42+00:00

Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE
is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a
result, the default VMBus ring buffer size on ARM64 with 64K page size
is 8 Mbytes instead of the expected 512 Kbytes. While this doesn't break
anything, a typical VM with 8 vCPUs and 8 netvsc channels wastes 120
Mbytes (8 channels * 2 ring buffers/channel * 7.5 Mbytes/ring buffer).

Unfortunately, the module parameter specifying the ring buffer size
is in units of 4 Kbyte pages. Ideally, it should be in units that
are independent of PAGE_SIZE, but backwards compatibility prevents
changing that now.

Fix this by having netvsc_drv_init() hardcode 4096 instead of using
PAGE_SIZE when calculating the ring buffer size in bytes. Also
use the VMBUS_RING_SIZE macro to ensure proper alignment when running
with page size larger than 4K.

Cc:  # 5.15.x
Fixes: 7aff79e297ee ("Drivers: hv: Enable Hyper-V code to be built on ARM64")
Signed-off-by: Michael Kelley 
Link: https://lore.kernel.org/r/20240122162028.348885-1-mhklinux@outlook.com
Signed-off-by: Jakub Kicinski

hv_netvsc: remove duplicated including of slab.h

2023-12-15T12:19:00+00:00

rm the second include 

Signed-off-by: Wang Jinchao 
Signed-off-by: David S. Miller

net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops

2023-12-14T06:07:16+00:00

The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters
as direct function arguments. This will force us to change the API (and
all drivers' functions) every time some new parameters are added.

This is part 1/2 of the fix, as suggested in [1]:

- First simplify the code by always providing a pointer to all params
   (indir, key and func); the fact that some of them may be NULL seems
   like a weird historic thing or a premature optimization.
   It will simplify the drivers if all pointers are always present.

 - Then make the functions take a dev pointer, and a pointer to a
   single struct wrapping all arguments. The set_* should also take
   an extack.

Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@kernel.org/ [1]
Suggested-by: Jakub Kicinski 
Suggested-by: Jacob Keller 
Signed-off-by: Ahmed Zaki 
Link: https://lore.kernel.org/r/20231213003321.605376-2-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski

net: Convert some ethtool_sprintf() to ethtool_puts()

2023-12-08T10:56:25+00:00

This patch converts some basic cases of ethtool_sprintf() to
ethtool_puts().

The conversions are used in cases where ethtool_sprintf() was being used
with just two arguments:
|       ethtool_sprintf(&data, buffer[i].name);
or when it's used with format string: "%s"
|       ethtool_sprintf(&data, "%s", buffer[i].name);
which both now become:
|       ethtool_puts(&data, buffer[i].name);

Signed-off-by: Justin Stitt 
Reviewed-by: Wei Fang 
Reviewed-by: Andrew Lunn 
Reviewed-by: Louis Peens 
Signed-off-by: David S. Miller

hv_netvsc: rndis_filter needs to select NLS

2023-12-02T04:12:24+00:00

rndis_filter uses utf8s_to_utf16s() which is provided by setting
NLS, so select NLS to fix the build error:

ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!

Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
Signed-off-by: Randy Dunlap 
Cc: Haiyang Zhang 
Cc: K. Y. Srinivasan 
Cc: Wei Liu 
Cc: Dexuan Cui 
Reviewed-by: Simon Horman 
Tested-by: Simon Horman  # build-tested
Reviewed-by: Michael Kelley 
Link: https://lore.kernel.org/r/20231130055853.19069-1-rdunlap@infradead.org
Signed-off-by: Jakub Kicinski

hv_netvsc: Mark VF as slave before exposing it to user-mode

2023-11-21T12:15:02+00:00

When a VF is being exposed form the kernel, it should be marked as "slave"
before exposing to the user-mode. The VF is not usable without netvsc
running as master. The user-mode should never see a VF without the "slave"
flag.

This commit moves the code of setting the slave flag to the time before
VF is exposed to user-mode.

Cc: stable@vger.kernel.org
Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
Signed-off-by: Long Li 
Signed-off-by: Haiyang Zhang 
Acked-by: Stephen Hemminger 
Acked-by: Dexuan Cui 
Signed-off-by: Paolo Abeni

hv_netvsc: Fix race of register_netdevice_notifier and VF register

2023-11-21T12:15:02+00:00

If VF NIC is registered earlier, NETDEV_REGISTER event is replayed,
but NETDEV_POST_INIT is not.

Move register_netdevice_notifier() earlier, so the call back
function is set before probing.

Cc: stable@vger.kernel.org
Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()")
Reported-by: Dexuan Cui 
Signed-off-by: Haiyang Zhang 
Reviewed-by: Wojciech Drewek 
Reviewed-by: Dexuan Cui 
Signed-off-by: Paolo Abeni

hv_netvsc: fix race of netvsc and VF register_netdevice

2023-11-21T12:15:02+00:00

The rtnl lock also needs to be held before rndis_filter_device_add()
which advertises nvsp_2_vsc_capability / sriov bit, and triggers
VF NIC offering and registering. If VF NIC finished register_netdev()
earlier it may cause name based config failure.

To fix this issue, move the call to rtnl_lock() before
rndis_filter_device_add(), so VF will be registered later than netvsc
/ synthetic NIC, and gets a name numbered (ethX) after netvsc.

Cc: stable@vger.kernel.org
Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()")
Reported-by: Dexuan Cui 
Signed-off-by: Haiyang Zhang 
Reviewed-by: Wojciech Drewek 
Reviewed-by: Simon Horman 
Reviewed-by: Dexuan Cui 
Signed-off-by: Paolo Abeni

hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

2023-10-11T08:19:01+00:00

The switch statement in netvsc_send_completion() is incorrectly validating
the length of incoming network packets by falling through to the next case.
Avoid the fallthrough. Instead break after a case match and then process
the complete() call.
The current code has not caused any known failures. But nonetheless, the
code should be corrected as a different ordering of the switch cases might
cause a length check to fail when it should not.

Signed-off-by: Sonia Sharma 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

eth: add missing xdp.h includes in drivers

2023-08-03T15:38:07+00:00

Handful of drivers currently expect to get xdp.h by virtue
of including netdevice.h. This will soon no longer be the case
so add explicit includes.

Reviewed-by: Wei Fang 
Reviewed-by: Gerhard Engleder 
Signed-off-by: Jakub Kicinski 
Acked-by: Jesper Dangaard Brouer 
Link: https://lore.kernel.org/r/20230803010230.1755386-2-kuba@kernel.org
Signed-off-by: Martin KaFai Lau