linux.git/drivers/net/hyperv, branch v4.9-rc2 Linux kernel source tree netvsc: Remove mistaken udp.h inclusion. 2016-10-13T15:04:07+00:00 David S. Miller davem@davemloft.net 2016-10-13T15:04:07+00:00 3f2b0a5a3583a2c6c3aeb2d59e7f775d43faa89c Based upon v2 of Stephen's patch. Signed-off-by: David S. Miller <davem@davemloft.net> 
Based upon v2 of Stephen's patch.

Signed-off-by: David S. Miller <davem@davemloft.net>
netvsc: fix checksum on UDP IPV6 2016-10-13T14:48:17+00:00 stephen hemminger stephen@networkplumber.org 2016-10-11T21:03:07+00:00 ad19bc8a95baee4588e9ec4481297d97c0bec765 The software calculation of UDP checksum in Netvsc driver was only handling IPv4 case. By using skb_checksum_help() instead all protocols can be handled. Rearrange code to eliminate goto and look like other drivers. This is a temporary solution; recent versions of Window Server etc do support UDP checksum offload, just need to do the appropriate negotiation with host to validate before using. This will be done in later patch. Please queue this for -stable as well. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The software calculation of UDP checksum in Netvsc driver was
only handling IPv4 case. By using skb_checksum_help() instead
all protocols can be handled. Rearrange code to eliminate goto
and look like other drivers.

This is a temporary solution; recent versions of Window Server etc
do support UDP checksum offload, just need to do the appropriate negotiation
with host to validate before using. This will be done in later patch.

Please queue this for -stable as well.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: fix comments 2016-09-24T13:36:12+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-24T00:08:17+00:00 c6a77ff82fb849534748719f37f3f9086d78ed39 Typo's and spelling errors. Also remove old comment from staging era. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Typo's and spelling errors. Also remove old comment from staging era.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: count multicast packets received 2016-09-23T12:39:49+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:35+00:00 f7ad75b753f386454f50044fd69edad767b69ce8 Useful for debugging issues with multicast and SR-IOV to keep track of number of received multicast packets. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Useful for debugging issues with multicast and SR-IOV to keep track
of number of received multicast packets.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: remove VF in flight counters 2016-09-23T12:39:49+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:34+00:00 9cbcc4280645f0e7e19e6a0da443ec7e69cecf40 Since VF reference is now protected by RCU, no longer need the VF usage counter and can use device flags to see whether to inject or not. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Since VF reference is now protected by RCU, no longer need the VF usage
counter and can use device flags to see whether to inject or not.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: use RCU to protect vf_netdev 2016-09-23T12:39:49+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:33+00:00 f207c10d982388fa42710922ad1c0c9d3ba9a87b The vf_netdev pointer in the netvsc device context can simply be protected by RCU because network device destruction is already RCU synchronized. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The vf_netdev pointer in the netvsc device context can simply be protected
by RCU because network device destruction is already RCU synchronized.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: improve VF device matching 2016-09-23T12:39:49+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:32+00:00 e8ff40d4bff1f3b6a588e29ed1fbdfd943642856 The code to associate netvsc and VF devices can be made less error prone by using a better matching algorithms. On registration, use the permanent address which avoids any possible issues caused by device MAC address being changed. For all other callbacks, search by the netdevice pointer value to ensure getting the correct network device. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The code to associate netvsc and VF devices can be made less error prone
by using a better matching algorithms.

On registration, use the permanent address which avoids any possible
issues caused by device MAC address being changed. For all other callbacks,
search by the netdevice pointer value to ensure getting the correct
network device.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: simplify callback event code 2016-09-23T12:39:49+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:31+00:00 ee837a137304290a1ae26980c73a367f7afef54f The callback handler for netlink events can be simplified: * Consolidate check for netlink callback events about this driver itself. * Ignore non-Ethernet devices. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The callback handler for netlink events can be simplified:
 * Consolidate check for netlink callback events about this driver itself.
 * Ignore non-Ethernet devices.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: dev hold/put reference to VF 2016-09-23T12:39:48+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:30+00:00 07d0f0008c783d2a2fce8497000938db15fd7aa1 The netvsc driver holds a pointer to the virtual function network device if managing SR-IOV association. In order to ensure that the VF network device does not disappear, it should be using dev_hold/dev_put to get a reference count. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The netvsc driver holds a pointer to the virtual function network device if
managing SR-IOV association. In order to ensure that the VF network device
does not disappear, it should be using dev_hold/dev_put to get a reference
count.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: use consume_skb 2016-09-23T12:39:48+00:00 Stephen Hemminger sthemmin@microsoft.com 2016-09-22T23:56:29+00:00 17db4bcef3c3c45b95b3b3d8577f725df1b2c0a0 Packets that are transmitted in normal path should use consume_skb instead of kfree_skb. This allows for better tracing of packet drops. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Packets that are transmitted in normal path should use consume_skb
instead of kfree_skb. This allows for better tracing of packet drops.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>