linux.git/drivers/net/hyperv, branch v4.8-rc2

hv_netvsc: Fix VF register on bonding devices

2016-07-25T18:19:22+00:00

Added a condition to avoid bonding devices with same MAC registering
as VF.

Signed-off-by: Haiyang Zhang 
Reviewed-by: K. Y. Srinivasan 
Signed-off-by: David S. Miller

netvsc: Use the new in-place consumption APIs in the rx path

2016-07-09T03:11:20+00:00

Use the new APIs for eliminating a copy on the receive path. These new APIs also
help in minimizing the number of memory barriers we end up issuing (in the
ringbuffer code) since we can better control when we want to expose the ring
state to the host.

The patch is being resent to address earlier email issues.

Signed-off-by: K. Y. Srinivasan 
Signed-off-by: David S. Miller

netvsc: get rid of completion timeouts

2016-06-09T18:40:05+00:00

I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting
RSS parameters for the device. When this happens we end up returning
-ETIMEDOUT from the function and rndis_filter_device_add() falls back to
setting

        net_device->max_chn = 1;
        net_device->num_chn = 1;
        net_device->num_sc_offered = 0;

but after a moment the rndis request succeeds and subchannels start to
appear. netvsc_sc_open() does unconditional nvscdev->num_sc_offered-- and
it becomes U32_MAX-1. Consequent rndis_filter_device_remove() will hang
while waiting for all U32_MAX-1 subchannels to appear and this is not
going to happen.

The immediate issue could be solved by adding num_sc_offered > 0 check to
netvsc_sc_open() but we're getting out of sync with the host and it's not
easy to adjust things later, e.g. in this particular case we'll be creating
queues without a user request for it and races are expected. Same applies
to other parts of the driver which have the same completion timeout.

Following the trend in drivers/hv/* code I suggest we remove all these
timeouts completely. As a guest we can always trust the host we're running
on and if the host screws things up there is no easy way to recover anyway.

Signed-off-by: Vitaly Kuznetsov 
Acked-by: Haiyang Zhang 
Signed-off-by: David S. Miller

hv_netvsc: pass struct net_device to rndis_filter_set_offload_params()

2016-06-06T03:16:36+00:00

The only caller rndis_filter_device_add() has 'struct net_device' pointer
already.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller

hv_netvsc: pass struct net_device to rndis_filter_set_device_mac()

2016-06-06T03:16:36+00:00

We unpack 'struct net_device' in netvsc_set_mac_addr() to get to
'struct hv_device' pointer which we use in rndis_filter_set_device_mac()
to get back to 'struct net_device'.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller

hv_netvsc: pass struct netvsc_device to rndis_filter_{open, close}()

2016-06-06T03:16:36+00:00

Both rndis_filter_open()/rndis_filter_close() use struct hv_device to
reach to struct netvsc_device only and all callers have it already.
While on it, rename net_device to nvdev in rndis_filter_open() as
net_device is misleading.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller

hv_netvsc: introduce {net, hv}_device_to_netvsc_device() helpers

2016-06-06T03:16:35+00:00

Make it easier to get 'struct netvsc_device' from 'struct net_device' and
'struct hv_device' by introducing inline helpers.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller

hv_netvsc: remove redundant assignment in netvsc_recv_callback()

2016-06-06T03:16:35+00:00

net_device_ctx is assigned in the very beginning of the function and 'net'
pointer doesn't change.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller

hv_netvsc: Fix VF register on vlan devices

2016-06-03T23:40:05+00:00

Added a condition to avoid vlan devices with same MAC registering
as VF.

Signed-off-by: Haiyang Zhang 
Reviewed-by: K. Y. Srinivasan 
Signed-off-by: David S. Miller

hv_netvsc: set nvdev link after populating chn_table

2016-05-16T17:26:01+00:00

Crash in netvsc_send() is observed when netvsc device is re-created on
mtu change/set channels. The crash is caused by dereferencing of NULL
channel pointer which comes from chn_table. The root cause is a mixture
of two facts:
- we set nvdev pointer in net_device_context in alloc_net_device()
  before we populate chn_table.
- we populate chn_table[0] only.

The issue could be papered over by checking channel != NULL in
netvsc_send() but populating the whole chn_table and writing the
nvdev pointer afterwards seems more appropriate.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller