linux.git/drivers/net/hyperv/netvsc.c, branch v4.6 Linux kernel source tree hv_netvsc: Fix book keeping of skb during batching process 2016-01-25T18:51:53+00:00 Haiyang Zhang haiyangz@microsoft.com 2016-01-25T17:49:31+00:00 c85e4924452ae8225c8829f3fa8a2f7baa34bc5c Since eliminating send_completion_tid from struct hv_netvsc_packet, we haven't add proper book keeping for the skb of the batched packet. This patch fixes this issue and allows the previous skb is properly freed. Otherwise, a panic may happen. Thanks to Simon Xiao <sixiao@microsoft.com> for bisecting and analysis. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Since eliminating send_completion_tid from struct hv_netvsc_packet, we
haven't add proper book keeping for the skb of the batched packet. This
patch fixes this issue and allows the previous skb is properly freed.
Otherwise, a panic may happen.
Thanks to Simon Xiao <sixiao@microsoft.com> for bisecting and analysis.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Fix race condition on Multi-Send Data field 2015-12-14T05:02:06+00:00 Haiyang Zhang haiyangz@microsoft.com 2015-12-10T20:19:35+00:00 cf8190e4c26c8ccf87d80793f8f1f7fe150cdf8c In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the locking for MSD (Multi-Send Data) field was removed. This could cause a race condition between RNDIS control messages and data packets processing, because these two types of traffic are not synchronized. This patch fixes this issue by sending control messages out directly without reading MSD field. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the
locking for MSD (Multi-Send Data) field was removed. This could cause a
race condition between RNDIS control messages and data packets processing,
because these two types of traffic are not synchronized.
This patch fixes this issue by sending control messages out directly
without reading MSD field.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Eliminate status from struct hv_netvsc_packet 2015-12-03T04:43:25+00:00 KY Srinivasan kys@microsoft.com 2015-12-02T00:43:18+00:00 10082f98878a9dff1563745f9f1dd9d1ff142700 Eliminate status from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Eliminate status from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Eliminate xmit_more from struct hv_netvsc_packet 2015-12-03T04:43:25+00:00 KY Srinivasan kys@microsoft.com 2015-12-02T00:43:17+00:00 bde79be529c43b5a5a877b3e0b93607d22a8b01e Eliminate xmit_more from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Eliminate xmit_more from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Eliminate is_data_pkt from struct hv_netvsc_packet 2015-12-03T04:43:25+00:00 KY Srinivasan kys@microsoft.com 2015-12-02T00:43:15+00:00 694a9fb0263dddfb07bc490a02e59d6962602fe8 Eliminate is_data_pkt from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Eliminate is_data_pkt from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Eliminate send_completion_tid from struct hv_netvsc_packet 2015-12-03T04:43:25+00:00 KY Srinivasan kys@microsoft.com 2015-12-02T00:43:14+00:00 3a3d9a0a731add5afaafd9c714e7efe11820fe5b Eliminate send_completion_tid from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Eliminate send_completion_tid from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Eliminate page_buf from struct hv_netvsc_packet 2015-12-03T04:43:24+00:00 KY Srinivasan kys@microsoft.com 2015-12-02T00:43:13+00:00 a9f2e2d6569d00ae8f9f832f1b56bc7702dfd2d3 Eliminate page_buf from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Eliminate page_buf from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: remove locking in netvsc_send() 2015-12-03T04:43:24+00:00 Vitaly Kuznetsov vkuznets@redhat.com 2015-12-02T00:43:12+00:00 2a04ae8acb144996eba6e3d69ab2a7156c775416 Packet scheduler guarantees there won't be multiple senders for the same queue and as we use q_idx for multi_send_data the spinlock is redundant. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Packet scheduler guarantees there won't be multiple senders for the same
queue and as we use q_idx for multi_send_data the spinlock is redundant.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: move subchannel existence check to netvsc_select_queue() 2015-12-03T04:43:24+00:00 Vitaly Kuznetsov vkuznets@redhat.com 2015-12-02T00:43:11+00:00 8b9fbe1ac390689f01153d6af8485caec5423ccc Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hv_netvsc: Eliminate send_completion_ctx from struct hv_netvsc_packet 2015-12-03T04:43:24+00:00 KY Srinivasan kys@microsoft.com 2015-12-02T00:43:09+00:00 074c2fe5ef3d09e9a1008d307a22ab5086e22728 Eliminate send_completion_ctx from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Eliminate send_completion_ctx from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>