linux.git/drivers/net/hyperv/netvsc.c, branch v4.16

hv_netvsc: common detach logic

2018-03-22T16:45:09+00:00

Make common function for detaching internals of device
during changes to MTU and RSS. Make sure no more packets
are transmitted and all packets have been received before
doing device teardown.

Change the wait logic to be common and use usleep_range().

Changes transmit enabling logic so that transmit queues are disabled
during the period when lower device is being changed. And enabled
only after sub channels are setup. This avoids issue where it could
be that a packet was being sent while subchannel was not initialized.

Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: change GPAD teardown order on older versions

2018-03-22T16:45:09+00:00

On older versions of Windows, the host ignores messages after
vmbus channel is closed.

Workaround this by doing what Windows does and send the teardown
before close on older versions of NVSP protocol.

Reported-by: Mohammed Gamal 
Fixes: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: use RCU to fix concurrent rx and queue changes

2018-03-22T16:45:09+00:00

The receive processing may continue to happen while the
internal network device state is in RCU grace period.
The internal RNDIS structure is associated with the
internal netvsc_device structure; both have the same
RCU lifetime.

Defer freeing all associated parts until after grace
period.

Fixes: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: disable NAPI before channel close

2018-03-22T16:45:09+00:00

This makes sure that no CPU is still process packets when
the channel is closed.

Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal")
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: use napi_schedule_irqoff

2018-03-05T03:18:20+00:00

Since the netvsc_channel_cb is already called in interrupt
context from vmbus, there is no need to do irqsave/restore.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: fix race in napi poll when rescheduling

2018-03-05T03:18:20+00:00

There is a race between napi_reschedule and re-enabling interrupts
which could lead to missed host interrrupts.  This occurs when
interrupts are re-enabled (hv_end_read) and vmbus irq callback
(netvsc_channel_cb) has already scheduled NAPI.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: fix error unwind handling if vmbus_open fails

2018-03-05T03:18:20+00:00

Need to delete NAPI association if vmbus_open fails.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: avoid retry on send during shutdown

2018-03-05T03:18:20+00:00

Change the initialization order so that the device is ready to transmit
(ie connect vsp is completed) before setting the internal reference
to the device with RCU.

This avoids any races on initialization and prevents retry issues
on shutdown.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: empty current transmit aggregation if flow blocked

2017-12-13T20:57:39+00:00

If the transmit queue is known full, then don't keep aggregating
data. And the cp_partial flag which indicates that the current
aggregation buffer is full can be folded in to avoid more
conditionals.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: remove open_cnt reference count

2017-12-13T20:57:39+00:00

There is only ever a single instance of network device object
referencing the internal rndis object. Therefore the open_cnt atomic
is not necessary.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller