linux.git/drivers/net/hyperv/netvsc.c, branch v4.15

hv_netvsc: netvsc_teardown_gpadl() split

2017-11-08T01:28:54+00:00

It was found that in some cases host refuses to teardown GPADL for send/
receive buffers (probably when some work with these buffere is scheduled or
ongoing). Change the teardown logic to be:
1) Send NVSP_MSG1_TYPE_REVOKE_* messages
2) Close the channel
3) Teardown GPADLs.
This seems to work reliably.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: David S. Miller

hv_netvsc: Add initialization of tx_table in netvsc_device_add()

2017-10-15T01:42:55+00:00

tx_table is part of the private data of kernel net_device. It is only
zero-ed out when allocating net_device.

We may recreate netvsc_device w/o recreating net_device, so the private
netdev data, including tx_table, are not zeroed. It may contain channel
numbers for the older netvsc_device.

This patch adds initialization of tx_table each time we recreate
netvsc_device.

Signed-off-by: Haiyang Zhang 
Signed-off-by: David S. Miller

hv_netvsc: Rename tx_send_table to tx_table

2017-10-15T01:42:55+00:00

Simplify the variable name: tx_send_table

Signed-off-by: Haiyang Zhang 
Signed-off-by: David S. Miller

hv_netvsc: report stop_queue and wake_queue

2017-10-01T03:10:30+00:00

Report the numbers of events for stop_queue and wake_queue in
ethtool stats.

Example:
ethtool -S eth0
NIC statistics:
	...
	stop_queue: 7
	wake_queue: 7
	...

Signed-off-by: Simon Xiao 
Reviewed-by: Haiyang Zhang 
Signed-off-by: David S. Miller

hv_netvsc: make const array ver_list static, reduces object code size

2017-09-25T23:25:17+00:00

Don't populate const array ver_list on the stack, instead make it
static. Makes the object code smaller by over 400 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  18444	   3168	    320	  21932	   55ac	drivers/net/hyperv/netvsc.o

After:
   text	   data	    bss	    dec	    hex	filename
  17950	   3224	    320	  21494	   53f6	drivers/net/hyperv/netvsc.o

(gcc 6.3.0, x86-64)

Signed-off-by: Colin Ian King 
Reviewed-by: Haiyang Zhang 
Signed-off-by: David S. Miller

hv_netvsc: fix send buffer failure on MTU change

2017-09-21T22:17:16+00:00

If MTU is changed the host would reject the send buffer change.
This problem is result of recent change to allow changing send
buffer size.

Every time we change the MTU, we store the previous net_device section
count before destroying the buffer, but we don’t store the previous
section size. When we reinitialize the buffer, its size is calculated
by multiplying the previous count and previous size. Since we
continuously increase the MTU, the host returns us a decreasing count
value while the section size is reinitialized to 1728 bytes every
time.

This eventually leads to a condition where the calculated buf_size is
so small that the host rejects it.

Fixes: 8b5327975ae1 ("netvsc: allow controlling send/recv buffer size")
Signed-off-by: Alex Ng 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

hv_netvsc: fix deadlock on hotplug

2017-09-11T21:21:30+00:00

When a virtual device is added dynamically (via host console), then
the vmbus sends an offer message for the primary channel. The processing
of this message for networking causes the network device to then
initialize the sub channels.

The problem is that setting up the sub channels needs to wait until
the subsequent subchannel offers have been processed. These offers
come in on the same ring buffer and work queue as where the primary
offer is being processed; leading to a deadlock.

This did not happen in older kernels, because the sub channel waiting
logic was broken (it wasn't really waiting).

The solution is to do the sub channel setup in its own work queue
context that is scheduled by the primary channel setup; and then
happens later.

Fixes: 732e49850c5e ("netvsc: fix race on sub channel creation")
Reported-by: Dexuan Cui 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

vmbus: remove unused vmbus_sendpacket_ctl

2017-08-16T23:27:45+00:00

The only usage of vmbus_sendpacket_ctl was by vmbus_sendpacket.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

vmbus: remove unused vmubs_sendpacket_pagebuffer_ctl

2017-08-16T23:27:45+00:00

The function vmbus_sendpacket_pagebuffer_ctl was never used directly.
Just have vmbus_send_pagebuffer

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netvsc: keep track of some non-fatal overload conditions

2017-08-11T21:00:07+00:00

Add ethtool statistics for case where send chimmeny buffer is
exhausted and driver has to fall back to doing scatter/gather
send. Also, add statistic for case where ring buffer is full and
receive completions are delayed.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller