linux.git/drivers/net/forcedeth.c, branch v2.6.37

vlan: Don't check for vlan group before vlan_tx_tag_present.

2010-10-21T08:26:52+00:00

Many (but not all) drivers check to see whether there is a vlan
group configured before using a tag stored in the skb.  There's
not much point in this check since it just throws away data that
should only be present in the expected circumstances.  However,
it will soon be legal and expected to get a vlan tag when no
vlan group is configured, so remove this check from all drivers
to avoid dropping the tags.

Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller

drivers/net: return operator cleanup

2010-09-27T01:34:29+00:00

Change "return (EXPR);" to "return EXPR;"

return is not a function, parentheses are not required.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

drivers/net: Remove address use from assignments of function pointers

2010-08-25T22:35:43+00:00

"foo = &function" is more commonly written "foo = function"

Done with coccinelle script:

// 
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// 

drivers/net/tehuti.c used a function and struct with the
same name, the function was renamed.

Compile tested x86 only.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

forcedeth: Fix different hardware statistics versions.

2010-07-26T04:54:28+00:00

The macros for the values of the bit field describing the four
different versions of statistics supported by different hardware
variants were being misused.  Where the code was trying to test if the
hardware implements V3, it was actually testing whether it implements
any of V1, V2, or V3, causing the driver to report statistics that
don't really exist in the hardware, with bogus values.

Signed-off-by: Mike Ditto 
Signed-off-by: David S. Miller

forcedeth: correct valid flag

2010-07-06T05:15:47+00:00

Elsewhere in the "optimized" functions, the "2" constants are used.
NV_TX_VALID and NV_TX2_VALID have the same value.

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

net: trans_start cleanups

2010-05-10T12:01:31+00:00

Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.

Exceptions are NETIF_F_LLTX drivers

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

forcedeth: Account for consumed budget in napi poll

2010-05-06T04:24:17+00:00

Repeated calls to nv_rx_process in napi poll routine do not take
portion of budget that has been consumed in previous calls.  Fix by
subtracting the number of packets processed.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

forcedeth: Kill NAPI config options.

2010-05-04T06:33:05+00:00

All distributions enable it, therefore no significant body of users
are even testing the driver with it disabled.  And making NAPI
configurable is heavily discouraged anyways.

I left the MSI-X interrupt enabling thing in an "#if 0" block
so hopefully someone can debug that and it can get re-enabled.
Probably it was just one of the NVIDIA chipset MSI erratas that
we work handle these days in the PCI quirks (see drivers/pci/quirks.c
and stuff like nvenet_msi_disable()).

Signed-off-by: David S. Miller

forcedeth: GRO support

2010-05-04T06:24:19+00:00

Add GRO support to forcedeth.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

forcedeth: Stay in NAPI as long as there's work

2010-04-30T23:15:38+00:00

The following does the same thing without the extra overhead
of testing all the registers. It also handles the out of memory
case.

Signed-off-by: Stephen Hemminger 
Tested-by: Tom Herbert 
Signed-off-by: David S. Miller