linux.git/drivers/net/forcedeth.c, branch v2.6.25

forcedeth: mac address fix

2008-04-12T08:38:12+00:00

This critical patch fixes a mac address issue recently introduced.  If the
device's mac address was in correct order and the flag
NVREG_TRANSMITPOLL_MAC_ADDR_REV was set, during nv_remove the flag would get
cleared.  During next load, the mac address would get reversed because the
flag is missing.

As it has been indicated previously, the flag is cleared across a low power
transition.  Therefore, the driver should set the mac address back into the
reversed order when clearing the flag.

Also, the driver should set back the flag after a low power transition to
protect against kexec command calling nv_probe a second time.

Signed-off-by: Ayaz Abdulla 
Cc: "Yinghai Lu" 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

fix endian lossage in forcedeth

2008-04-04T21:26:16+00:00

a) if you initialize something with le32_to_cpu(...), then |= it
with host-endian and feed to cpu_to_le32(), it's most definitely
*not* __le32.  As sparse would've told you...

b) the whole sequence is |= cpu_to_le32(host-endian constant)

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

forcedeth: fix locking bug with netconsole

2008-03-29T02:08:02+00:00

While using netconsole on forcedeth, lockdep noticed the following locking
bug:

=================================
[ INFO: inconsistent lock state ]
2.6.24-rc6 #6
Signed-off-by: Ingo Molnar 
---------------------------------
inconsistent {softirq-on-W} -> {in-softirq-W} usage.
udevd/719 [HC0[0]:SC1[1]:HE1:SE0] takes:
 (_xmit_ETHER){-+..}, at: [] dev_watchdog+0x1c/0xb9
{softirq-on-W} state was registered at:
  [] mark_held_locks+0x4e/0x66
  [] trace_hardirqs_on+0xfe/0x136
  [] _spin_unlock_irq+0x22/0x42
  [] nv_start_xmit_optimized+0x347/0x37a
  [] netpoll_send_skb+0xa4/0x147
  [] netpoll_send_udp+0x238/0x242
  [] write_msg+0x6d/0x9b
  [] __call_console_drivers+0x4e/0x5a
  [] _call_console_drivers+0x57/0x5b
  [] release_console_sem+0x11c/0x1b9
  [] register_console+0x1eb/0x1f3
  [] init_netconsole+0x119/0x15f
  [] kernel_init+0x147/0x294
  [] kernel_thread_helper+0x7/0x10
  [] 0xffffffff
irq event stamp: 950
hardirqs last  enabled at (950): [] _spin_unlock_irq+0x22/0x42
hardirqs last disabled at (949): [] _spin_lock_irq+0xc/0x38
softirqs last  enabled at (0): [] copy_process+0x375/0x126d
softirqs last disabled at (947): [] do_softirq+0x61/0xc6

other info that might help us debug this:
no locks held by udevd/719.

stack backtrace:
Pid: 719, comm: udevd Not tainted 2.6.24-rc6 #6
 [] show_trace_log_lvl+0x12/0x25
 [] show_trace+0xd/0x10
 [] dump_stack+0x57/0x5f
 [] print_usage_bug+0x10a/0x117
 [] mark_lock+0x121/0x402
 [] __lock_acquire+0x3d1/0xb64
 [] lock_acquire+0x4e/0x6a
 [] _spin_lock+0x23/0x32
 [] dev_watchdog+0x1c/0xb9
 [] run_timer_softirq+0x133/0x193
 [] __do_softirq+0x78/0xed
 [] do_softirq+0x61/0xc6
 =======================
eth1: link down

The fix is to disable/restore irqs instead of disable/enable.

Signed-off-by: Ingo Molnar 
Cc: Ayaz Abdulla 
Cc: Jeff Garzik 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

forcedeth: limit tx to 16

2008-03-17T12:11:07+00:00

This is a critical patch which adds a workaround for a HW bug. The patch
will limit the number of outstanding tx packets to 16. Otherwise, the HW
could send out packets with bad checksums.

The driver will still setup the tx packets into the ring, however, will
only set the Valid bit on 16 packets at a time.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik

forcedeth: tx pause watermarks

2008-02-11T16:13:47+00:00

New chipsets introduced variant Rx FIFO sizes that need to be taken into
account when setting up the tx pause watermarks. This patch introduces
the new device feature flags based on a version and implements the new
watermarks.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik

forcedeth: tx collision fix

2008-02-11T16:13:43+00:00

This patch supports a new fix in hardware regarding tx collisions. In
the cases where we are in autoneg mode and the link partner is in forced
mode, we need to setup the tx deferral register differently in order to
reduce collisions on the wire.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik

forcedeth: preserve registers

2008-02-06T11:42:02+00:00

Various registers need to be preserved before resetting the device.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik

forcedeth: phy status fix

2008-02-06T11:41:45+00:00

The driver needs to ack only the phy status bits that it is currently
handling and preserve the other bits for the other handlers. For
example, when reading/writing from the phy, it should not clear the link
change interrupt bit. This will cause a missing link change interrupt.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik

forcedeth: restart tx/rx

2008-02-06T11:41:14+00:00

This patch fixes the issue where the transmitter and receiver must be
restarted when applying new changes to certain registers.

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik

forcedeth: mac address mcp77/79

2008-02-03T12:28:40+00:00

This patch is a critical fix for MCP77 and MCP79 devices. The feature
flags were missing the define for correct mac address
(DEV_HAS_CORRECT_MACADDR).

Signed-off-by: Ayaz Abdulla 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller