linux.git/drivers/net/fec.c, branch v2.6.34

FEC: Fix kernel panic in fec_set_mac_address.

2010-05-05T07:55:48+00:00

Fix memory corruption that sometimes result in kernel panic.

Signed-off-by: Mattias Walström 
Signed-off-by: David S. Miller

net: convert multiple drivers to use netdev_for_each_mc_addr, part4

2010-02-22T23:45:52+00:00

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: use netdev_mc_count and netdev_mc_empty when appropriate

2010-02-12T19:38:58+00:00

This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
anything). Used spatch and did small tweaks and conding style changes when
it was suitable.

Jirka

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

fec: Add LAN8700 phy support

2010-02-10T21:05:42+00:00

The i.MX51 babbage board has a FEC ethernet controller with this phy.

In the long term we should resurrect the phylib patches for fec.

Signed-off-by: Amit Kucheria 
Acked-by: Grant Likely 
Signed-off-by: David S. Miller

fec: fix uninitialized rx buffer usage

2010-02-10T21:05:42+00:00

The fec driver was enabling receive buffer descriptor without allocating
the buffers. Make sure the buffer descriptors are initialized to not
start receiving packets.

Open also calls fec_restart after the rx buffers are allocated. With the code
in fec_restart, it zeroes out the buffer descriptors that have just been
setup.

Signed-off-by: Rob Herring 
Signed-off-by: Amit Kucheria 
Acked-by: Grant Likely 
Acked-by: Greg Ungerer 
Signed-off-by: David S. Miller

net: fix section mismatch in fec.c

2009-10-21T01:51:37+00:00

fec_enet_init is called by both fec_probe and fec_resume, so it
shouldn't be marked as __init.

Signed-off-by: Steven King 
Signed-off-by: David S. Miller

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu

2009-09-17T16:52:43+00:00

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu: (53 commits)
  m68knommu: Make PAGE_SIZE available to assembly files.
  m68knommu: fix ColdFire definition of CLOCK_TICK_RATE
  m68knommu: set multi-function pins for ethernet when enabled
  m68knommu: remove special interrupt handling code for ne2k support
  m68knommu: relax IO_SPACE_LIMIT setting
  m68knommu: remove ColdFire direct interrupt register access
  m68knommu: create a speciailized ColdFire 5272 interrupt controller
  m68knommu: add support for second interrupt controller of ColdFire 5249
  m68knommu: clean up old ColdFire timer irq setup
  m68knommu: map ColdFire interrupts to correct masking bits
  m68knommu: clean up ColdFire 532x CPU timer setup
  m68knommu: simplify ColdFire "timers" clock initialization
  m68knommu: support code to mask external interrupts on old ColdFire CPU's
  m68knommu: merge old ColdFire interrupt controller masking macros
  m68knommu: remove duplicate ColdFire mcf_autovector() code
  m68knommu: move ColdFire INTC definitions to new include file
  m68knommu: mask off all interrupts in ColdFire intc-simr controller
  m68knommu: remove timer device interrupt setup for ColdFire 532x
  m68knommu: remove interrupt masking from ColdFire pit timer
  m68knommu: remove unecessary interrupt level setting in ColdFire 520x setup
  ...

m68knommu: remove ColdFire direct interrupt register access

2009-09-15T23:43:54+00:00

Now that the ColdFire 5272 has full interrupt controller functionality
we can remove all the interrupt masking and acking code from the FEC
ethernet driver.

Signed-off-by: Greg Ungerer

fec: don't enable irqs in hard irq context

2009-09-03T06:46:06+00:00

fec_enet_mii, fec_enet_rx and fec_enet_tx are both only called by
fec_enet_interrupt in interrupt context.  So they must not use
spin_lock_irq/spin_unlock_irq.

This fixes:
	WARNING: at kernel/lockdep.c:2140 trace_hardirqs_on_caller+0x130/0x194()
	...

Signed-off-by: Uwe Kleine-König 
Cc: Greg Ungerer 
Cc: Ben Hutchings 
Cc: Patrick McHardy 
Cc: Sascha Hauer 
Cc: Matt Waddel 
Cc: netdev@vger.kernel.org
Cc: Tim Sander 
Acked-by: Greg Ungerer 
Signed-off-by: David S. Miller

fec: fix recursive locking of mii_lock

2009-09-03T06:46:03+00:00

mii_discover_phy is only called by fec_enet_mii (via mip->mii_func).  So
&fep->mii_lock is already held and mii_discover_phy must not call
mii_queue which locks &fep->mii_lock, too.

This was noticed by lockdep:

	=============================================
	[ INFO: possible recursive locking detected ]
	2.6.31-rc8-00038-g37d0892 #109
	---------------------------------------------
	swapper/1 is trying to acquire lock:
	 (&fep->mii_lock){-.....}, at: [] mii_queue+0x2c/0xcc

	but task is already holding lock:
	 (&fep->mii_lock){-.....}, at: [] fec_enet_interrupt+0x78/0x460

	other info that might help us debug this:
	2 locks held by swapper/1:
	 #0:  (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x18/0x20
	 #1:  (&fep->mii_lock){-.....}, at: [] fec_enet_interrupt+0x78/0x460

	stack backtrace:
	Backtrace:
	[] (dump_backtrace+0x0/0x108) from [] (dump_stack+0x18/0x1c)
	 r6:c781d118 r5:c03e41d8 r4:00000001
	[] (dump_stack+0x0/0x1c) from [] (__lock_acquire+0x1a20/0x1a88)
	[] (__lock_acquire+0x0/0x1a88) from [] (lock_acquire+0x60/0x74)
	[] (lock_acquire+0x0/0x74) from [] (_spin_lock_irqsave+0x54/0x68)
	 r7:60000093 r6:c01569f8 r5:c785e468 r4:00000000
	[] (_spin_lock_irqsave+0x0/0x68) from [] (mii_queue+0x2c/0xcc)
	 r7:c785e468 r6:c0156b24 r5:600a0000 r4:c785e000
	[] (mii_queue+0x0/0xcc) from [] (mii_discover_phy+0x54/0xa8)
	 r8:00000002 r7:00000032 r6:c785e000 r5:c785e360 r4:c785e000
	[] (mii_discover_phy+0x0/0xa8) from [] (fec_enet_interrupt+0xa4/0x460)
	 r5:c785e360 r4:c077a170
	[] (fec_enet_interrupt+0x0/0x460) from [] (handle_IRQ_event+0x48/0x120)
	[] (handle_IRQ_event+0x0/0x120) from [] (handle_level_irq+0x94/0x11c)
	...

Signed-off-by: Uwe Kleine-König 
Cc: Greg Ungerer 
Cc: Ben Hutchings 
Cc: Patrick McHardy 
Cc: Sascha Hauer 
Cc: Matt Waddel 
Cc: netdev@vger.kernel.org
Cc: Tim Sander 
Acked-by: Greg Ungerer 
Signed-off-by: David S. Miller