linux.git/drivers/net/ethoc.c, branch v2.6.37 Linux kernel source tree ethoc: get rid of ethoc_stats() 2010-08-24T19:23:01+00:00 Eric Dumazet eric.dumazet@gmail.com 2010-08-24T19:23:01+00:00 6abc2376809497b04feee554240e158ac2072587 drivers can avoid implementing ndo_get_stats method if using netdevice stats structure. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
drivers can avoid implementing ndo_get_stats method if using netdevice
stats structure.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: add devinit/devexit section initializers 2010-07-27T01:45:05+00:00 Jonas Bonn jonas@southpole.se 2010-07-27T01:45:05+00:00 f78f09f76540c9a986bc321a186a291f4bb40925 Signed-off-by: Jonas Bonn <jonas@southpole.se> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: preserve ifreq parameter when calling generic phy_mii_ioctl(). 2010-07-19T02:15:25+00:00 Richard Cochran richardcochran@gmail.com 2010-07-17T08:48:55+00:00 28b041139e344ecd0f144d6205b004ae354cfa1e The phy_mii_ioctl() function unnecessarily throws away the original ifreq. We need access to the ifreq in order to support PHYs that can perform hardware time stamping. Two maverick drivers filter the ioctl commands passed to phy_mii_ioctl(). This is unnecessary since phylib will check the command in any case. Signed-off-by: Richard Cochran <richard.cochran@omicron.at> Signed-off-by: David S. Miller <davem@davemloft.net> 
The phy_mii_ioctl() function unnecessarily throws away the original ifreq.
We need access to the ifreq in order to support PHYs that can perform
hardware time stamping.

Two maverick drivers filter the ioctl commands passed to phy_mii_ioctl().
This is unnecessary since phylib will check the command in any case.

Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: Fix warning in ethoc_init_ring(). 2010-07-08T01:23:19+00:00 David S. Miller davem@davemloft.net 2010-07-08T01:23:19+00:00 5cf3e03457aa905f17f9765702850316b69aad1e Get rid of the pointless back-and-forth casting of dev->mem_start from long to pointer back to long again. Also fixes a warning reported by Stephen Rothwell: drivers/net/ethoc.c: In function 'ethoc_init_ring': drivers/net/ethoc.c:302: warning: assignment makes integer from pointer without a cast Signed-off-by: David S. Miller <davem@davemloft.net> 
Get rid of the pointless back-and-forth casting of dev->mem_start
from long to pointer back to long again.

Also fixes a warning reported by Stephen Rothwell:

drivers/net/ethoc.c: In function 'ethoc_init_ring':
drivers/net/ethoc.c:302: warning: assignment makes integer from pointer without a cast

Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: Use the instance of net_device_stats from net_device. 2010-07-06T02:41:13+00:00 Kulikov Vasiliy segooon@gmail.com 2010-07-05T02:13:31+00:00 57616ee4405b82c3ba4d20111697a4416f3967a6 Since net_device has an instance of net_device_stats, we can remove the instance of this from the adapter structure. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Since net_device has an instance of net_device_stats,
we can remove the instance of this from the adapter structure.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: use devres resource management 2010-06-11T20:28:37+00:00 Jonas Bonn jonas@southpole.se 2010-06-11T02:47:40+00:00 a71fba97295db924c0b90266e9833e5059fead24 The point of using the devres resource management routines is that they simplify the driver by taking care of releasing resources on failure and release. A recent commit added a bunch of error handling that is unnecessary in this context. This patch removes this redundant error handling, as well as using dmam_alloc_coherent in place of dma_alloc_coherent in order to use this framework consistenly throughout the driver. Signed-off-by: Jonas Bonn <jonas@southpole.se> Signed-off-by: David S. Miller <davem@davemloft.net> 
The point of using the devres resource management routines is that they
simplify the driver by taking care of releasing resources on failure and
release.  A recent commit added a bunch of error handling that is unnecessary
in this context.

This patch removes this redundant error handling, as well as using
dmam_alloc_coherent in place of dma_alloc_coherent in order to use this
framework consistenly throughout the driver.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: Clear command buffer after write 2010-06-11T20:28:36+00:00 Jonas Bonn jonas@southpole.se 2010-06-11T02:47:39+00:00 b46773db64c264a6600f58d9da1ae43708b47fda This matches what ethoc_mdio_read does and makes the functions symmetric. Signed-off-by: Jonas Bonn <jonas@southpole.se> Signed-off-by: David S. Miller <davem@davemloft.net> 
This matches what ethoc_mdio_read does and makes the functions
symmetric.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
Remove unused variable 2010-06-11T20:28:36+00:00 Jonas Bonn jonas@southpole.se 2010-06-11T02:47:38+00:00 2cbc8ef9facf60afa62e04bde91fb5fcac9a5683 Signed-off-by: Jonas Bonn <jonas@southpole.se> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: Clean up PHY probing 2010-06-11T20:28:35+00:00 Jonas Bonn jonas@southpole.se 2010-06-11T02:47:37+00:00 637f33b80d774060646772a22fd728e198d9ebf9 - No need to iterate over all possible addresses on bus - Use helper function phy_find_first - Use phy_connect_direct as we already have the relevant structure Signed-off-by: Jonas Bonn <jonas@southpole.se> Signed-off-by: David S. Miller <davem@davemloft.net> 
- No need to iterate over all possible addresses on bus
- Use helper function phy_find_first
- Use phy_connect_direct as we already have the relevant structure

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
ethoc: write number of TX buffers in init_ring 2010-06-11T20:28:35+00:00 Jonas Bonn jonas@southpole.se 2010-06-11T02:47:36+00:00 ee4f56b990391f0ea333121ebc0e9fba28619b52 This moves the write of the TX_BD_NUM to init_ring together with the rest of the code setting up the transmission buffers. Signed-off-by: Jonas Bonn <jonas@southpole.se> Signed-off-by: David S. Miller <davem@davemloft.net> 
This moves the write of the TX_BD_NUM to init_ring together with the
rest of the code setting up the transmission buffers.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>