linux.git/drivers/net/ethernet/netronome/nfp/devlink_param.c, branch master

devlink: pass extack through to devlink_param::get()

2025-11-21T03:01:22+00:00

Allow devlink_param::get() handlers to report error messages via
extack. This function is called in a few different contexts, but not
all of them will have an valid extack to use.

When devlink_param::get() is called from param_get_doit or
param_get_dumpit contexts, pass the extack through so that drivers can
report errors when retrieving param values. devlink_param::get() is
called from the context of devlink_param_notify(), pass NULL in for
the extack.

Reviewed-by: Saeed Mahameed 
Reviewed-by: Aleksandr Loktionov 
Signed-off-by: Daniel Zahka 
Link: https://patch.msgid.link/20251119025038.651131-2-daniel.zahka@gmail.com
Signed-off-by: Jakub Kicinski

devlink: extend devlink_param *set pointer

2024-04-22T20:05:19+00:00

Extend devlink_param *set function pointer to take extack as a param.
Sometimes it is needed to pass information to the end user from set
function. It is more proper to use for that netlink instead of passing
message to dmesg.

Reviewed-by: Jiri Pirko 
Reviewed-by: Przemek Kitszel 
Signed-off-by: Mateusz Polchlopek 
Signed-off-by: Tony Nguyen

devlink: protect devlink param list by instance lock

2023-01-27T12:32:02+00:00

Commit 1d18bb1a4ddd ("devlink: allow registering parameters after
the instance") as the subject implies introduced possibility to register
devlink params even for already registered devlink instance. This is a
bit problematic, as the consistency or params list was originally
secured by the fact it is static during devlink lifetime. So in order to
protect the params list, take devlink instance lock during the params
operations. Introduce unlocked function variants and use them in drivers
in locked context. Put lock assertions to appropriate places.

Signed-off-by: Jiri Pirko 
Reviewed-by: Jakub Kicinski 
Reviewed-by: Jacob Keller 
Reviewed-by: Ido Schimmel 
Reviewed-by: Simon Horman 
Tested-by: Simon Horman 
Signed-off-by: David S. Miller

nfp: Move delink_register to be last command

2021-09-27T15:31:59+00:00

Open user space access to the devlink after driver is probed.

Signed-off-by: Leon Romanovsky 
Signed-off-by: David S. Miller

nfp: devlink: set unknown fw_load_policy

2019-09-11T14:10:05+00:00

If the 'app_fw_from_flash' HWinfo key is invalid, set the
'fw_load_policy' devlink parameter value to unknown.

Suggested-by: Jakub Kicinski 
Signed-off-by: Dirk van der Merwe 
Signed-off-by: Simon Horman 
Signed-off-by: David S. Miller

nfp: devlink: add 'reset_dev_on_drv_probe' support

2019-09-10T16:29:27+00:00

Add support for the 'reset_dev_on_drv_probe' devlink parameter. The
reset control policy is controlled by the 'abi_drv_reset' hwinfo key.

Signed-off-by: Dirk van der Merwe 
Signed-off-by: Jakub Kicinski 
Signed-off-by: Simon Horman 
Signed-off-by: David S. Miller

nfp: devlink: add 'fw_load_policy' support

2019-09-10T16:29:27+00:00

Add support for the 'fw_load_policy' devlink parameter. The FW load
policy is controlled by the 'app_fw_from_flash' hwinfo key.

Remap the values from devlink to the hwinfo key and back.

Signed-off-by: Dirk van der Merwe 
Signed-off-by: Jakub Kicinski 
Signed-off-by: Simon Horman 
Signed-off-by: David S. Miller

nfp: add devlink param infrastructure

2019-09-10T16:29:27+00:00

Register devlink parameters for driver use. Subsequent patches will add
support for specific parameters.

In order to support devlink parameters, the management firmware needs to
be able to lookup and set hwinfo keys.

Signed-off-by: Dirk van der Merwe 
Signed-off-by: Jakub Kicinski 
Signed-off-by: Simon Horman 
Signed-off-by: David S. Miller