linux.git/drivers/net/ethernet/mediatek, branch v6.7

net: ethernet: mtk_wed: fix possible NULL pointer dereference in mtk_wed_wo_queue_tx_clean()

2023-12-21T07:09:22+00:00

In order to avoid a NULL pointer dereference, check entry->buf pointer before running
skb_free_frag in mtk_wed_wo_queue_tx_clean routine.

Fixes: 799684448e3e ("net: ethernet: mtk_wed: introduce wed wo support")
Signed-off-by: Lorenzo Bianconi 
Reviewed-by: Simon Horman 
Link: https://lore.kernel.org/r/3c1262464d215faa8acebfc08869798c81c96f4a.1702827359.git.lorenzo@kernel.org
Signed-off-by: Paolo Abeni

net: ethernet: mtk_wed: remove wo pointer in wo_r32/wo_w32 signature

2023-10-25T00:08:46+00:00

wo pointer is no longer used in wo_r32 and wo_w32 routines so get rid of
it.

Signed-off-by: Lorenzo Bianconi 
Link: https://lore.kernel.org/r/530537db0872f7523deff21f0a5dfdd9b75fdc9d.1698098459.git.lorenzo@kernel.org
Signed-off-by: Jakub Kicinski

net: ethernet: mtk_wed: fix firmware loading for MT7986 SoC

2023-10-25T00:05:11+00:00

The WED mcu firmware does not contain all the memory regions defined in
the dts reserved_memory node (e.g. MT7986 WED firmware does not contain
cpu-boot region).
Reverse the mtk_wed_mcu_run_firmware() logic to check all the fw
sections are defined in the dts reserved_memory node.

Fixes: c6d961aeaa77 ("net: ethernet: mtk_wed: move mem_region array out of mtk_wed_mcu_load_firmware")
Tested-by: Frank Wunderlich 
Signed-off-by: Lorenzo Bianconi 
Reviewed-by: Jacob Keller 
Link: https://lore.kernel.org/r/d983cbfe8ea562fef9264de8f0c501f7d5705bd5.1698098381.git.lorenzo@kernel.org
Signed-off-by: Jakub Kicinski

net: dsa: Use conduit and user terms

2023-10-24T20:08:14+00:00

Use more inclusive terms throughout the DSA subsystem by moving away
from "master" which is replaced by "conduit" and "slave" which is
replaced by "user". No functional changes.

Acked-by: Rob Herring 
Acked-by: Stephen Hemminger 
Reviewed-by: Vladimir Oltean 
Signed-off-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20231023181729.1191071-2-florian.fainelli@broadcom.com
Signed-off-by: Jakub Kicinski

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2023-10-05T20:16:47+00:00

Cross-merge networking fixes after downstream PR.

No conflicts (or adjacent changes of note).

Signed-off-by: Jakub Kicinski

net: ethernet: mediatek: disable irq before schedule napi

2023-10-05T11:36:12+00:00

While searching for possible refactor of napi_schedule_prep and
__napi_schedule it was notice that the mtk eth driver disable the
interrupt for rx and tx AFTER napi is scheduled.

While this is a very hard to repro case it might happen to have
situation where the interrupt is disabled and never enabled again as the
napi completes and the interrupt is enabled before.

This is caused by the fact that a napi driven by interrupt expect a
logic with:
1. interrupt received. napi prepared -> interrupt disabled -> napi
   scheduled
2. napi triggered. ring cleared -> interrupt enabled -> wait for new
   interrupt

To prevent this case, disable the interrupt BEFORE the napi is
scheduled.

Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi 
Link: https://lore.kernel.org/r/20231002140805.568-1-ansuelsmth@gmail.com
Signed-off-by: Paolo Abeni

net: Tree wide: Replace xdp_do_flush_map() with xdp_do_flush().

2023-10-03T14:34:51+00:00

xdp_do_flush_map() is deprecated and new code should use xdp_do_flush()
instead.

Replace xdp_do_flush_map() with xdp_do_flush().

Cc: AngeloGioacchino Del Regno 
Cc: Clark Wang 
Cc: Claudiu Manoil 
Cc: David Arinzon 
Cc: Edward Cree 
Cc: Felix Fietkau 
Cc: Grygorii Strashko 
Cc: Jassi Brar 
Cc: Jesse Brandeburg 
Cc: John Crispin 
Cc: Leon Romanovsky 
Cc: Lorenzo Bianconi 
Cc: Louis Peens 
Cc: Marcin Wojtas 
Cc: Mark Lee 
Cc: Matthias Brugger 
Cc: NXP Linux Team 
Cc: Noam Dagan 
Cc: Russell King 
Cc: Saeed Bishara 
Cc: Saeed Mahameed 
Cc: Sean Wang 
Cc: Shay Agroskin 
Cc: Shenwei Wang 
Cc: Thomas Petazzoni 
Cc: Tony Nguyen 
Cc: Vladimir Oltean 
Cc: Wei Fang 
Signed-off-by: Sebastian Andrzej Siewior 
Acked-by: Arthur Kiyanovski 
Acked-by: Toke Høiland-Jørgensen 
Acked-by: Ilias Apalodimas 
Acked-by: Martin Habets 
Acked-by: Jesper Dangaard Brouer 
Link: https://lore.kernel.org/r/20230908143215.869913-2-bigeasy@linutronix.de
Signed-off-by: Jakub Kicinski

net: ethernet: mediatek: Convert to platform remove callback returning void

2023-09-20T08:06:39+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: David S. Miller

net: ethernet: mtk_wed: add wed 3.0 reset support

2023-09-19T16:27:56+00:00

Introduce support for resetting Wireless Ethernet Dispatcher 3.0
available on MT988 SoC.

Co-developed-by: Lorenzo Bianconi 
Signed-off-by: Lorenzo Bianconi 
Signed-off-by: Sujuan Chen 
Signed-off-by: Paolo Abeni

net: ethernet: mtk_wed: debugfs: add WED 3.0 debugfs entries

2023-09-19T16:27:56+00:00

Introduce WED3.0 debugfs entries useful for debugging.

Co-developed-by: Lorenzo Bianconi 
Signed-off-by: Lorenzo Bianconi 
Signed-off-by: Sujuan Chen 
Signed-off-by: Paolo Abeni