linux.git/drivers/net/ethernet/litex, branch v6.7

net: ethernet: litex: Convert to platform remove callback returning void

2023-09-20T08:06:39+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Acked-by: Gabriel Somlo 
Signed-off-by: David S. Miller

net: ethernet: litex: add support for 64 bit stats

2023-06-16T05:56:46+00:00

Implement 64 bit per cpu stats to fix the overflow of netdev->stats
on 32 bit platforms. To simplify the code, we use net core
pcpu_sw_netstats infrastructure. One small drawback is some memory
overhead because litex uses just one queue, but we allocate the
counters per cpu.

Signed-off-by: Jisheng Zhang 
Reviewed-by: Simon Horman 
Acked-by: Gabriel Somlo 
Link: https://lore.kernel.org/r/20230614162035.300-1-jszhang@kernel.org
Signed-off-by: Jakub Kicinski

net: ethernet: litex: Fix return type of liteeth_start_xmit

2022-09-20T01:23:39+00:00

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of liteeth_start_xmit should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter 
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry 
Reviewed-by: Nathan Chancellor 
Acked-by: Gabriel Somlo 
Link: https://lore.kernel.org/r/20220912195307.812229-1-nhuck@google.com
Signed-off-by: Jakub Kicinski

net: ethernet: litex: Add the dependency on HAS_IOMEM

2022-02-09T04:43:40+00:00

The LiteX driver uses devm io function API which
needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.

Fixes: ee7da21ac4c3 ("net: Add driver for LiteX's LiteETH network interface")
Signed-off-by: Cai Huoqing 
Link: https://lore.kernel.org/r/20220208013308.6563-1-cai.huoqing@linux.dev
Signed-off-by: Jakub Kicinski

litex_liteeth: Fix a double free in the remove function

2021-11-07T21:51:17+00:00

'netdev' is a managed resource allocated in the probe using
'devm_alloc_etherdev()'.
It must not be freed explicitly in the remove function.

Fixes: ee7da21ac4c3 ("net: Add driver for LiteX's LiteETH network interface")
Signed-off-by: Christophe JAILLET 
Signed-off-by: David S. Miller

net: ethernet: litex: Remove unnecessary print function dev_err()

2021-11-05T10:16:12+00:00

The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: Xu Wang 
Reviewed-by: Cai Huoqing 
Signed-off-by: David S. Miller

ethernet: use of_get_ethdev_address()

2021-10-07T12:39:51+00:00

Use the new of_get_ethdev_address() helper for the cases
where dev->dev_addr is passed in directly as the destination.

  @@
  expression dev, np;
  @@
  - of_get_mac_address(np, dev->dev_addr)
  + of_get_ethdev_address(np, dev)

Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

of: net: move of_net under net/

2021-10-07T12:39:51+00:00

Rob suggests to move of_net.c from under drivers/of/ somewhere
to the networking code.

Suggested-by: Rob Herring 
Signed-off-by: Jakub Kicinski 
Reviewed-by: Rob Herring 
Signed-off-by: David S. Miller

net: Add depends on OF_NET for LiteX's LiteETH

2021-08-31T15:36:38+00:00

Current settings may produce a build error when
CONFIG_OF_NET is disabled. The CONFIG_OF_NET controls
a headfile  and some functions
 in .

Signed-off-by: Slark Xiao 
Signed-off-by: Jakub Kicinski

net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()

2021-08-31T11:08:05+00:00

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing 
Signed-off-by: David S. Miller