linux.git/drivers/net/ethernet/google, branch v6.9

net: introduce page_frag_cache_drain()

2024-03-05T10:38:14+00:00

When draining a page_frag_cache, most user are doing
the similar steps, so introduce an API to avoid code
duplication.

Signed-off-by: Yunsheng Lin 
Acked-by: Jason Wang 
Reviewed-by: Alexander Duyck 
Acked-by: Michael S. Tsirkin 
Signed-off-by: Paolo Abeni

gve: Add header split ethtool stats

2024-03-04T10:03:32+00:00

To record the stats of header split packets, three stats are added in
the driver's ethtool stats.

- rx_hsplit_pkt is the split packets count with header split
- rx_hsplit_bytes is the received header bytes count with header split
- rx_hsplit_unsplit_pkt is the unsplit packet count due to header buffer
  overflow or zero header length when header split is enabled

Currently, it's entering the stats_update critical section more than
once per packet. We have plans to avoid that in the future change to let
all the stats_update happen in one place at the end of
`gve_rx_poll_dqo`.

Co-developed-by: Ziwei Xiao 
Signed-off-by: Ziwei Xiao 
Signed-off-by: Jeroen de Borst 
Reviewed-by: Praveen Kaligineedi 
Reviewed-by: Harshitha Ramamurthy 
Reviewed-by: Willem de Bruijn 
Signed-off-by: David S. Miller

gve: Add header split data path

2024-03-04T10:03:32+00:00

Add header buffers and ethtool support to enable header split via the
tcp-data-split flag in ethtool's ringparam config. A coherent dma memory
is allocated for the header buffers. There is one header buffer per ring
entry by calculating the offset to the header-buffers starting address.
The header buffer is always copied directly into the skb and payload is
always added as frags. When there is a header buffer overflow or the
header length is 0, the driver places the whole unsplit packet in frags.

When toggling header split, the driver will call gve_adjust_config to
set its queues appropriately. If header split is enabled by the user and
the max packet buffer size is no less than 4KB, driver will set the
packet buffer size as 4KB to support TCP_ZEROCOPY_RECEIVE. Otherwise the
driver will use the default 2KB as the packet buffer size.

`ethtool -G  tcp-data-split on/off` is the command to toggle header
split.
`ethtool -g ` will show the status of header split with the field
of `tcp-data-split`.

Co-developed-by: Ziwei Xiao 
Signed-off-by: Ziwei Xiao 
Signed-off-by: Jeroen de Borst 
Reviewed-by: Praveen Kaligineedi 
Reviewed-by: Harshitha Ramamurthy 
Reviewed-by: Willem de Bruijn 
Signed-off-by: David S. Miller

gve: Add header split device option

2024-03-04T10:03:31+00:00

To enable header split via ethtool, we first need to query the device to
get the max rx buffer size and header buffer size. Add a device option
to get these values and store them in the driver. If the header buffer
size received from the device is non-zero, it means header split is
supported in the device.

Currently the max rx buffer size will only be used when header split is
enabled which will set the data_buffer_size_dqo to be the max rx buffer
size. Also change the data_buffer_size_dqo from int to u16 since we are
modifying it and making it to be consistent with max_rx_buffer_size.

Co-developed-by: Ziwei Xiao 
Signed-off-by: Ziwei Xiao 
Signed-off-by: Jeroen de Borst 
Reviewed-by: Praveen Kaligineedi 
Reviewed-by: Harshitha Ramamurthy 
Reviewed-by: Willem de Bruijn 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2024-02-01T23:12:37+00:00

Cross-merge networking fixes after downstream PR.

No conflicts or adjacent changes.

Signed-off-by: Jakub Kicinski

gve: Modify rx_buf_alloc_fail counter centrally and closer to failure

2024-01-26T01:18:56+00:00

Previously, each caller of gve_rx_alloc_buffer had to increase counter
 and as a result one caller was not tracking those failure. Increasing
 counters at a common location now so callers don't have to duplicate
 code or miss counter management.

Signed-off-by: Ankit Garg 
Link: https://lore.kernel.org/r/20240124205435.1021490-1-nktgrg@google.com
Signed-off-by: Jakub Kicinski

gve: Fix skb truesize underestimation

2024-01-26T01:08:34+00:00

For a skb frag with a newly allocated copy page, the true size is
incorrectly set to packet buffer size. It should be set to PAGE_SIZE
instead.

Fixes: 82fd151d38d9 ("gve: Reduce alloc and copy costs in the GQ rx path")
Signed-off-by: Praveen Kaligineedi 
Link: https://lore.kernel.org/r/20240124161025.1819836-1-pkaligineedi@google.com
Signed-off-by: Jakub Kicinski

gve: Alloc before freeing when changing features

2024-01-24T01:41:31+00:00

Previously, existing queues were being freed before the resources for
the new queues were being allocated. This would take down the interface
if someone were to attempt to change feature flags under a resource
crunch.

Signed-off-by: Shailend Chand 
Reviewed-by: Willem de Bruijn 
Reviewed-by: Jeroen de Borst 
Link: https://lore.kernel.org/r/20240122182632.1102721-7-shailend@google.com
Signed-off-by: Jakub Kicinski

gve: Alloc before freeing when adjusting queues

2024-01-24T01:41:31+00:00

Previously, existing queues were being freed before the resources for
the new queues were being allocated. This would take down the interface
if someone were to attempt to change queue counts under a resource
crunch.

Signed-off-by: Shailend Chand 
Reviewed-by: Willem de Bruijn 
Reviewed-by: Jeroen de Borst 
Link: https://lore.kernel.org/r/20240122182632.1102721-6-shailend@google.com
Signed-off-by: Jakub Kicinski

gve: Refactor gve_open and gve_close

2024-01-24T01:41:31+00:00

gve_open is rewritten to be composed of two funcs: gve_queues_mem_alloc
and gve_queues_start. The former only allocates queue resources without
doing anything to install the queues, which is taken up by the latter.
Similarly gve_close is split into gve_queues_stop and
gve_queues_mem_free.

Separating the acts of queue resource allocation and making the queue
become live help with subsequent changes that aim to not take down the
datapath when applying new configurations.

Signed-off-by: Shailend Chand 
Reviewed-by: Willem de Bruijn 
Reviewed-by: Jeroen de Borst 
Link: https://lore.kernel.org/r/20240122182632.1102721-5-shailend@google.com
Signed-off-by: Jakub Kicinski