linux.git/drivers/net/ethernet/dec, branch v3.19

uli526x: fix misspelling of current function in string

2014-12-09T21:18:46+00:00

Replace a misspelled function name by %s and then __func__.

This was done using Coccinelle, including the use of Levenshtein distance,
as proposed by Rasmus Villemoes.

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

dmfe: fix misspelling of current function in string

2014-12-09T21:18:46+00:00

The function name contains cleanup, not clean.

This was done using Coccinelle, including the use of Levenshtein distance,
as proposed by Rasmus Villemoes.

Signed-off-by: Julia Lawall 
Acked-by: Grant Grundler 
Signed-off-by: David S. Miller

net: tulip: Remove private "strncmp"

2014-12-09T18:45:29+00:00

The comment says that the built-in strncmp didn't work. That is not
surprising, as apparently "str" semantics are not really what is
wanted (hint: de4x5_strncmp only stops when two different bytes are
encountered or the end is reached; not if either byte happens to be
0). de4x5_strncmp is actually a memcmp (except for the signature and
that bytes are not necessarily treated as unsigned char); since only
the boolean value of the result is used we can just replace
de4x5_strncmp with memcmp.

Signed-off-by: Rasmus Villemoes 
Acked-by: Grant Grundler 
Signed-off-by: David S. Miller

tulip: dmfe: Fix global namespace pollution of phy accessors.

2014-08-28T01:25:40+00:00

The dmfe driver has "phy_read()" and "phy_write()" functions, which
we need to rename because the generic phy layer is about to export
generic interfaces with the same name.

Signed-off-by: David S. Miller

PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

2014-08-12T18:15:14+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines.  This issue was reported by checkpatch.

A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):

// 

@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@

- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;

// 

[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine 
Signed-off-by: Bjorn Helgaas

net: tulip: remove unnecessary break after return

2014-07-21T04:30:18+00:00

Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

tulip: Poll link status more frequently for Comet chips

2014-06-23T00:12:36+00:00

It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips.
That's too slow and might cause people to think that it doesn't work at all.

Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
That should be fast enough while not stressing the system too much.

Tested with ADMtek AN983B.

Signed-off-by: Ondrej Zary 
Signed-off-by: David S. Miller

net: use SPEED_UNKNOWN and DUPLEX_UNKNOWN when appropriate

2014-06-06T23:24:07+00:00

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: get rid of SET_ETHTOOL_OPS

2014-05-13T21:43:20+00:00

net: get rid of SET_ETHTOOL_OPS

Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
This does that.

Mostly done via coccinelle script:
@@
struct ethtool_ops *ops;
struct net_device *dev;
@@
-       SET_ETHTOOL_OPS(dev, ops);
+       dev->ethtool_ops = ops;

Compile tested only, but I'd seriously wonder if this broke anything.

Suggested-by: Dave Miller 
Signed-off-by: Wilfried Klaebe 
Acked-by: Felipe Balbi 
Signed-off-by: David S. Miller

uli526x: Call dev_kfree/consume_skb_any instead of dev_kfree_skb.

2014-03-25T04:19:00+00:00

Replace dev_kfree_skb with dev_kfree_skb_any in uli562x_start_xmit
that can be called in hard irq and other contexts, when the packet is
dropped.

Replace dev_kfree_skb with dev_consume_skb_any in uli562x_start_xmit
that can be called in hard irq and other contexts, when the packet is
transmitted.

Signed-off-by: "Eric W. Biederman"