linux.git/drivers/net/ethernet/broadcom, branch v4.15

bnxt_en: Fix the 'Invalid VF' id check in bnxt_vf_ndo_prep routine.

2018-01-08T19:13:45+00:00

In bnxt_vf_ndo_prep (which is called by bnxt_get_vf_config ndo), there is a
check for "Invalid VF id". Currently, the check is done against max_vfs.
However, the user doesn't always create max_vfs. So, the check should be
against the created number of VFs. The number of bnxt_vf_info structures
that are allocated in bnxt_alloc_vf_resources routine is the "number of
requested VFs". So, if an "invalid VF id" falls between the requested
number of VFs and the max_vfs, the driver will be dereferencing an invalid
pointer.

Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Venkat Devvuru 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc()

2018-01-08T19:13:44+00:00

flow_type in HWRM_FLOW_ALLOC is not being populated correctly due to
incorrect passing of pointer and size of l3_mask argument of is_wildcard().
Fixed this.

Fixes: db1d36a27324 ("bnxt_en: add TC flower offload flow_alloc/free FW cmds")
Signed-off-by: Sunil Challa 
Reviewed-by: Sathya Perla 
Reviewed-by: Venkat Duvvuru 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnx2x: Improve reliability in case of nested PCI errors

2017-12-27T17:13:32+00:00

While in recovery process of PCI error (called EEH on PowerPC arch),
another PCI transaction could be corrupted causing a situation of
nested PCI errors. Also, this scenario could be reproduced with
error injection mechanisms (for debug purposes).

We observe that in case of nested PCI errors, bnx2x might attempt to
initialize its shmem and cause a kernel crash due to bad addresses
read from MCP. Multiple different stack traces were observed depending
on the point the second PCI error happens.

This patch avoids the crashes by:

 * failing PCI recovery in case of nested errors (since multiple
 PCI errors in a row are not expected to lead to a functional
 adapter anyway), and by,

 * preventing access to adapter FW when MCP is failed (we mark it as
 failed when shmem cannot get initialized properly).

Reported-by: Abdul Haleem 
Signed-off-by: Guilherme G. Piccoli 
Acked-by: Shahed Shaikh 
Signed-off-by: David S. Miller

tg3: Enable PHY reset in MTU change path for 5720

2017-12-27T16:09:06+00:00

A customer noticed RX path hang when MTU is changed on the fly while
running heavy traffic with NCSI enabled for 5717 and 5719. Since 5720
belongs to same ASIC family, we observed same issue and same fix
could solve this problem for 5720.

Signed-off-by: Siva Reddy Kallam 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Add workaround to restrict 5762 MRRS to 2048

2017-12-27T16:08:56+00:00

One of AMD based server with 5762 hangs with jumbo frame traffic.
This AMD platform has southbridge limitation which is restricting MRRS
to 4000. As a work around, driver to restricts the MRRS to 2048 for
this particular 5762 NX1 card.

Signed-off-by: Siva Reddy Kallam 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Update copyright

2017-12-27T16:08:46+00:00

Signed-off-by: Siva Reddy Kallam 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Fix rx hang on MTU change with 5717/5719

2017-12-19T15:23:54+00:00

This fixes a hang issue seen when changing the MTU size from 1500 MTU
to 9000 MTU on both 5717 and 5719 chips. In discussion with Broadcom,
they've indicated that these chipsets have the same phy as the 57766
chipset, so the same workarounds apply. This has been tested by IBM
on both Power 8 and Power 9 systems as well as by Broadcom on x86
hardware and has been confirmed to resolve the hang issue.

Signed-off-by: Brian King 
Signed-off-by: David S. Miller

bnxt_en: Fix sources of spurious netpoll warnings

2017-12-08T19:07:19+00:00

After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and
903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."),
we still see the following WARN fire:

  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 1875170 at net/core/netpoll.c:165 netpoll_poll_dev+0x15a/0x160
  bnxt_poll+0x0/0xd0 exceeded budget in poll
  
  Call Trace:
   [] dump_stack+0x4d/0x70
   [] __warn+0xd3/0xf0
   [] warn_slowpath_fmt+0x4f/0x60
   [] netpoll_poll_dev+0x15a/0x160
   [] netpoll_send_skb_on_dev+0x168/0x250
   [] netpoll_send_udp+0x2dc/0x440
   [] write_ext_msg+0x20e/0x250
   [] call_console_drivers.constprop.23+0xa5/0x110
   [] console_unlock+0x339/0x5b0
   [] vprintk_emit+0x2c8/0x450
   [] vprintk_default+0x1f/0x30
   [] printk+0x48/0x50
   [] edac_raw_mc_handle_error+0x563/0x5c0 [edac_core]
   [] edac_mc_handle_error+0x42b/0x6e0 [edac_core]
   [] sbridge_mce_output_error+0x410/0x10d0 [sb_edac]
   [] sbridge_check_error+0xac/0x130 [sb_edac]
   [] edac_mc_workq_function+0x3c/0x90 [edac_core]
   [] process_one_work+0x19b/0x480
   [] worker_thread+0x6a/0x520
   [] kthread+0xe4/0x100
   [] ret_from_fork+0x22/0x40

This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting
in rx_pkts > 0. Fix this by only bumping rx_pkts if we were actually
given a non-zero budget.

Signed-off-by: Calvin Owens 
Acked-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: Fix a variable scoping in bnxt_hwrm_do_send_msg()

2017-12-03T02:25:38+00:00

short_input variable is assigned to another data pointer which is
referred out of its scope. Fix it by moving short_input definition
to the beginning of bnxt_hwrm_do_send_msg() function.

No failure has been reported so far due to this issue.

Fixes: e605db801bde ("bnxt_en: Support for Short Firmware Message")
Signed-off-by: Vasundhara Volam 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller

bnxt_en: fix dst/src fid for vxlan encap/decap actions

2017-12-03T02:25:38+00:00

For flows that involve a vxlan encap action, the vxlan sock
interface may be specified as the outgoing interface. The driver
must resolve the outgoing PF interface used by this socket and
use the dst_fid of the PF in the hwrm_cfa_encap_record_alloc cmd.

Similarily for flows that have a vxlan decap action, the
fid of the incoming PF interface must be used as the src_fid in
the hwrm_cfa_decap_filter_alloc cmd.

Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Sathya Perla 
Signed-off-by: Michael Chan 
Signed-off-by: David S. Miller