linux.git/drivers/net/e1000e/netdev.c, branch v2.6.38

e1000e: disable broken PHY wakeup for ICH10 LOMs, use MAC wakeup instead

2011-03-02T11:34:27+00:00

When support for 82577/82578 was added[1] in 2.6.31, PHY wakeup was in-
advertently enabled (even though it does not function properly) on ICH10
LOMs.  This patch makes it so that the ICH10 LOMs use MAC wakeup instead
as was done with the initial support for those devices (i.e. 82567LM-3,
82567LF-3 and 82567V-4).

[1] commit a4f58f5455ba0efda36fb33c37074922d1527a10

Reported-by: Aurelien Jarno 
Cc: 
Signed-off-by: Bruce Allan 
Signed-off-by: Jeff Kirsher

e1000e: flush all writebacks before unload

2011-02-17T09:11:21+00:00

The driver was not flushing all writebacks before unloading, possibly
causing memory to be written by the hardware after the driver had
reinitialized the rings.

This adds missing functionality to flush any pending writebacks and is
called in all spots where descriptors should be completed before the driver
begins processing.

Signed-off-by: Jesse Brandeburg 
Reviewed-by: Bruce Allan 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher

e1000e: check down flag in tasks

2011-02-17T08:45:06+00:00

This change is part of a fix to avoid any tasks running while the driver is
exiting and deinitializing resources.

Signed-off-by: Jesse Brandeburg 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher

e1000e: tx_timeout should not increment for non-hang events

2011-02-08T09:10:17+00:00

Currently the driver increments the tx_timeout counter (an error counter)
when simply resetting the part with outstanding transmit work pending.
This is an unnecessary count of an error, when all we should be doing is
just resetting the part and discarding the transmits.  With this change the
only increment of tx_timeout is when the stack calls the watchdog reset
function due to a true Tx timeout.

Signed-off-by: Jesse Brandeburg 
Reviewed-by: Bruce Allan 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher

e1000e: consistent use of Rx/Tx vs. RX/TX/rx/tx in comments/logs

2011-01-14T10:06:23+00:00

Some minor comment errors and whitespace issues discovered while looking
into this are also addressed.

Signed-off-by: Bruce Allan 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher

e1000e: update Copyright for 2011

2011-01-14T10:04:01+00:00

Signed-off-by: Bruce Allan 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher

e1000e: power off PHY after reset when interface is down

2011-01-10T07:44:09+00:00

Some Phys supported by the driver do not remain powered off across a reset
of the device when the interface is down, e.g. on 82571, but not on 82574.
This patch powers down (only when WoL is disabled) the PHY after a reset if
the interface is down and the ethtool diagnostics are not currently running.

The ethtool diagnostic function required a minor re-factor as a result, and
the e1000_[get|put]_hw_control() functions are renamed since they are no
longer static to netdev.c as they are needed by the ethtool diagnostics.
A couple minor whitespace issues were cleaned up, too.

Reported-by: Arthur Jones 
Signed-off-by: Bruce Allan 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000e: properly bounds-check string functions

2011-01-10T07:44:08+00:00

Use string functions with bounds checking rather than their non-bounds
checking counterparts, and do not hard code these boundaries.

Signed-off-by: Bruce Allan 
Tested-by: Emil Tantilov 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000e: cleanup variables set but not used

2011-01-10T07:44:06+00:00

The ICR register is clear on read and we don't care what the returned value
is when resetting the hardware so the icr variable(s) can be removed.  We
should not ignore the return from e1000_lv_jumbo_workaround_ich8lan() and
from e1000_get_phy_id_82571() (dump a debug message when it fails and when
an unknown Phy id is returned).

Signed-off-by: Bruce Allan 
Tested-by: Emil Tantilov 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000e: checkpatch warnings - braces

2010-12-25T05:31:49+00:00

WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Bruce Allan 
Tested-by: Emil Tantilov 
Signed-off-by: Jeff Kirsher