linux.git/drivers/net/e1000, branch v2.6.37

e1000: fix screaming IRQ

2010-11-21T17:54:21+00:00

VMWare reports that the e1000 driver has a bug when bringing down the
interface, such that interrupts are not disabled in the hardware but the
driver stops reporting that it consumed the interrupt.

The fix is to set the driver's "down" flag later in the routine,
after all the timers and such have exited, preventing the interrupt
handler from being called and exiting early without handling the
interrupt.

CC: Anupam Chanda 
CC: stable kernel 
Signed-off-by: Jesse Brandeburg 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000: make e1000_reinit_safe local

2010-10-24T22:07:14+00:00

Signed-off-by: Stephen Hemminger 
Acked-by: Jesse Brandeburg 
Signed-off-by: David S. Miller

vlan: Don't check for vlan group before vlan_tx_tag_present.

2010-10-21T08:26:52+00:00

Many (but not all) drivers check to see whether there is a vlan
group configured before using a tag stored in the skb.  There's
not much point in this check since it just throws away data that
should only be present in the expected circumstances.  However,
it will soon be legal and expected to get a vlan tag when no
vlan group is configured, so remove this check from all drivers
to avoid dropping the tags.

Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller

vlan: Rename VLAN_GROUP_ARRAY_LEN to VLAN_N_VID.

2010-10-21T08:26:50+00:00

VLAN_GROUP_ARRAY_LEN is simply the number of possible vlan VIDs.
Since vlan groups will soon be more of an implementation detail
for vlan devices, rename the constant to be descriptive of its
actual purpose.

Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller

drivers/net: return operator cleanup

2010-09-27T01:34:29+00:00

Change "return (EXPR);" to "return EXPR;"

return is not a function, parentheses are not required.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

e1000: use GRO for receive

2010-09-23T21:33:38+00:00

E1000 can benefit from calling the GRO receive functions.

Signed-off-by: Jesse Brandeburg 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000: fix occasional panic on unload

2010-09-23T21:33:38+00:00

Net drivers in general have an issue where timers fired
by mod_timer or work threads with schedule_work are running
outside of the rtnl_lock.

With no other lock protection these routines are vulnerable
to races with driver unload or reset paths.

The longer term solution to this might be a redesign with
safer locks being taken in the driver to guarantee no
reentrance, but for now a safe and effective fix is
to take the rtnl_lock in these routines.

Signed-off-by: Jesse Brandeburg 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000: use work queues

2010-09-23T21:33:37+00:00

E1000 is using several timers that in a follow on patch
will need to acquire the rtnl_lock in order to be safe.

This patch moves the timer bodies into work queues which
will allow the next patch to add rtnl_lock.

Signed-off-by: Jesse Brandeburg 
Tested-by: Jeff Pieper 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000/e1000e/igb/ixgb/ixgbe: set NETIF_F_HIGHDMA for VLAN feature flags

2010-09-23T04:20:04+00:00

If the netdev->features is set with NETIF_F_HIGHDMA, we should set the
corresponding netdev->vlan_features as well to allow VLAN netdev created
on top of the real netdev to be able to also benefit from HIGHDMA on 32bit
system, reducing the performance hit that is caused by __skb_linearize(),
particularly for large send. This is fixed in this patch for all Intel e1000,
e1000e, igb, ixgbe, and ixgbe drivers since this should be beneficial
to all devices supported by these drivers.

Signed-off-by: Yi Zou 
Tested-by: Emil Tantilov 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

e1000: fix Tx hangs by disabling 64-bit DMA

2010-09-08T21:21:53+00:00

Several users report issues with 32-bit adapters when plugged
into PCI slots in machines with >= 4GB ram.  In particular AMD
systems with HyperTransport to PCI bridges seem to trigger the
issue, but it isn't limited to only them.

This issue is not easily reproducible here, yet still continues
to occur in the field.  For e1000 on PCI devices, just disable DMA
addresses over the 4GB boundary when in PCI (not PCI-X) mode, to
prevent the issue from continuing to pop up.  The performance
impact for this is negligible.

The code was refactored to move the init of the hw struct to its
own function. This allows the init to be called very early in
probe, which then allows using hw-> members for this fix.

A slight refactor to the DMA mask code was done for minor
correctness based on the instructions in DMA-API-HOWTO.

Signed-off-by: Jesse Brandeburg 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller