linux.git/drivers/net/e1000, branch v2.6.23

e1000: Add device IDs of blade version of the 82571 quad port

2007-09-28T03:38:35+00:00

This blade-specific board form factor is identical to the 82571EB
board.

Signed-off-by: Auke Kok 
Signed-off-by: Jeff Garzik

e1000: Add device IDs of new 82571 board variants

2007-08-14T05:54:47+00:00

This patch adds support for 2 new board variants:
- A Quad port fiber 82571 board
- A blade version of the 82571 quad copper board

Signed-off-by: Auke Kok 
Signed-off-by: Jeff Garzik

[NET]: ethtool_perm_addr only has one implementation

2007-07-31T21:00:29+00:00

All drivers implement ethtool get_perm_addr the same way -- by calling
the generic function.  So we can inline the generic function into the
caller and avoid going through the drivers.

Signed-off-by: Matthew Wilcox 
Signed-off-by: David S. Miller

PCI: Change all drivers to use pci_device->revision

2007-07-11T23:02:10+00:00

Instead of all drivers reading pci config space to get the revision
ID, they can now use the pci_device->revision member.

This exposes some issues where drivers where reading a word or a dword
for the revision number, and adding useless error-handling around the
read. Some drivers even just read it for no purpose of all.

In devices where the revision ID is being copied over and used in what
appears to be the equivalent of hotpath, I have left the copy code
and the cached copy as not to influence the driver's performance.

Compile tested with make all{yes,mod}config on x86_64 and i386.

Signed-off-by: Auke Kok 
Acked-by: Dave Jones 
Signed-off-by: Greg Kroah-Hartman

e1000: disable polling before registering netdevice

2007-06-03T15:44:20+00:00

To assure the symmetry of poll enable/disable in up/down, we should
initialize the netdevice to be poll_disabled at load time. Doing
this after register_netdevice leaves us open to another race, so
lets move all the netif_* calls above register_netdevice so the
stack starts out how we expect it to be.

Signed-off-by: Auke Kok 
Cc: Herbert Xu 
Cc: Doug Chapman 
Signed-off-by: Jeff Garzik

e1000: restore netif_poll_enable call but make sure IRQs are off

2007-05-30T13:52:48+00:00

This restores the previously removed netif_poll_enable call in e1000_open.
It's needed on all but the first call to e1000_open for a NIC as
e1000_close always calls netif_poll_disable.

netif_poll_enable can only be called safely if no polls have been
scheduled.  This should be the case as long as we don't enter our IRQ
handler.

In order to guarantee this we explicitly disable IRQs as early as possible
when we're probing the NIC.

Signed-off-by: Herbert Xu 
Cc: "Kok, Auke" 
Cc: Jeff Garzik 
Cc: Andrew Morton 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21T23:41:19+00:00

Herbert Xu wrote:
"netif_poll_enable can only be called if you've previously called
netif_poll_disable.  Otherwise a poll might already be in action
and you may get a crash like this."

Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call to netif_poll_enable is in e1000_up() which is only
reached after a device reset or resume.

Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339

Tested by Doug Chapman 

Signed-off-by: Auke Kok 
Acked-by: Herbert Xu 
Signed-off-by: Jeff Garzik

e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-18T00:43:15+00:00

pci_enable_msi failure is a normal event so we should not print any error.
Going over the code I spotted a missing pci_disable_msi() leak when irq
allocation fails. The whole code also needed a cleanup, so I combined the
two different calls to pci_request_irq into a single call making this
look a lot better. All #ifdef CONFIG_PCI_MSI's have been removed.

Compile tested with both CONFIG_PCI_MSI enabled and disabled.

Signed-off-by: Auke Kok 
Cc: H. Peter Anvin 
Signed-off-by: Jeff Garzik

unify flush_work/flush_work_keventd and rename it to cancel_work_sync

2007-05-09T19:30:53+00:00

flush_work(wq, work) doesn't need the first parameter, we can use cwq->wq
(this was possible from the very beginnig, I missed this).  So we can unify
flush_work_keventd and flush_work.

Also, rename flush_work() to cancel_work_sync() and fix all callers.
Perhaps this is not the best name, but "flush_work" is really bad.

(akpm: this is why the earlier patches bypassed maintainers)

Signed-off-by: Oleg Nesterov 
Cc: Jeff Garzik 
Cc: "David S. Miller" 
Cc: Jens Axboe 
Cc: Tejun Heo 
Cc: Auke Kok ,
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

e1000: use flush_work_keventd()

2007-05-09T19:30:51+00:00

Switch e1000 over to flush_work_keventd().  This probably fixes a netdev-close
versus linkwatch rtnl_lock() deadlock which nobody knew about.

(akpm: bypassed maintainers, sorry.  There are other patches which depend on
this)

Cc: "Maciej W. Rozycki" 
Cc: David Howells 
Cc: "David S. Miller" 
Cc: Jeff Garzik 
Acked-by: Auke Kok 
Cc: Oleg Nesterov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds