linux.git/drivers/net/dsa/hirschmann, branch v6.7

net: dsa: hirschmann: Convert to platform remove callback returning void

2023-09-20T09:25:57+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Reviewed-by: Kurt Kanzenbach 
Signed-off-by: David S. Miller

net: dsa: use capital "OR" for multiple licenses in SPDX

2023-08-24T19:02:53+00:00

Documentation/process/license-rules.rst and checkpatch expect the SPDX
identifier syntax for multiple licenses to use capital "OR".  Correct it
to keep consistent format and avoid copy-paste issues.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Kurt Kanzenbach 
Reviewed-by: FLorian Fainelli 
Link: https://lore.kernel.org/r/20230823085632.116725-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski

net: dsa: hellcreek: Replace bogus comment

2023-08-02T19:10:35+00:00

Replace bogus comment about matching the latched timestamp to one of the
received frames. That comment is probably copied from mv88e6xxx and true for
these switches. However, the hellcreek switch is configured to insert the
timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as
well, because it doesn't add any value.

Signed-off-by: Kurt Kanzenbach 
Reviewed-by: Vladimir Oltean 
Link: https://lore.kernel.org/r/20230801131647.84697-1-kurt@linutronix.de
Signed-off-by: Jakub Kicinski

net: dsa: Explicitly include correct DT includes

2023-07-27T04:54:16+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Reviewed-by: Simon Horman 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20230724211859.805481-1-robh@kernel.org
Signed-off-by: Jakub Kicinski

net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum

2023-05-31T09:00:30+00:00

Inspired from struct flow_cls_offload :: cmd, in order for taprio to be
able to report statistics (which is future work), it seems that we need
to drill one step further with the ndo_setup_tc(TC_SETUP_QDISC_TAPRIO)
multiplexing, and pass the command as part of the common portion of the
muxed structure.

Since we already have an "enable" variable in tc_taprio_qopt_offload,
refactor all drivers to check for "cmd" instead of "enable", and reject
every other command except "replace" and "destroy" - to be future proof.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Horatiu Vultur  # for lan966x
Acked-by: Kurt Kanzenbach  # hellcreek
Reviewed-by: Muhammad Husaini Zulkifli 
Reviewed-by: Gerhard Engleder 
Signed-off-by: David S. Miller

net: dsa: hellcreek: Get rid of custom led_init_default_state_get()

2023-03-17T00:02:56+00:00

LED core provides a helper to parse default state from firmware node.
Use it instead of custom implementation.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Kurt Kanzenbach 
Reviewed-by: Michal Swiatkowski 
Link: https://lore.kernel.org/r/20230314181824.56881-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jakub Kicinski

net: devlink: let the core report the driver name instead of the drivers

2022-12-01T05:49:38+00:00

The driver name is available in device_driver::name. Right now,
drivers still have to report this piece of information themselves in
their devlink_ops::info_get callback function.

In order to factorize code, make devlink_nl_info_fill() add the driver
name attribute.

Now that the core sets the driver name attribute, drivers are not
supposed to call devlink_info_driver_name_put() anymore. Remove
devlink_info_driver_name_put() and clean-up all the drivers using this
function in their callback.

Signed-off-by: Vincent Mailhol 
Tested-by: Ido Schimmel  # mlxsw
Reviewed-by: Jacob Keller  
Reviewed-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski

net: dsa: hellcreek: Offload per-tc max SDU from tc-taprio

2022-09-30T01:52:06+00:00

Add support for configuring the max SDU per priority and per port. If not
specified, keep the default.

Signed-off-by: Kurt Kanzenbach 
Signed-off-by: Vladimir Oltean 
Signed-off-by: Jakub Kicinski

net: dsa: hellcreek: refactor hellcreek_port_setup_tc() to use switch/case

2022-09-30T01:52:05+00:00

The following patch will need to make this function also respond to
TC_QUERY_BASE, so make the processing more structured around the
tc_setup_type.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Kurt Kanzenbach 
Signed-off-by: Jakub Kicinski

net: dsa: hellcreek: remove unnecessary platform_set_drvdata()

2022-09-23T02:30:35+00:00

Remove unnecessary platform_set_drvdata() in ->remove(), the driver_data
will be set to NULL in device_unbind_cleanup() after calling ->remove().

Signed-off-by: Yang Yingliang 
Acked-by: Kurt Kanzenbach 
Signed-off-by: Jakub Kicinski