linux.git/drivers/net/chelsio, branch v2.6.17 Linux kernel source tree kbuild: fix unneeded rebuilds in drivers/net/chelsio after moving source tree 2006-04-04T14:51:41+00:00 Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net 2006-04-03T23:02:30+00:00 1417ae0869472f4f3768779c51c3979faca20b2e This fixes some uneeded rebuilds under drivers/net/chelsio after moving the source tree. The makefiles used $(TOPDIR) for include paths, which is unnecessary. Changed to use relative paths. Compile tested, produces byte-identical code to the previous makefiles. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> 
This fixes some uneeded rebuilds under drivers/net/chelsio after moving
the source tree. The makefiles used $(TOPDIR) for include paths, which
is unnecessary. Changed to use relative paths.

Compile tested, produces byte-identical code to the previous makefiles.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
BUG_ON() Conversion in drivers/net/ 2006-04-02T11:52:48+00:00 Eric Sesterhenn snakebyte@gmx.de 2006-04-02T11:52:48+00:00 5d9428de1a9785f10a4339f80b717be665ba51c7 this changes if() BUG(); constructs to BUG_ON() which is cleaner, contains unlikely() and can better optimized away. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Adrian Bunk <bunk@stusta.de> 
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
[PATCH] Remove MODULE_PARM 2006-03-25T16:22:52+00:00 Rusty Russell rusty@rustcorp.com.au 2006-03-25T11:07:05+00:00 8d3b33f67fdc0fb364a1ef6d8fbbea7c2e4e6c98 MODULE_PARM was actually breaking: recent gcc version optimize them out as unused. It's time to replace the last users, which are generally in the most unloved drivers anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> 
MODULE_PARM was actually breaking: recent gcc version optimize them out as
unused.  It's time to replace the last users, which are generally in the
most unloved drivers anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Merge branch 'upstream-fixes' 2006-03-17T00:27:08+00:00 Jeff Garzik jeff@garzik.org 2006-03-17T00:27:08+00:00 abc71c46dc0a12ab7fddc18cfe4f4aa26808c79b 






[netdrvr] fix array overflows in Chelsio driver
2006-03-17T00:20:40+00:00

Scott Bardone
sbardone@chelsio.com

2006-03-17T00:20:40+00:00

232a347a444e687b5f8cf0f6485704db1c6024d3

Adrian Bunk wrote:
> The Coverity checker spotted the following two array overflows in
> drivers/net/chelsio/sge.c (in both cases, the arrays contain 3
> elements):
[snip]

This is a bug. The array should contain 2 elements.  Here is the fix.

Signed-off-by: Scott Bardone <sbardone@chelsio.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>





Adrian Bunk wrote:
> The Coverity checker spotted the following two array overflows in
> drivers/net/chelsio/sge.c (in both cases, the arrays contain 3
> elements):
[snip]

This is a bug. The array should contain 2 elements.  Here is the fix.

Signed-off-by: Scott Bardone <sbardone@chelsio.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>







[PATCH] chelsio/espi.c:tricn_init(): remove dead code
2006-03-12T01:32:17+00:00

Adrian Bunk
bunk@stusta.de

2006-03-09T23:06:53+00:00

ded78e5e2cab0ec470cca7d34d7af742371bd476

The Coverity checker spotted these two unused variables.

Please check whether this patch is correct or whether they should be
used.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>





The Coverity checker spotted these two unused variables.

Please check whether this patch is correct or whether they should be
used.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>







Merge branch 'upstream-fixes'
2006-03-06T19:38:16+00:00

Jeff Garzik
jeff@garzik.org

2006-03-06T19:38:16+00:00

74f5ec29ae93aa42c49f4285c20c457afe937881












[PATCH] chelsio: fix kmalloc failure in t1_espi_create
2006-03-06T19:38:00+00:00

Eric Sesterhenn
snakebyte@gmx.de

2006-03-04T22:16:00+00:00

2d66806d740eeb410aa785bd7fba3bd24bb082c1

memset() is called before check.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>





memset() is called before check.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>







Massive net driver const-ification.
2006-03-04T02:33:57+00:00

Arjan van de Ven
arjan@infradead.org

2006-03-04T02:33:57+00:00

f71e130966ba429dbd24be08ddbcdf263df9a5ad












[PATCH] chelsio: transmit routine return values
2005-12-24T14:35:17+00:00

Stephen Hemminger
shemminger@osdl.org

2005-12-14T22:38:44+00:00

aa84505fb0fb9504c61d77e8e6930a417fc404d6

The Chelsio driver does not return the correct values from
the transmit routine. It works because the values don't conflict,
but it is using the wrong defines. And -ENOMEM is not a legal return
value.

Since t1_sge_tx is only called in one place, making it static
allows compiler to be potentially inline it.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>





The Chelsio driver does not return the correct values from
the transmit routine. It works because the values don't conflict,
but it is using the wrong defines. And -ENOMEM is not a legal return
value.

Since t1_sge_tx is only called in one place, making it static
allows compiler to be potentially inline it.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>