linux.git/drivers/net/can/usb, branch v3.13

can: peak_usb: fix mem leak in pcan_usb_pro_init()

2013-12-17T10:19:33+00:00

This patch fixes a memory leak in pcan_usb_pro_init(). In patch

    f14e224 net: can: peak_usb: Do not do dma on the stack

the struct pcan_usb_pro_fwinfo *fi and struct pcan_usb_pro_blinfo *bi were
converted from stack to dynamic allocation va kmalloc(). However the
corresponding kfree() was not introduced.

This patch adds the missing kfree().

Cc: linux-stable  # v3.10
Reported-by: Stephane Grosjean 
Signed-off-by: Marc Kleine-Budde

can: ems_usb: fix urb leaks on failure paths

2013-12-17T10:19:11+00:00

There are a couple failure paths where urb leaks.
Is spare code within ems_usb_start_xmit(),
usb_free_urb() should be used to deallocate urb instead of usb_unanchor_urb().
In ems_usb_start() there is no usb_free_urb() if usb_submit_urb() fails.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Sebastian Haas 
Signed-off-by: Marc Kleine-Budde

can: kvaser_usb: fix usb endpoints detection

2013-10-31T19:20:23+00:00

Some devices, like the Kvaser Memorator Professional, have several bulk in
endpoints. Only the first one found must be used by the driver. The same holds
for the bulk out endpoint. The official Kvaser driver (leaf) was used as
reference for this patch.

Cc: linux-stable 
Signed-off-by: Olivier Sobrie 
Signed-off-by: Marc Kleine-Budde

can: pcan_usb_core: fix memory leak on failure paths in peak_usb_start()

2013-09-20T18:58:21+00:00

Tx and rx urbs are not deallocated if something goes wrong in peak_usb_start().
The patch fixes error handling to deallocate all the resources.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Stephane Grosjean 
Signed-off-by: Marc Kleine-Budde

can: pcan_usb: fix wrong memcpy() bytes length

2013-08-12T04:51:49+00:00

Fix possibly wrong memcpy() bytes length since some CAN records received from
PCAN-USB could define a DLC field in range [9..15].
In that case, the real DLC value MUST be used to move forward the record pointer
but, only 8 bytes max. MUST be copied into the data field of the struct
can_frame object of the skb given to the network core.

Cc: linux-stable 
Signed-off-by: Stephane Grosjean 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: David S. Miller

can: usb_8dev: fix urb leak on failure path in usb_8dev_start()

2013-07-19T12:55:14+00:00

If usb_8dev_start() fails to submit urb,
it unanchors the urb but forgets to free it.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Marc Kleine-Budde

net: can: esd_usb2: check index of array before accessing

2013-07-19T12:55:13+00:00

The esd_usb2_read_bulk_callback() function is parsing the data that comes from
the USB CAN adapter. One datum is used as an index to access the dev->nets[]
array. This patch adds the missing bounds checking.

Acked-by: Matthias Fuchs 
Signed-off-by: Maximilian Schneider 
Signed-off-by: Marc Kleine-Budde

can: usb_8dev: unregister netdev before free()ing

2013-06-19T06:56:10+00:00

The usb_8dev hardware has problems on some xhci USB hosts. The driver fails to
read the firmware revision in the probe function. This leads to the following
Oops:

    [ 3356.635912] kernel BUG at net/core/dev.c:5701!

The driver tries to free the netdev, which has already been registered, without
unregistering it.

This patch fixes the problem by unregistering the netdev in the error path.

Reported-by: Michael Olbrich 
Reviewed-by: Bernd Krumboeck 
Signed-off-by: Marc Kleine-Budde

net: can: peak_usb: Do not do dma on the stack

2013-06-03T12:05:32+00:00

smatch reports the following warnings:
drivers/net/can/usb/peak_usb/pcan_usb_pro.c:514 pcan_usb_pro_drv_loaded() error: doing dma on the stack (buffer)
drivers/net/can/usb/peak_usb/pcan_usb_pro.c:878 pcan_usb_pro_init() error: doing dma on the stack (&fi)
drivers/net/can/usb/peak_usb/pcan_usb_pro.c:889 pcan_usb_pro_init() error: doing dma on the stack (&bi)

See "Documentation/DMA-API-HOWTO.txt" section "What memory is DMA'able?"

Cc: Stephane Grosjean 
Signed-off-by: Marc Kleine-Budde

net: can: esd_usb2: Do not do dma on the stack

2013-06-03T12:05:31+00:00

smatch reports the following warnings:
drivers/net/can/usb/esd_usb2.c:640 esd_usb2_start() error: doing dma on the stack (&msg)
drivers/net/can/usb/esd_usb2.c:846 esd_usb2_close() error: doing dma on the stack (&msg)
drivers/net/can/usb/esd_usb2.c:855 esd_usb2_close() error: doing dma on the stack (&msg)
drivers/net/can/usb/esd_usb2.c:923 esd_usb2_set_bittiming() error: doing dma on the stack (&msg)
drivers/net/can/usb/esd_usb2.c:1047 esd_usb2_probe() error: doing dma on the stack (&msg)
drivers/net/can/usb/esd_usb2.c:1053 esd_usb2_probe() error: doing dma on the stack (&msg)

See "Documentation/DMA-API-HOWTO.txt" section "What memory is DMA'able?"

Signed-off-by: Olivier Sobrie 
Cc: Matthias Fuchs 
Signed-off-by: Marc Kleine-Budde