linux.git/drivers/net/can/flexcan.c, branch v4.9

can: flexcan: fix resume function

2016-09-19T14:09:05+00:00

On a imx6ul-pico board the following error is seen during system suspend:

dpm_run_callback(): platform_pm_resume+0x0/0x54 returns -110
PM: Device 2090000.flexcan failed to resume: error -110

The reason for this suspend error is because when the CAN interface is not
active the clocks are disabled and then flexcan_chip_enable() will
always fail due to a timeout error.

In order to fix this issue, only call flexcan_chip_enable/disable()
when the CAN interface is active.

Based on a patch from Dong Aisheng in the NXP kernel.

Signed-off-by: Fabio Estevam 
Cc: linux-stable 
Signed-off-by: Marc Kleine-Budde

can: fix assignment of error location in CAN error messages

2015-11-23T08:37:34+00:00

As Dan Carpenter reported in http://marc.info/?l=linux-can&m=144793696016187
the assignment of the error location in CAN error messages had some bit wise
overlaps. Indeed the value to be assigned in data[3] is no bitfield but defines
a single value which points to a location inside the CAN frame on the wire.

This patch fixes the assignments for the error locations in error messages.

Reported-by: Dan Carpenter 
Signed-off-by: Oliver Hartkopp 
Signed-off-by: Marc Kleine-Budde

can: flexcan: enable interrupts atomically at the end of flexcan_chip_start()

2015-09-21T06:38:23+00:00

This patch defers the writing of the interrupts bits of the CTRL register order
to enables all interrupts atomically at the the of the flexcan_chip_start()
function.

Suggested-by: Torsten Lang 
Signed-off-by: Marc Kleine-Budde

can: flexcan: give member of flexcan_priv holding mailboxes a sensible name

2015-09-21T06:38:23+00:00

This patch gives the member of flexcan_priv holding mailboxes a sensible name,
by renaming from "cantxfg" to "mb":

    struct flexcan_priv::cantxfg -> struct flexcan_priv::mb

Signed-off-by: Marc Kleine-Budde

can: flexcan: use pointer to struct regs instead of void pointer for mmio address space

2015-09-21T06:38:22+00:00

This patch renames the pointer to the mmio address space from "base" to "regs"
and changes the type from "void __iomem *" to "struct flexcan_regs __iomem *".

Signed-off-by: Marc Kleine-Budde

can: flexcan: rename feature into quirks

2015-09-21T06:38:22+00:00

This patch renames the "features" member of struct flexcan_devtype_data to
"quirks". The corresponding defines are renamed too, to reflect what they
actually do.

    FLEXCAN_HAS_V10_FEATURES      -> FLEXCAN_QUIRK_DISABLE_RXFG
    FLEXCAN_HAS_BROKEN_ERR_STATE  -> FLEXCAN_QUIRK_BROKEN_ERR_STATE
    FLEXCAN_HAS_MECR_FEATURES     -> FLEXCAN_QUIRK_DISABLE_MECR

Signed-off-by: Marc Kleine-Budde

can: flexcan: flexcan_chip_start(): cleanup writing of reg_mcr

2015-09-21T06:38:22+00:00

This patch changes the order the individual bits of the mcr register in
flexcan_chip_start() are or'ed together to match the datasheet. The inline
documentation is adjusted accordingly.

Signed-off-by: Marc Kleine-Budde

can: flexcan: remove unused header files

2015-09-21T06:38:22+00:00

This patch removes unused header files from the flexcan driver.

Signed-off-by: Marc Kleine-Budde

can: flexcan: cleanup coding style and fix typos

2015-09-21T06:38:22+00:00

This patch fixes up the coding style to make checkpatch happier. Some typos are
also fixed.

Signed-off-by: Marc Kleine-Budde

can: flexcan: demote register output to debug level

2015-08-20T08:52:54+00:00

This message isn't really helpful for the general reader of the kernel
logs, so should not be printed with info level. All other register
programming outputs in the flexcan driver already use the debug level.

Signed-off-by: Lucas Stach 
Signed-off-by: Marc Kleine-Budde