linux.git/drivers/net/can/dev/rx-offload.c, branch v6.5

can: rx-offload: fix coding style

2023-06-22T07:42:28+00:00

This patch aligns code to match open parenthesis.

Link: https://lore.kernel.org/all/20230620131130.240180-2-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde

can: skb: add skb CAN frame data length helpers

2022-09-15T07:08:08+00:00

Add two helpers to retrieve the data length from CAN sk_buffs and prepare
the length information to be a uint16 value for the CAN XL support.

Acked-by: Vincent Mailhol 
Signed-off-by: Oliver Hartkopp 
Link: https://lore.kernel.org/all/20220912170725.120748-3-socketcan@hartkopp.net
Signed-off-by: Marc Kleine-Budde

can: rx-offload: can_rx_offload_init_queue(): fix typo

2022-09-05T19:54:49+00:00

Fix typo "rounted" -> "rounded".

Link: https://lore.kernel.org/all/20220811093617.1861938-2-mkl@pengutronix.de
Fixes: d254586c3453 ("can: rx-offload: Add support for HW fifo based irq offloading")
Reported-by: Uwe Kleine-König 
Signed-off-by: Marc Kleine-Budde

can: can-dev: remove obsolete CAN LED support

2022-05-19T20:15:51+00:00

Since commit 30f3b42147ba6f ("can: mark led trigger as broken") the
CAN specific LED support was disabled and marked as BROKEN. As the
common LED support with CONFIG_LEDS_TRIGGER_NETDEV should do this work
now the code can be removed as preparation for a CAN netdevice Kconfig
rework.

Link: https://lore.kernel.org/all/20220518154527.29046-1-socketcan@hartkopp.net
Suggested-by: Vincent Mailhol 
Signed-off-by: Oliver Hartkopp 
[mkl: remove led.h from MAINTAINERS]
Signed-off-by: Marc Kleine-Budde

can: can-dev: move to netif_napi_add_weight()

2022-05-19T20:11:28+00:00

We want to remove the weight argument from the basic version of the
netif_napi_add() call. Move all the callers in drivers/net/can that
pass a custom weight (i.e. not NAPI_POLL_WEIGHT or 64) to the
netif_napi_add_weight() API.

Link: https://lore.kernel.org/all/20220517002345.1812104-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski 
Signed-off-by: Marc Kleine-Budde

can: rx-offload: rename can_rx_offload_queue_sorted() -> can_rx_offload_queue_timestamp()

2022-04-19T14:58:04+00:00

This patch renames the function can_rx_offload_queue_sorted() to
can_rx_offload_queue_timestamp(). This better describes what the
function does, it adds a newly RX'ed skb to the sorted queue by its
timestamp.

Link: https://lore.kernel.org/all/20220417194327.2699059-1-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde

can: do not increase rx_bytes statistics for RTR frames

2022-01-05T11:09:05+00:00

The actual payload length of the CAN Remote Transmission Request (RTR)
frames is always 0, i.e. no payload is transmitted on the wire.
However, those RTR frames still use the DLC to indicate the length of
the requested frame.

As such, net_device_stats::rx_bytes should not be increased for the
RTR frames.

This patch fixes all the CAN drivers.

Link: https://lore.kernel.org/all/20211207121531.42941-5-mailhol.vincent@wanadoo.fr
Cc: Marc Kleine-Budde 
Cc: Nicolas Ferre 
Cc: Alexandre Belloni 
Cc: Ludovic Desroches 
Cc: Chandrasekar Ramakrishnan 
Cc: Maxime Ripard 
Cc: Chen-Yu Tsai 
Cc: Jernej Skrabec 
Cc: Yasushi SHOJI 
Cc: Appana Durga Kedareswara rao 
Cc: Naga Sureshkumar Relli 
Cc: Michal Simek 
Cc: Stephane Grosjean 
Tested-by: Jimmy Assarsson  # kvaser
Signed-off-by: Vincent Mailhol 
Acked-by: Stefan Mätje  # esd_usb2
Tested-by: Stefan Mätje  # esd_usb2
Signed-off-by: Marc Kleine-Budde

can: do not increase rx statistics when generating a CAN rx error message frame

2022-01-05T11:09:05+00:00

The CAN error message frames (i.e. error skb) are an interface
specific to socket CAN. The payload of the CAN error message frames
does not correspond to any actual data sent on the wire. Only an error
flag and a delimiter are transmitted when an error occurs (c.f. ISO
11898-1 section 10.4.4.2 "Error flag").

For this reason, it makes no sense to increment the rx_packets and
rx_bytes fields of struct net_device_stats because no actual payload
were transmitted on the wire.

This patch fixes all the CAN drivers.

Link: https://lore.kernel.org/all/20211207121531.42941-2-mailhol.vincent@wanadoo.fr
CC: Marc Kleine-Budde 
CC: Nicolas Ferre 
CC: Alexandre Belloni 
CC: Ludovic Desroches 
CC: Chandrasekar Ramakrishnan 
CC: Maxime Ripard 
CC: Chen-Yu Tsai 
CC: Jernej Skrabec 
CC: Appana Durga Kedareswara rao 
CC: Naga Sureshkumar Relli 
CC: Michal Simek 
CC: Stephane Grosjean 
Tested-by: Jimmy Assarsson  # kvaser
Signed-off-by: Vincent Mailhol 
Acked-by: Stefan Mätje  # esd_usb2
Tested-by: Stefan Mätje  # esd_usb2
Signed-off-by: Marc Kleine-Budde

can: rx-offload: can_rx_offload_threaded_irq_finish(): add new function to be called from threaded interrupt

2021-07-25T09:36:25+00:00

After reading all CAN frames from the controller in the IRQ handler
and storing them into a skb_queue, the driver calls napi_schedule().
In the napi poll function the skb from the skb_queue are then pushed
into the networking stack.

However if napi_schedule() is called from a threaded IRQ handler this
triggers the following error:

| NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!

To avoid this, create a new rx-offload
function (can_rx_offload_threaded_irq_finish()) with a call to
local_bh_disable()/local_bh_enable() around the napi_schedule() call.

Convert all drivers that call can_rx_offload_irq_finish() from
threaded IRQ context to can_rx_offload_threaded_irq_finish().

Link: https://lore.kernel.org/r/20210724204745.736053-4-mkl@pengutronix.de
Suggested-by: Daniel Glöckner 
Tested-by: Oleksij Rempel 
Signed-off-by: Marc Kleine-Budde

can: rx-offload: can_rx_offload_irq_finish(): directly call napi_schedule()

2021-07-25T09:36:25+00:00

Instead of calling can_rx_offload_schedule() call napi_schedule()
directly. As this was the last use of can_rx_offload_schedule() remove
this helper function.

Link: https://lore.kernel.org/r/20210724204745.736053-3-mkl@pengutronix.de
Tested-by: Oleksij Rempel 
Signed-off-by: Marc Kleine-Budde